From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by sourceware.org (Postfix) with ESMTPS id 964073851C0C for ; Mon, 22 Jun 2020 20:11:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 964073851C0C Received: by mail-wm1-x344.google.com with SMTP id g21so843708wmg.0 for ; Mon, 22 Jun 2020 13:11:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=shiycHcH7tK3SllTttLCyoMzHW6xV5FPs+tb3EnHkxU=; b=AB3cYW5Ee6f2VwuKR+KnkS167lBpZinWT8hLGEfmFPcWBMUkhiCoks+N6pSAdpcxKW 5GckgtNirEjOE+JEJsMTokQ3rnlg7ZjKepfr8c1vMVagtAoUdo3F2wfmJgKMYe+er34C ank6DNR6URTHleeEfkU05hDmaEeQpfaUfSaeWrP/xSd/cMvhubqUgj8LqrEAN2e5C66x xewlFeRPScrcpuFvEpwq+9z+1/suv3u1a8NQwfu8cWpKmlGraICy/+NW0VZWvQFzmn5J h7Yd1+Sp2HCITXRtqXB86ZcSl5Z1UJEwaceMdyC7PurKSPUOnVMEWxHDnJLlvP0u5ijN fvVg== X-Gm-Message-State: AOAM5319WUDLbmMazV75BqgpbyUOkP9cZJFEvlRltIvXHy7A0JY9jmtE kqxlFpJXIZ+hanmeuz7lXGfvQg== X-Google-Smtp-Source: ABdhPJxt//hZj13SPlWi8e8xpehUS4tw6JYC1c4ZVtSj0AGBkobU34zVJHDgYXHQdFAXhJimKUl7+A== X-Received: by 2002:a1c:ab04:: with SMTP id u4mr21431194wme.52.1592856665459; Mon, 22 Jun 2020 13:11:05 -0700 (PDT) Received: from google.com ([2a00:79e0:d:110:673c:7143:200f:54b7]) by smtp.gmail.com with ESMTPSA id a4sm10557887wrg.80.2020.06.22.13.11.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Jun 2020 13:11:04 -0700 (PDT) Date: Mon, 22 Jun 2020 22:11:04 +0200 From: Matthias Maennich To: Giuliano Procida Cc: libabigail@sourceware.org, dodji@seketeli.org, kernel-team@android.com Subject: Re: [PATCH 0/2] Type identity clean-ups Message-ID: <20200622201104.GB75581@google.com> References: <20200619163924.207852-1-gprocida@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20200619163924.207852-1-gprocida@google.com> X-Spam-Status: No, score=-24.2 required=5.0 tests=BAYES_00, DKIMWL_WL_MED, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, ENV_AND_HDR_SPF_MATCH, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, USER_IN_DEF_DKIM_WL, USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Jun 2020 20:11:08 -0000 On Fri, Jun 19, 2020 at 05:39:22PM +0100, Giuliano Procida wrote: >Hi Dodji. > >I've been looking at how libabigail compares types and decides two >types are the same. These are a couple of incidental commits prompted >by this investigation. > >The commit message of the second patch below makes a couple of >statements as if they were true, but they are in fact somewhat >speculative. Please review with this in mind. Thanks! > >Regards, >Giuliano. Those look generally fine to me, would defer to Dodji for final judgement. Acked-by: Matthias Maennich Cheers, Matthias > >Giuliano Procida (2): > abg-ir.cc: Remove unused re_canonicalize function. > Use pointers not strings in type graph comparison. > > include/abg-fwd.h | 3 - > include/abg-ir.h | 5 - > src/abg-ir.cc | 37 +- > .../PR25058-liblttng-ctl-report-1.txt | 239 +++++- > ....el7.x86_64-multiple-sym-vers-report-0.txt | 2 +- > ...l7.x86_64-0.12.8-1.el7.x86_64-report-2.txt | 734 ++++++++++++------ > ...l7.x86_64-0.12.8-1.el7.x86_64-report-3.txt | 162 +++- > 7 files changed, 909 insertions(+), 273 deletions(-) > >-- >2.27.0.111.gc72c7da667-goog >