From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <3U438XggKCl4CLNK8E96CKKCHA.8KIHE767EC6EHOKQN8AS6NA.KNC@flex--gprocida.bounces.google.com> Received: from mail-wr1-x44a.google.com (mail-wr1-x44a.google.com [IPv6:2a00:1450:4864:20::44a]) by sourceware.org (Postfix) with ESMTPS id 2B66F3857007 for ; Wed, 1 Jul 2020 13:19:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 2B66F3857007 Received: by mail-wr1-x44a.google.com with SMTP id a18so20600097wrm.14 for ; Wed, 01 Jul 2020 06:19:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=rvqJRzAfDvd5eyz0TJjxQQXojeKVRBMR0RX+xE9GuKc=; b=nOn0Dpoj1D6jHHCM0CylGMSKmen2MSqLYDFrv3QRaw8nGKiD3oO/+idLmN5iU8lOss Ad3PpDizgKsHDMJmbjr2c55pxRet+P4PDTzvKRFG3zUlcTDrzO6LL0xY4NXYch+sI7AJ vWhtvYARmef57WMOzRTq0XBmlIugS5h94W/Kw0L76AyiFuGlyF8vBPHl1V+pDkAOv0By T2ZGeeNh4Y5dBGZsgNFDiFLFIzJavUQrDjIvX8aoY8BYb1LufGzWuqTdpL81/hWkJlRD 3HLYV9rulLCpCro6Wd9Eeow/vf8OX73BP2yCqieGhE3SwxccxAau+yvWKhlY6BP6Cnkx d6eQ== X-Gm-Message-State: AOAM530T55yTAJpiDQZWsRrIovTdck92+erb+y3VM44XlRUCqLz6fgbu plCy3hpVziztuSGaId0hJf2EZ+2Ao8mX4d4/n3tgHcSwY/tToPGpd7LKH0lQaVyHNrE13/zy6PO ibF8Hgf0bPOg7xA8de1Tns0oelK3plhWMLv8icQyBA5ReLLA3Qnpwv+N8vinRA8AZeaNVfpQ= X-Google-Smtp-Source: ABdhPJwrAcK/uwHfx6keyzpIBygRexRUWrEh6m+bFN3BvCW3IGQ0d0fAgeWow1mXfPlBxE9DYifnfiM6jzxiqg== X-Received: by 2002:adf:f20a:: with SMTP id p10mr28366621wro.41.1593609555873; Wed, 01 Jul 2020 06:19:15 -0700 (PDT) Date: Wed, 1 Jul 2020 14:19:06 +0100 In-Reply-To: <20200330091754.GH101337@google.com> Message-Id: <20200701131907.2665674-1-gprocida@google.com> Mime-Version: 1.0 References: <20200330091754.GH101337@google.com> X-Mailer: git-send-email 2.27.0.212.ge8ba1cc988-goog Subject: [PATCH v3 0/1] Fix abidiff exit code when diffs are suppressed From: Giuliano Procida To: libabigail@sourceware.org Cc: dodji@seketeli.org, kernel-team@android.com, gprocida@google.com, maennich@google.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-18.7 required=5.0 tests=BAYES_00, DKIMWL_WL_MED, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Jul 2020 13:19:18 -0000 This is an update for a patch sent for review a while ago. We're been running with the previous version for a while and discovered the fix was incomplete. This version includes tests (as requested in review) to verify the expected behaviour. Regards, Giuliano. Giuliano Procida (1): Fix has_net_changes for --leaf-changes-only mode src/abg-comparison.cc | 26 +++++++---- tests/data/Makefile.am | 9 ++++ .../test-net-change-report0.txt | 43 ++++++++++++++++++ .../test-net-change-report1.txt | 3 ++ .../test-net-change-report2.txt | 42 +++++++++++++++++ .../test-net-change-report3.txt | 5 ++ .../test-abidiff-exit/test-net-change-v0.c | 14 ++++++ .../test-abidiff-exit/test-net-change-v0.o | Bin 0 -> 3512 bytes .../test-abidiff-exit/test-net-change-v1.c | 14 ++++++ .../test-abidiff-exit/test-net-change-v1.o | Bin 0 -> 3552 bytes .../test-net-change.abignore | 8 ++++ tests/test-abidiff-exit.cc | 38 ++++++++++++++++ 12 files changed, 192 insertions(+), 10 deletions(-) create mode 100644 tests/data/test-abidiff-exit/test-net-change-report0.txt create mode 100644 tests/data/test-abidiff-exit/test-net-change-report1.txt create mode 100644 tests/data/test-abidiff-exit/test-net-change-report2.txt create mode 100644 tests/data/test-abidiff-exit/test-net-change-report3.txt create mode 100644 tests/data/test-abidiff-exit/test-net-change-v0.c create mode 100644 tests/data/test-abidiff-exit/test-net-change-v0.o create mode 100644 tests/data/test-abidiff-exit/test-net-change-v1.c create mode 100644 tests/data/test-abidiff-exit/test-net-change-v1.o create mode 100644 tests/data/test-abidiff-exit/test-net-change.abignore -- 2.27.0.212.ge8ba1cc988-goog