From: Giuliano Procida <gprocida@google.com>
To: libabigail@sourceware.org
Cc: dodji@seketeli.org, kernel-team@android.com, gprocida@google.com,
maennich@google.com
Subject: [PATCH v2 3/3] Enable Clang's -Werror-overloaded-virtual.
Date: Thu, 9 Jul 2020 19:51:34 +0100 [thread overview]
Message-ID: <20200709185134.1686136-1-gprocida@google.com> (raw)
In-Reply-To: <20200709182250.1677238-4-gprocida@google.com>
Ths warning is no longer triggered and can be reenabled.
* configure.ac: Remove the special clause that disabled
-Werror-overloaded-virtual for Clang builds.
Signed-off-by: Giuliano Procida <gprocida@google.com>
---
configure.ac | 6 ------
1 file changed, 6 deletions(-)
diff --git a/configure.ac b/configure.ac
index 225ac38f..904a726e 100644
--- a/configure.ac
+++ b/configure.ac
@@ -646,12 +646,6 @@ if test x$ENABLE_UBSAN = xyes; then
CXXFLAGS="$CXXFLAGS -fsanitize=undefined"
fi
-dnl Check if we compile with clang and set flags accordingly
-dnl TODO: fix that warning (spoiler: not trivial)
-if `$CXX -v 2>&1 | grep 'clang version' > /dev/null 2>&1`; then
- CXXFLAGS="$CXXFLAGS -Wno-error-overloaded-virtual"
-fi
-
dnl Check if several decls and constant are defined in dependant
dnl libraries
HAS_EM_AARCH64=no
--
2.27.0.383.g050319c2ae-goog
next prev parent reply other threads:[~2020-07-09 18:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-09 16:45 [PATCH] Drop traversable_base::traverse method Giuliano Procida
2020-07-09 18:22 ` [PATCH 0/3] Bug 21485 - problems compiling with clang Giuliano Procida
2020-07-09 18:22 ` [PATCH 1/3] Drop traversable_base::traverse method Giuliano Procida
2020-07-10 16:26 ` Matthias Maennich
2020-07-27 16:03 ` Dodji Seketeli
2020-07-09 18:22 ` [PATCH 2/3] Fix inheritance of scope_decl::insert_member_decl Giuliano Procida
2020-07-10 16:27 ` Matthias Maennich
2020-07-27 16:14 ` Dodji Seketeli
2020-07-09 18:22 ` [PATCH 3/3] Enable Clang's -Werror-overloaded-virtual Giuliano Procida
2020-07-09 18:51 ` Giuliano Procida [this message]
2020-07-10 16:28 ` [PATCH v2 " Matthias Maennich
2020-07-27 16:26 ` Dodji Seketeli
2020-07-27 16:27 ` [PATCH 0/3] Bug 21485 - problems compiling with clang Dodji Seketeli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200709185134.1686136-1-gprocida@google.com \
--to=gprocida@google.com \
--cc=dodji@seketeli.org \
--cc=kernel-team@android.com \
--cc=libabigail@sourceware.org \
--cc=maennich@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).