From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by sourceware.org (Postfix) with ESMTPS id A20213842400 for ; Fri, 10 Jul 2020 16:28:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org A20213842400 Received: by mail-wm1-x343.google.com with SMTP id w3so6496679wmi.4 for ; Fri, 10 Jul 2020 09:28:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=HvgW9GDLL9sfD9BR0SC0/9CuhGW7OEyxBBjt2LejD04=; b=D1KEuLM+M9/pO1PSD/Xu85ggtH5thjr+U1mbwxGVwMwrste0lvBq6NRavoViJ32ylu l4a76VE1Ds054HGfb5bl5tvPUu7RJjn2ar1kDHFF0yuPCXw9o57Xj9N5O4DELX5EFrvn vibaQNEruhXUpx4UkhFIJJ2ztn734eR7Tjt9ctEV7iqsr1ZKKK3V5m9DyJTCeex6Wugj T4YUcpcqA0/Z/YRaFuPYMw6X7dsksOtNA0SxDFnAPUuzHWotOC9IAN+6TzA9HoP0uHpi KxuGqqNtuKfiwK1rvXgtMXlLSbSJ9WsW7/UdO5JkzcRmqDeSsxa7Qf8DELjj9STAvhbT sQUw== X-Gm-Message-State: AOAM532U5nu61xIrVnBSsdPDY8y3In/kA6iPKC4MoKeodMMvB26t/OS8 H0MfPoan4LS4276X8kksiXRqSA== X-Google-Smtp-Source: ABdhPJyHAZbhsVR8MS80eqt8wYFmWDSPQrEn3Moum1JdZ4oSlcApd2ebCjDzWllzZD2DYB+VNGodzg== X-Received: by 2002:a1c:f203:: with SMTP id s3mr5829282wmc.126.1594398496485; Fri, 10 Jul 2020 09:28:16 -0700 (PDT) Received: from google.com ([2a00:79e0:d:110:7220:84ff:fe09:a3aa]) by smtp.gmail.com with ESMTPSA id d18sm11430614wrj.8.2020.07.10.09.28.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Jul 2020 09:28:15 -0700 (PDT) Date: Fri, 10 Jul 2020 18:28:15 +0200 From: Matthias Maennich To: Giuliano Procida Cc: libabigail@sourceware.org, dodji@seketeli.org, kernel-team@android.com Subject: Re: [PATCH v2 3/3] Enable Clang's -Werror-overloaded-virtual. Message-ID: <20200710162815.GI995455@google.com> References: <20200709182250.1677238-4-gprocida@google.com> <20200709185134.1686136-1-gprocida@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20200709185134.1686136-1-gprocida@google.com> X-Spam-Status: No, score=-29.1 required=5.0 tests=BAYES_00, DKIMWL_WL_MED, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, ENV_AND_HDR_SPF_MATCH, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, USER_IN_DEF_DKIM_WL, USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Jul 2020 16:28:22 -0000 On Thu, Jul 09, 2020 at 07:51:34PM +0100, Giuliano Procida wrote: >Ths warning is no longer triggered and can be reenabled. > > * configure.ac: Remove the special clause that disabled > -Werror-overloaded-virtual for Clang builds. > >Signed-off-by: Giuliano Procida Reviewed-by: Matthias Maennich Cheers, Matthias >--- > configure.ac | 6 ------ > 1 file changed, 6 deletions(-) > >diff --git a/configure.ac b/configure.ac >index 225ac38f..904a726e 100644 >--- a/configure.ac >+++ b/configure.ac >@@ -646,12 +646,6 @@ if test x$ENABLE_UBSAN = xyes; then > CXXFLAGS="$CXXFLAGS -fsanitize=undefined" > fi > >-dnl Check if we compile with clang and set flags accordingly >-dnl TODO: fix that warning (spoiler: not trivial) >-if `$CXX -v 2>&1 | grep 'clang version' > /dev/null 2>&1`; then >- CXXFLAGS="$CXXFLAGS -Wno-error-overloaded-virtual" >-fi >- > dnl Check if several decls and constant are defined in dependant > dnl libraries > HAS_EM_AARCH64=no >-- >2.27.0.383.g050319c2ae-goog >