From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by sourceware.org (Postfix) with ESMTP id 24E163842400 for ; Fri, 10 Jul 2020 17:01:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 24E163842400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-246-oDSXn-_FMOOV25k2KppWtw-1; Fri, 10 Jul 2020 13:00:50 -0400 X-MC-Unique: oDSXn-_FMOOV25k2KppWtw-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 217C98014D7; Fri, 10 Jul 2020 17:00:47 +0000 (UTC) Received: from localhost (unknown [10.33.36.71]) by smtp.corp.redhat.com (Postfix) with ESMTP id D923E6FEF6; Fri, 10 Jul 2020 17:00:42 +0000 (UTC) Date: Fri, 10 Jul 2020 18:00:41 +0100 From: Jonathan Wakely To: Dodji Seketeli Cc: Benjamin Kosnik , Ben Woodard , Chenxiong Qi , Giuliano Procida , Jan Engelhardt , Jessica Yu , Mark Wielaard , Matthias Klose , Matthias Maennich , Ondrej Oprala , Roland McGrath , Sinny Kumari , Slava Barinov , libabigail@sourceware.org Subject: Re: [PATCH 2/9] Add missing SPDX headers to source files not specifying any license Message-ID: <20200710170041.GA1452842@redhat.com> References: <87wo3bo45b.fsf@redhat.com> MIME-Version: 1.0 In-Reply-To: <87wo3bo45b.fsf@redhat.com> X-Clacks-Overhead: GNU Terry Pratchett X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline X-Spam-Status: No, score=-15.2 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Jul 2020 17:01:15 -0000 Signed-off-by: Jonathan Wakely On 10/07/20 16:06 +0200, Dodji Seketeli wrote: >Default to the project's defautl - LGPLv3+ - for those. > > * Makefile.am: Add a LGPL-3.0-or-later SPDX header prefixed > with '##' so that that the header doesn't get emitted in the > resulting Makefile.in file. Note that the license of Makefile.in > files is "FSF All Permissible License", which virtually compatible > with anything. > * bash-completion/Makefile.am: Likewise. > * doc/Makefile.am: Likewise > * doc/manuals/Makefile.am: Likewise > * include/Makefile.am: Likewise > * src/Makefile.am: Likewise > * tests/Makefile.am: Likewise > * tests/data/Makefile.am: Likewise > * tools/Makefile.am: Likewise > * .clang-format: Add a LGPL-3.0-or-later SPDX header. > * bash-completion/abicompat: Likewise. > * bash-completion/abidiff: Likewise. > * bash-completion/abidw: Likewise. > * bash-completion/abilint: Likewise. > * bash-completion/abinilint: Likewise. > * bash-completion/abipkgdiff: Likewise. > * bash-completion/abisym: Likewise. > * bash-completion/fedabipkgdiff: Likewise. > * configure.ac: Likewise. > * default.abignore: Likewise. > * doc/api/libabigail.doxy: Likewise. > * doc/website/libabigail-website.doxy: Likewise. > * include/abg-version.h.in: Likewise. > * scripts/dot_to_png.sh: Likewise. > * scripts/dot_to_svg.sh: Likewise. > * scripts/make-verbose.sh: Likewise. > * scripts/svg_to_plain_svg.sh: Likewise. > * scripts/svg_to_png_and_pdf.sh: Likewise. > * tests/runtestcanonicalizetypes.sh.in: Likewise. > * tests/runtestdefaultsupprs.py.in: Likewise. > * tests/runtestdefaultsupprspy3.sh.in: Likewise. > * tests/runtestfedabipkgdiffpy3.sh.in: Likewise. > * tests/update-test-output.py: Likewise. > * update-copyright.sh: Likewise. > >Signed-off-by: Matthias Maennich >Signed-off-by: Dodji Seketeli >--- > .clang-format | 1 + > Makefile.am | 1 + > bash-completion/Makefile.am | 1 + > bash-completion/abicompat | 1 + > bash-completion/abidiff | 1 + > bash-completion/abidw | 1 + > bash-completion/abilint | 1 + > bash-completion/abinilint | 1 + > bash-completion/abipkgdiff | 1 + > bash-completion/abisym | 1 + > bash-completion/fedabipkgdiff | 1 + > configure.ac | 1 + > default.abignore | 4 +++- > doc/Makefile.am | 1 + > doc/api/libabigail.doxy | 2 ++ > doc/manuals/Makefile.am | 2 ++ > doc/website/libabigail-website.doxy | 1 + > include/Makefile.am | 1 + > include/abg-version.h.in | 1 + > scripts/dot_to_png.sh | 1 + > scripts/dot_to_svg.sh | 1 + > scripts/make-verbose.sh | 1 + > scripts/svg_to_plain_svg.sh | 1 + > scripts/svg_to_png_and_pdf.sh | 1 + > src/Makefile.am | 1 + > tests/Makefile.am | 1 + > tests/data/Makefile.am | 2 +- > tests/runtestcanonicalizetypes.sh.in | 1 + > tests/runtestdefaultsupprs.py.in | 1 + > tests/runtestdefaultsupprspy3.sh.in | 1 + > tests/runtestfedabipkgdiffpy3.sh.in | 1 + > tests/update-test-output.py | 1 + > tools/Makefile.am | 1 + > update-copyright.sh | 1 + > 34 files changed, 38 insertions(+), 2 deletions(-) > >diff --git a/.clang-format b/.clang-format >index 1dd679d..234be76 100644 >--- a/.clang-format >+++ b/.clang-format >@@ -1,3 +1,4 @@ >+# SPDX-License-Identifier: LGPL-3.0-or-later > --- > BasedOnStyle: GNU > AlignConsecutiveDeclarations: true >diff --git a/Makefile.am b/Makefile.am >index f4dbff2..a73df46 100644 >--- a/Makefile.am >+++ b/Makefile.am >@@ -1,3 +1,4 @@ >+## SPDX-License-Identifier: LGPL-3.0-or-later > SUBDIRS = include src tools tests doc bash-completion > ACLOCAL_AMFLAGS = -I m4 ${ACLOCAL_FLAGS} > headers = config.h >diff --git a/bash-completion/Makefile.am b/bash-completion/Makefile.am >index 004474e..e7027ee 100644 >--- a/bash-completion/Makefile.am >+++ b/bash-completion/Makefile.am >@@ -1,3 +1,4 @@ >+## SPDX-License-Identifier: LGPL-3.0-or-later > #if ENABLE_BASH_COMPLETION > EXTRA_DIST = \ > abicompat \ >diff --git a/bash-completion/abicompat b/bash-completion/abicompat >index a5c87a1..d4ff950 100644 >--- a/bash-completion/abicompat >+++ b/bash-completion/abicompat >@@ -1,3 +1,4 @@ >+# SPDX-License-Identifier: LGPL-3.0-or-later > _abicompat_module() > { > local cur prev OPTS >diff --git a/bash-completion/abidiff b/bash-completion/abidiff >index edd33c3..3e0ae5b 100644 >--- a/bash-completion/abidiff >+++ b/bash-completion/abidiff >@@ -1,3 +1,4 @@ >+# SPDX-License-Identifier: LGPL-3.0-or-later > _abidiff_module() > { > local cur prev OPTS >diff --git a/bash-completion/abidw b/bash-completion/abidw >index 53463ae..b83bc62 100644 >--- a/bash-completion/abidw >+++ b/bash-completion/abidw >@@ -1,3 +1,4 @@ >+# SPDX-License-Identifier: LGPL-3.0-or-later > _abidw_module() > { > local cur prev OPTS >diff --git a/bash-completion/abilint b/bash-completion/abilint >index 7df78d1..d34d243 100644 >--- a/bash-completion/abilint >+++ b/bash-completion/abilint >@@ -1,3 +1,4 @@ >+# SPDX-License-Identifier: LGPL-3.0-or-later > _abilint_module() > { > local cur prev OPTS >diff --git a/bash-completion/abinilint b/bash-completion/abinilint >index 137b839..0c24079 100644 >--- a/bash-completion/abinilint >+++ b/bash-completion/abinilint >@@ -1,3 +1,4 @@ >+# SPDX-License-Identifier: LGPL-3.0-or-later > _abinilint_module() > { > local cur prev OPTS >diff --git a/bash-completion/abipkgdiff b/bash-completion/abipkgdiff >index fc4f7cd..894798b 100644 >--- a/bash-completion/abipkgdiff >+++ b/bash-completion/abipkgdiff >@@ -1,3 +1,4 @@ >+# SPDX-License-Identifier: LGPL-3.0-or-later > _abipkgdiff_module() > { > local cur prev OPTS >diff --git a/bash-completion/abisym b/bash-completion/abisym >index dff4986..25bb075 100644 >--- a/bash-completion/abisym >+++ b/bash-completion/abisym >@@ -1,3 +1,4 @@ >+# SPDX-License-Identifier: LGPL-3.0-or-later > _abisym_module() > { > local cur prev OPTS >diff --git a/bash-completion/fedabipkgdiff b/bash-completion/fedabipkgdiff >index d074419..2bfa468 100644 >--- a/bash-completion/fedabipkgdiff >+++ b/bash-completion/fedabipkgdiff >@@ -1,3 +1,4 @@ >+# SPDX-License-Identifier: LGPL-3.0-or-later > _fedabipkgdiff_module() > { > local cur OPTS >diff --git a/configure.ac b/configure.ac >index 225ac38..73801aa 100644 >--- a/configure.ac >+++ b/configure.ac >@@ -1,3 +1,4 @@ >+# SPDX-License-Identifier: LGPL-3.0-or-later > m4_define([version_major], [1]) > m4_define([version_minor], [8]) > >diff --git a/default.abignore b/default.abignore >index 4e320ba..3916f54 100644 >--- a/default.abignore >+++ b/default.abignore >@@ -1,3 +1,5 @@ >+# SPDX-License-Identifier: LGPL-3.0-or-later >+# > # This file contains default system-wide suppression specifications to > # be used by Abigail tools[1] to filter out specific ABI change > # reports when comparing the ABI of some core system binaries. >@@ -171,4 +173,4 @@ > soname_regexp = libvirt\\.so.* > #################################################### > # End of libvirt default suppression specifications >-#################################################### >\ No newline at end of file >+#################################################### >diff --git a/doc/Makefile.am b/doc/Makefile.am >index 0794efd..840fc7c 100644 >--- a/doc/Makefile.am >+++ b/doc/Makefile.am >@@ -1,3 +1,4 @@ >+## SPDX-License-Identifier: LGPL-3.0-or-later > SUBDIRS = manuals > > EXTRA_DIST = api/libabigail.doxy website/libabigail-website.doxy >diff --git a/doc/api/libabigail.doxy b/doc/api/libabigail.doxy >index b460d26..a7cb987 100644 >--- a/doc/api/libabigail.doxy >+++ b/doc/api/libabigail.doxy >@@ -1,3 +1,5 @@ >+# SPDX-License-Identifier: LGPL-3.0-or-later >+# > # Doxyfile 1.8.3.1 > > # This file describes the settings to be used by the documentation system >diff --git a/doc/manuals/Makefile.am b/doc/manuals/Makefile.am >index 5c31fa3..342faf2 100644 >--- a/doc/manuals/Makefile.am >+++ b/doc/manuals/Makefile.am >@@ -1,3 +1,5 @@ >+## SPDX-License-Identifier: LGPL-3.0-or-later >+# > # Makefile for Sphinx documentation > > EXTRA_DIST = \ >diff --git a/doc/website/libabigail-website.doxy b/doc/website/libabigail-website.doxy >index 2bf9fb4..f86ff02 100644 >--- a/doc/website/libabigail-website.doxy >+++ b/doc/website/libabigail-website.doxy >@@ -1,3 +1,4 @@ >+# SPDX-License-Identifier: LGPL-3.0-or-later > # Doxyfile 1.8.3.1 > > # This file describes the settings to be used by the documentation system >diff --git a/include/Makefile.am b/include/Makefile.am >index b547525..e707c62 100644 >--- a/include/Makefile.am >+++ b/include/Makefile.am >@@ -1,3 +1,4 @@ >+## SPDX-License-Identifier: LGPL-3.0-or-later > pkginclude_HEADERS = \ > abg-sptr-utils.h \ > abg-interned-str.h \ >diff --git a/include/abg-version.h.in b/include/abg-version.h.in >index 7d828a0..5c56459 100644 >--- a/include/abg-version.h.in >+++ b/include/abg-version.h.in >@@ -1,3 +1,4 @@ >+// SPDX-License-Identifier: LGPL-3.0-or-later > #ifndef __ABG_VERSION_H__ > #define __ABG_VERSION_H__ > #define ABIGAIL_VERSION_MAJOR "@VERSION_MAJOR@" >diff --git a/scripts/dot_to_png.sh b/scripts/dot_to_png.sh >index 0929bdd..8125d15 100755 >--- a/scripts/dot_to_png.sh >+++ b/scripts/dot_to_png.sh >@@ -1,4 +1,5 @@ > #!/bin/bash >+# SPDX-License-Identifier: LGPL-3.0-or-later > > for i in *.gv > do >diff --git a/scripts/dot_to_svg.sh b/scripts/dot_to_svg.sh >index 72d298e..559cc55 100755 >--- a/scripts/dot_to_svg.sh >+++ b/scripts/dot_to_svg.sh >@@ -1,4 +1,5 @@ > #!/bin/bash >+# SPDX-License-Identifier: LGPL-3.0-or-later > > for i in *.gv > do >diff --git a/scripts/make-verbose.sh b/scripts/make-verbose.sh >index 2389279..f9bf4c8 100644 >--- a/scripts/make-verbose.sh >+++ b/scripts/make-verbose.sh >@@ -1 +1,2 @@ >+# SPDX-License-Identifier: LGPL-3.0-or-later > make V=1 >diff --git a/scripts/svg_to_plain_svg.sh b/scripts/svg_to_plain_svg.sh >index 5ebb7a4..7e7d803 100755 >--- a/scripts/svg_to_plain_svg.sh >+++ b/scripts/svg_to_plain_svg.sh >@@ -1,4 +1,5 @@ > #!/bin/bash >+# SPDX-License-Identifier: LGPL-3.0-or-later > > for i in *.svg; > do inkscape "$i" --export-plain-svg="${i//svg/plain.svg}" >diff --git a/scripts/svg_to_png_and_pdf.sh b/scripts/svg_to_png_and_pdf.sh >index b55515b..d9e53d5 100755 >--- a/scripts/svg_to_png_and_pdf.sh >+++ b/scripts/svg_to_png_and_pdf.sh >@@ -1,4 +1,5 @@ > #!/bin/bash >+# SPDX-License-Identifier: LGPL-3.0-or-later > > for i in *.svg; > do inkscape "$i" --export-png="${i//svg/png}" --export-pdf="${i//svg/pdf}" >diff --git a/src/Makefile.am b/src/Makefile.am >index 1153a5f..73e63ce 100644 >--- a/src/Makefile.am >+++ b/src/Makefile.am >@@ -1,3 +1,4 @@ >+## SPDX-License-Identifier: LGPL-3.0-or-later > lib_LTLIBRARIES=libabigail.la > libabigaildir=$(libdir) > >diff --git a/tests/Makefile.am b/tests/Makefile.am >index c2d4d1d..f614f30 100644 >--- a/tests/Makefile.am >+++ b/tests/Makefile.am >@@ -1,3 +1,4 @@ >+## SPDX-License-Identifier: LGPL-3.0-or-later > SUBDIRS = data > > ZIP_ARCHIVE_TESTS = >diff --git a/tests/data/Makefile.am b/tests/data/Makefile.am >index 5da9ef9..38cbfc3 100644 >--- a/tests/data/Makefile.am >+++ b/tests/data/Makefile.am >@@ -1,4 +1,4 @@ >- >+## SPDX-License-Identifier: LGPL-3.0-or-later > EXTRA_DIST = \ > test-read-write/test0.xml \ > test-read-write/test1.xml \ >diff --git a/tests/runtestcanonicalizetypes.sh.in b/tests/runtestcanonicalizetypes.sh.in >index 1df6fe6..34753c2 100644 >--- a/tests/runtestcanonicalizetypes.sh.in >+++ b/tests/runtestcanonicalizetypes.sh.in >@@ -1,4 +1,5 @@ > #!/bin/sh >+# SPDX-License-Identifier: LGPL-3.0-or-later > > # This program launches "abidiff $binary $binary" on multiple > # instances of $binary. The expect result is for the command to show >diff --git a/tests/runtestdefaultsupprs.py.in b/tests/runtestdefaultsupprs.py.in >index 13c3cd5..b8a5714 100644 >--- a/tests/runtestdefaultsupprs.py.in >+++ b/tests/runtestdefaultsupprs.py.in >@@ -1,4 +1,5 @@ > #!/usr/bin/env @PYTHON@ >+# SPDX-License-Identifier: LGPL-3.0-or-later > > '''Runs tests for the default suppression specifications of libabigail. > >diff --git a/tests/runtestdefaultsupprspy3.sh.in b/tests/runtestdefaultsupprspy3.sh.in >index 4985206..5ef5063 100644 >--- a/tests/runtestdefaultsupprspy3.sh.in >+++ b/tests/runtestdefaultsupprspy3.sh.in >@@ -1,2 +1,3 @@ > #!/bin/bash >+# SPDX-License-Identifier: LGPL-3.0-or-later > @PYTHON3_INTERPRETER@ "@abs_top_builddir@/tests/runtestdefaultsupprs.py" >diff --git a/tests/runtestfedabipkgdiffpy3.sh.in b/tests/runtestfedabipkgdiffpy3.sh.in >index 209037c..5a41d50 100644 >--- a/tests/runtestfedabipkgdiffpy3.sh.in >+++ b/tests/runtestfedabipkgdiffpy3.sh.in >@@ -1,4 +1,5 @@ > #!/bin/bash -e >+# SPDX-License-Identifier: LGPL-3.0-or-later > > # Either tests runner script or the tools/fedabipkgdiff has shebang > # `/usr/bin/env python`, as a result, to run tests in Python 3, we have to >diff --git a/tests/update-test-output.py b/tests/update-test-output.py >index 4017dd0..e582fb8 100755 >--- a/tests/update-test-output.py >+++ b/tests/update-test-output.py >@@ -1,4 +1,5 @@ > #!/bin/python >+# SPDX-License-Identifier: LGPL-3.0-or-later > > # This program generates the copy commands you should use to update > # the reference data for tests /tests/runtest* that emit an >diff --git a/tools/Makefile.am b/tools/Makefile.am >index 6f949af..937117d 100644 >--- a/tools/Makefile.am >+++ b/tools/Makefile.am >@@ -1,3 +1,4 @@ >+## SPDX-License-Identifier: LGPL-3.0-or-later > h=$(abs_srcdir) > > if ENABLE_ZIP_ARCHIVE >diff --git a/update-copyright.sh b/update-copyright.sh >index 9192aff..3936cd8 100644 >--- a/update-copyright.sh >+++ b/update-copyright.sh >@@ -1,4 +1,5 @@ > #!/bin/sh >+# SPDX-License-Identifier: LGPL-3.0-or-later > > oldyear=2019 > newyear=2020 >-- >1.8.3.1 > > >-- > Dodji >