From: Jonathan Wakely <jwakely@redhat.com>
To: Dodji Seketeli <dodji@redhat.com>
Cc: Benjamin Kosnik <b.dekosnik@gmail.com>,
Ben Woodard <woodard@redhat.com>, Chenxiong Qi <cqi@redhat.com>,
Giuliano Procida <gprocida@google.com>,
Jan Engelhardt <jengelh@inai.de>, Jessica Yu <jeyu@kernel.org>,
Mark Wielaard <mark@klomp.org>, Matthias Klose <doko@debian.org>,
Matthias Maennich <maennich@google.com>,
Ondrej Oprala <ondrej.oprala@gmail.com>,
Roland McGrath <roland@hack.frob.com>,
Sinny Kumari <skumari@redhat.com>,
Slava Barinov <v.barinov@samsung.com>,
libabigail@sourceware.org
Subject: Re: [PATCH 1/9] Replace individual license references with SPDX Identifiers
Date: Fri, 10 Jul 2020 18:23:46 +0100 [thread overview]
Message-ID: <20200710172346.GS4137376@redhat.com> (raw)
In-Reply-To: <871rljpiqr.fsf@redhat.com>
Some of these changes replace the license header with a different SPDX
identifier, is that intentional?
On 10/07/20 16:06 +0200, Dodji Seketeli wrote:
>diff --git a/tests/runtestfedabipkgdiff.py.in b/tests/runtestfedabipkgdiff.py.in
>index 04429b6..430bd07 100755
>--- a/tests/runtestfedabipkgdiff.py.in
>+++ b/tests/runtestfedabipkgdiff.py.in
>@@ -1,23 +1,8 @@
> #!/usr/bin/env python
>+# SPDX-License-Identifier: LGPL-3.0-or-later
Looks like this should be GPLv3 not LGPLv3.
> # -*- coding: utf-8 -*-
> # -*- Mode: Python
> #
>-# This file is part of the GNU Application Binary Interface Generic
>-# Analysis and Instrumentation Library (libabigail). This library is
>-# free software; you can redistribute it and/or modify it under the
>-# terms of the GNU General Public License as published by the
>-# Free Software Foundation; either version 3, or (at your option) any
>-# later version.
>-#
>-# This library is distributed in the hope that it will be useful, but
>-# WITHOUT ANY WARRANTY; without even the implied warranty of
>-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
>-# General Public License for more details.
>-#
>-# You should have received a copy of the GNU General Public
>-# License along with this program; see the file COPYING-GPLV3. If
>-# not, see <http:#www.gnu.org/licenses/>.
>-#
> # Author: Chenxiong Qi
>
> '''Runs tests for the fedabipkgdiff program
>diff --git a/tests/test-dot.cc b/tests/test-dot.cc
>index fab0c19..3b8ed57 100644
>--- a/tests/test-dot.cc
>+++ b/tests/test-dot.cc
>@@ -1,27 +1,7 @@
>-// Copyright (C) 2013-2019 Red Hat, Inc.
>-//
>-// This file is part of the GNU Application Binary Interface Generic
>-// Analysis and Instrumentation Library (libabigail). This library is
>-// free software; you can redistribute it and/or modify it under the
>-// terms of the GNU General Public License as published by the Free
>-// Software Foundation; either version 3, or (at your option) any
>-// later version.
>-
>-// This library is distributed in the hope that it will be useful, but
>-// WITHOUT ANY WARRANTY; without even the implied warranty of
>-// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
>-// General Public License for more details.
>-
>-// Under Section 7 of GPL version 3, you are granted additional
>-// permissions described in the GCC Runtime Library Exception, version
>-// 3.1, as published by the Free Software Foundation.
>-
>-// You should have received a copy of the GNU General Public License
>-// and a copy of the GCC Runtime Library Exception along with this
>-// program; see the files COPYING3 and COPYING.RUNTIME respectively.
>-// If not, see <http://www.gnu.org/licenses/>.
>-
>+// SPDX-License-Identifier: LGPL-3.0-or-later
And this should be GPLv3 with GCC exception.
> // -*- mode: C++ -*-
>+//
>+// Copyright (C) 2013-2019 Red Hat, Inc.
>
> #include "abg-viz-dot.h"
>
>diff --git a/tests/test-svg.cc b/tests/test-svg.cc
>index 4a9d44d..10d98e6 100644
>--- a/tests/test-svg.cc
>+++ b/tests/test-svg.cc
>@@ -1,27 +1,7 @@
>-// Copyright (C) 2013-2019 Red Hat, Inc.
>-//
>-// This file is part of the GNU Application Binary Interface Generic
>-// Analysis and Instrumentation Library (libabigail). This library is
>-// free software; you can redistribute it and/or modify it under the
>-// terms of the GNU General Public License as published by the Free
>-// Software Foundation; either version 3, or (at your option) any
>-// later version.
>-
>-// This library is distributed in the hope that it will be useful, but
>-// WITHOUT ANY WARRANTY; without even the implied warranty of
>-// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
>-// General Public License for more details.
>-
>-// Under Section 7 of GPL version 3, you are granted additional
>-// permissions described in the GCC Runtime Library Exception, version
>-// 3.1, as published by the Free Software Foundation.
>-
>-// You should have received a copy of the GNU General Public License
>-// and a copy of the GCC Runtime Library Exception along with this
>-// program; see the files COPYING3 and COPYING.RUNTIME respectively.
>-// If not, see <http://www.gnu.org/licenses/>.
>-
>+// SPDX-License-Identifier: LGPL-3.0-or-later
And this should be GPLv3 with GCC exception too.
> // -*- mode: C++ -*-
>+//
>+// Copyright (C) 2013-2019 Red Hat, Inc.
>
> #include "abg-viz-svg.h"
>
>diff --git a/tools/fedabipkgdiff b/tools/fedabipkgdiff
>index 2191613..60a9f3e 100755
>--- a/tools/fedabipkgdiff
>+++ b/tools/fedabipkgdiff
>@@ -1,25 +1,10 @@
> #!/usr/bin/env python
>+# SPDX-License-Identifier: LGPL-3.0-or-later
> # -*- coding: utf-8 -*-
> # -*- Mode: Python
> #
> # Copyright (C) 2013-2016 Red Hat, Inc.
> #
>-# This file is part of the GNU Application Binary Interface Generic
>-# Analysis and Instrumentation Library (libabigail). This library is
>-# free software; you can redistribute it and/or modify it under the
>-# terms of the GNU General Public License as published by the
>-# Free Software Foundation; either version 3, or (at your option) any
>-# later version.
And this one should be GPLv3.
>-#
>-# This library is distributed in the hope that it will be useful, but
>-# WITHOUT ANY WARRANTY; without even the implied warranty of
>-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
>-# General Public License for more details.
>-#
>-# You should have received a copy of the GNU General Public
>-# License along with this program; see the file COPYING-GPLV3. If
>-# not, see <http:#www.gnu.org/licenses/>.
>-#
> # Author: Chenxiong Qi
>
> from __future__ import print_function
next prev parent reply other threads:[~2020-07-10 17:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-10 14:06 Dodji Seketeli
2020-07-10 17:23 ` Jonathan Wakely [this message]
2020-07-13 11:13 ` Dodji Seketeli
2020-07-13 15:24 ` Giuliano Procida
2020-07-15 14:04 ` Dodji Seketeli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200710172346.GS4137376@redhat.com \
--to=jwakely@redhat.com \
--cc=b.dekosnik@gmail.com \
--cc=cqi@redhat.com \
--cc=dodji@redhat.com \
--cc=doko@debian.org \
--cc=gprocida@google.com \
--cc=jengelh@inai.de \
--cc=jeyu@kernel.org \
--cc=libabigail@sourceware.org \
--cc=maennich@google.com \
--cc=mark@klomp.org \
--cc=ondrej.oprala@gmail.com \
--cc=roland@hack.frob.com \
--cc=skumari@redhat.com \
--cc=v.barinov@samsung.com \
--cc=woodard@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).