From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.61]) by sourceware.org (Postfix) with ESMTP id AE5F33842400 for ; Fri, 10 Jul 2020 17:23:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org AE5F33842400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-132-Q4AaVwx0OiG3rjetTiKX5A-1; Fri, 10 Jul 2020 13:23:54 -0400 X-MC-Unique: Q4AaVwx0OiG3rjetTiKX5A-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 8F0121800D42; Fri, 10 Jul 2020 17:23:51 +0000 (UTC) Received: from localhost (unknown [10.33.36.71]) by smtp.corp.redhat.com (Postfix) with ESMTP id AFE966FEF8; Fri, 10 Jul 2020 17:23:47 +0000 (UTC) Date: Fri, 10 Jul 2020 18:23:46 +0100 From: Jonathan Wakely To: Dodji Seketeli Cc: Benjamin Kosnik , Ben Woodard , Chenxiong Qi , Giuliano Procida , Jan Engelhardt , Jessica Yu , Mark Wielaard , Matthias Klose , Matthias Maennich , Ondrej Oprala , Roland McGrath , Sinny Kumari , Slava Barinov , libabigail@sourceware.org Subject: Re: [PATCH 1/9] Replace individual license references with SPDX Identifiers Message-ID: <20200710172346.GS4137376@redhat.com> References: <871rljpiqr.fsf@redhat.com> MIME-Version: 1.0 In-Reply-To: <871rljpiqr.fsf@redhat.com> X-Clacks-Overhead: GNU Terry Pratchett X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline X-Spam-Status: No, score=-15.2 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Jul 2020 17:23:59 -0000 Some of these changes replace the license header with a different SPDX identifier, is that intentional? On 10/07/20 16:06 +0200, Dodji Seketeli wrote: >diff --git a/tests/runtestfedabipkgdiff.py.in b/tests/runtestfedabipkgdiff.py.in >index 04429b6..430bd07 100755 >--- a/tests/runtestfedabipkgdiff.py.in >+++ b/tests/runtestfedabipkgdiff.py.in >@@ -1,23 +1,8 @@ > #!/usr/bin/env python >+# SPDX-License-Identifier: LGPL-3.0-or-later Looks like this should be GPLv3 not LGPLv3. > # -*- coding: utf-8 -*- > # -*- Mode: Python > # >-# This file is part of the GNU Application Binary Interface Generic >-# Analysis and Instrumentation Library (libabigail). This library is >-# free software; you can redistribute it and/or modify it under the >-# terms of the GNU General Public License as published by the >-# Free Software Foundation; either version 3, or (at your option) any >-# later version. >-# >-# This library is distributed in the hope that it will be useful, but >-# WITHOUT ANY WARRANTY; without even the implied warranty of >-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU >-# General Public License for more details. >-# >-# You should have received a copy of the GNU General Public >-# License along with this program; see the file COPYING-GPLV3. If >-# not, see . >-# > # Author: Chenxiong Qi > > '''Runs tests for the fedabipkgdiff program >diff --git a/tests/test-dot.cc b/tests/test-dot.cc >index fab0c19..3b8ed57 100644 >--- a/tests/test-dot.cc >+++ b/tests/test-dot.cc >@@ -1,27 +1,7 @@ >-// Copyright (C) 2013-2019 Red Hat, Inc. >-// >-// This file is part of the GNU Application Binary Interface Generic >-// Analysis and Instrumentation Library (libabigail). This library is >-// free software; you can redistribute it and/or modify it under the >-// terms of the GNU General Public License as published by the Free >-// Software Foundation; either version 3, or (at your option) any >-// later version. >- >-// This library is distributed in the hope that it will be useful, but >-// WITHOUT ANY WARRANTY; without even the implied warranty of >-// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU >-// General Public License for more details. >- >-// Under Section 7 of GPL version 3, you are granted additional >-// permissions described in the GCC Runtime Library Exception, version >-// 3.1, as published by the Free Software Foundation. >- >-// You should have received a copy of the GNU General Public License >-// and a copy of the GCC Runtime Library Exception along with this >-// program; see the files COPYING3 and COPYING.RUNTIME respectively. >-// If not, see . >- >+// SPDX-License-Identifier: LGPL-3.0-or-later And this should be GPLv3 with GCC exception. > // -*- mode: C++ -*- >+// >+// Copyright (C) 2013-2019 Red Hat, Inc. > > #include "abg-viz-dot.h" > >diff --git a/tests/test-svg.cc b/tests/test-svg.cc >index 4a9d44d..10d98e6 100644 >--- a/tests/test-svg.cc >+++ b/tests/test-svg.cc >@@ -1,27 +1,7 @@ >-// Copyright (C) 2013-2019 Red Hat, Inc. >-// >-// This file is part of the GNU Application Binary Interface Generic >-// Analysis and Instrumentation Library (libabigail). This library is >-// free software; you can redistribute it and/or modify it under the >-// terms of the GNU General Public License as published by the Free >-// Software Foundation; either version 3, or (at your option) any >-// later version. >- >-// This library is distributed in the hope that it will be useful, but >-// WITHOUT ANY WARRANTY; without even the implied warranty of >-// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU >-// General Public License for more details. >- >-// Under Section 7 of GPL version 3, you are granted additional >-// permissions described in the GCC Runtime Library Exception, version >-// 3.1, as published by the Free Software Foundation. >- >-// You should have received a copy of the GNU General Public License >-// and a copy of the GCC Runtime Library Exception along with this >-// program; see the files COPYING3 and COPYING.RUNTIME respectively. >-// If not, see . >- >+// SPDX-License-Identifier: LGPL-3.0-or-later And this should be GPLv3 with GCC exception too. > // -*- mode: C++ -*- >+// >+// Copyright (C) 2013-2019 Red Hat, Inc. > > #include "abg-viz-svg.h" > >diff --git a/tools/fedabipkgdiff b/tools/fedabipkgdiff >index 2191613..60a9f3e 100755 >--- a/tools/fedabipkgdiff >+++ b/tools/fedabipkgdiff >@@ -1,25 +1,10 @@ > #!/usr/bin/env python >+# SPDX-License-Identifier: LGPL-3.0-or-later > # -*- coding: utf-8 -*- > # -*- Mode: Python > # > # Copyright (C) 2013-2016 Red Hat, Inc. > # >-# This file is part of the GNU Application Binary Interface Generic >-# Analysis and Instrumentation Library (libabigail). This library is >-# free software; you can redistribute it and/or modify it under the >-# terms of the GNU General Public License as published by the >-# Free Software Foundation; either version 3, or (at your option) any >-# later version. And this one should be GPLv3. >-# >-# This library is distributed in the hope that it will be useful, but >-# WITHOUT ANY WARRANTY; without even the implied warranty of >-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU >-# General Public License for more details. >-# >-# You should have received a copy of the GNU General Public >-# License along with this program; see the file COPYING-GPLV3. If >-# not, see . >-# > # Author: Chenxiong Qi > > from __future__ import print_function