From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <3_R0YXwgKCpg8HJG4A528GG8D6.4GEDA323A82ADKGMJ46O2J6.GJ8@flex--gprocida.bounces.google.com> Received: from mail-wm1-x349.google.com (mail-wm1-x349.google.com [IPv6:2a00:1450:4864:20::349]) by sourceware.org (Postfix) with ESMTPS id 896C5387084E for ; Wed, 22 Jul 2020 11:07:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 896C5387084E Received: by mail-wm1-x349.google.com with SMTP id g138so923373wme.7 for ; Wed, 22 Jul 2020 04:07:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:message-id:mime-version:subject:from:to:cc; bh=k2qmUwEvepuA7GiYu7VfQyjQdO2NtJFzH88LVNOhCLY=; b=fs+XMgB7gNKgIoYkFMzDBBa/WVBaHXWli+loCt4YuV9JrePZj5SihSRKeU9smdBtP9 aPBhnZUGZDZSCQ1qyGMMn3u9Jc/llFx+vhhGPVcJb/heqVXd4DBijSGmwTNNz1NzZEj7 QubKPOf2PAVmkQshWAl3py9UHpdl0NUVYBbuCo9ncloug+pW1VdceCmKYrwuCBzlCW6Z gGKbYdEcfq7WdKBnXyDfaVD+rHr5T1ow8pyxaC7OIF5w0ufg7j8igota6A83AH5zqOnZ lgwkW84HxPG3wIJu6pDp5ZsKlrzDW6uqwP3pFicDHPK+qXPxMHNSdUxCqImNMWiP+IMl 0V2A== X-Gm-Message-State: AOAM532faaqMTPIkYJsJcBERxXdGdpmjx466HceENTGbYoa4+fB4njfZ dA7hE8qWhYVbSrvLkSgR8L3N72uQQ3LgyFuxVnEcNh9WlMp19i5L4srQ8au5tvqGCvkfKVGfc5N Cp+zXHf8kkOmmou99kRTlNylddtokZlDdxXmE/ThFZxOH+jEtJnjti303kkMqR+moZbbd7gw= X-Google-Smtp-Source: ABdhPJxtOg20pyesl7SEEsDsP98wgw9nrohh6v0c/XWhFctEOOXMIiDGqi+sUgP+V+odpAcaSbQzQFIncd6LFg== X-Received: by 2002:a5d:4e8c:: with SMTP id e12mr7677080wru.19.1595416061438; Wed, 22 Jul 2020 04:07:41 -0700 (PDT) Date: Wed, 22 Jul 2020 12:07:35 +0100 Message-Id: <20200722110736.2550361-1-gprocida@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.28.0.rc0.105.gf9edc3c819-goog Subject: [RFC PATCH 0/1] Fix decl_base comparison From: Giuliano Procida To: libabigail@sourceware.org Cc: dodji@seketeli.org, kernel-team@android.com, gprocida@google.com, maennich@google.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-18.1 required=5.0 tests=BAYES_00, DKIMWL_WL_MED, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Jul 2020 11:07:43 -0000 Hi reviewers. This commit fixes the slow path decl_base comparison, with the assumption that decl_names_equal has been fixed as per another commit, "Make decl_names_equal more accurate". This is an RFC patch because there may be more to address here. I've added some TODOs and referred to them in the commit message for the patch. I'm hoping for review comments particularly directed at those TODOs. To be clear, disabling the fast path in the decl_base comparison changes behaviour, suggesting that the fast path is buggy as well. Regards, Giuliano. Giuliano Procida (1): Fix decl_base comparison function src/abg-ir.cc | 25 +- .../PR25058-liblttng-ctl-report-1.txt | 4 - .../data/test-diff-filter/test33-report-0.txt | 3 - ....el7.x86_64-multiple-sym-vers-report-0.txt | 2 +- ...l7.x86_64-0.12.8-1.el7.x86_64-report-2.txt | 2 +- .../test9-pr18818-clang.so.abi | 236 ++++++++---------- 6 files changed, 127 insertions(+), 145 deletions(-) -- 2.28.0.rc0.105.gf9edc3c819-goog