From: Giuliano Procida <gprocida@google.com>
To: libabigail@sourceware.org
Cc: dodji@seketeli.org, kernel-team@android.com, gprocida@google.com,
maennich@google.com
Subject: [PATCH 0/3] clang-tidy error and warning fixes
Date: Thu, 3 Sep 2020 14:22:02 +0100 [thread overview]
Message-ID: <20200903132205.589136-1-gprocida@google.com> (raw)
Hi Dodji.
We (also) build libabigail using Google's internal tooling and one
thing we get for free is clang-tidy's report on the code. The internal
branch of libabigail is essentially a subset of mm-next, so the
figures below may not be accurate for master.
The current counts (for */*.{h,cc}) are:
2 clang-diagnostic-error
2 readability-redundant-smartptr-get
14 performance-unnecessary-copy-initialization
21 readability-container-size-empty
49 bugprone-argument-comment
50 misc-unused-using-decls
54 clang-diagnostic-shadow-field
66 readability-inconsistent-declaration-parameter-name
The commits in this series address the first 3 categories above.
I'm proceeding on the assumption that there is value in reducing the
counts to zero. However, it's possible that certain categories may not
be aligned with an idealised libabigail coding standard. Do let us
know. Thank you!
Regards,
Giuliano.
Giuliano Procida (3):
abg-corpus-priv.h: include abg-corpus.h
Fix readability-redundant-smartptr-get warnings
Fix performance-unnecessary-copy-initialization warnings
include/abg-diff-utils.h | 2 +-
src/abg-comparison-priv.h | 3 ++-
src/abg-corpus-priv.h | 1 +
src/abg-default-reporter.cc | 4 ++--
src/abg-dwarf-reader.cc | 2 +-
src/abg-ir.cc | 11 ++++++-----
src/abg-suppression.cc | 8 ++++----
tools/abipkgdiff.cc | 2 +-
tools/kmidiff.cc | 4 ++--
9 files changed, 20 insertions(+), 17 deletions(-)
--
2.28.0.402.g5ffc5be6b7-goog
next reply other threads:[~2020-09-03 13:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-03 13:22 Giuliano Procida [this message]
2020-09-03 13:22 ` [PATCH 1/3] abg-corpus-priv.h: include abg-corpus.h Giuliano Procida
2020-09-03 13:22 ` [PATCH 2/3] Fix readability-redundant-smartptr-get warnings Giuliano Procida
2020-09-03 13:22 ` [PATCH 3/3] Fix performance-unnecessary-copy-initialization warnings Giuliano Procida
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200903132205.589136-1-gprocida@google.com \
--to=gprocida@google.com \
--cc=dodji@seketeli.org \
--cc=kernel-team@android.com \
--cc=libabigail@sourceware.org \
--cc=maennich@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).