From: Jonathan Wakely <jwakely@redhat.com>
To: Dodji Seketeli <dodji@redhat.com>
Cc: Benjamin Kosnik <b.dekosnik@gmail.com>,
Ben Woodard <woodard@redhat.com>, Chenxiong Qi <cqi@redhat.com>,
Giuliano Procida <gprocida@google.com>,
Jan Engelhardt <jengelh@inai.de>, Jessica Yu <jeyu@kernel.org>,
Mark Wielaard <mark@klomp.org>, Matthias Klose <doko@debian.org>,
Matthias Maennich <maennich@google.com>,
Ondrej Oprala <ondrej.oprala@gmail.com>,
Roland McGrath <roland@hack.frob.com>,
Sinny Kumari <skumari@redhat.com>,
Slava Barinov <v.barinov@samsung.com>,
libabigail@sourceware.org
Subject: Re: [PATCH 1/9 v2] Replace individual license references with SPDX Identifiers
Date: Thu, 24 Sep 2020 11:09:40 +0100 [thread overview]
Message-ID: <20200924100940.GB6061@redhat.com> (raw)
In-Reply-To: <87pn8wlsoq.fsf@redhat.com>
One remaining issue in v2 of this patch, and two requests for a better
commit message. See below.
On 15/07/20 17:11 +0200, Dodji Seketeli wrote:
>This patch replaces license headers with SPDX identifiers in all files
>containing license headers. For each file, the SPDX identifier
>formally represents its current license. Note that the list of SPDX
>identifiers is available on the SPDX web site at
>https://spdx.org/licenses.
>
>For autoconf-archive/ax_prog_python_version.m4 however, there is a
>little catch. Dodji Seketeli wrote this ax_check_python_modules.m4.
>Just like the other autoconf-archive macros, it makes sense to have it
>under the FSF All Permissive license. Actually, the terms of that
>license was already in the file but then the license header was
>wrongly set to GPLv2 with autoconf exception. So I fixed that in this
>commit by setting the SPDX identifier to FSFAP.
>
> * abigail.m4: Replace the license header with the SPDX identifier
> GPL-3.0-or-later WITH GCC-exception-3.1
> * autoconf-archive/ax_check_python_modules.m4: Correctly set the
> SPDX identifier to FSFAP.
> * autoconf-archive/ax_compare_version.m4: Replace the license
> header with the SPDX identifier FSFAP.
> * autoconf-archive/ax_prog_python_version.m4: Likewise.
> header with the SPDX identifier FSFAP.
> * autoconf-archive/ax_valgrind_check.m4: Likewise.
> * gen-changelog.py: Replace the license header with the SPDX
> identifier LGPL-2.0-or-later.
> * include/abg-comp-filter.h: Replace the license header with the
> SPDX identifier LGPL-3.0-or-later.
> * include/abg-comparison.h: Likewise.
> * include/abg-config.h: Likewise.
> * include/abg-corpus.h: Likewise.
> * include/abg-cxx-compat.h: Replace the license header with the
> SPDX identifier LGPL-2.0-or-later.
> * include/abg-diff-utils.h: Replace the license header with the
> SPDX identifier LGPL-3.0-or-later
> * include/abg-dwarf-reader.h: Likewise.
> * include/abg-fwd.h: Likewise.
> * include/abg-hash.h: Likewise.
> * include/abg-ini.h: Likewise.
> * include/abg-interned-str.h: Likewise.
> * include/abg-ir.h: Likewise.
> * include/abg-libxml-utils.h: Likewise.
> * include/abg-libzip-utils.h: Likewise.
> * include/abg-reader.h: Likewise.
> * include/abg-regex.h: Likewise.
> * include/abg-reporter.h: Likewise.
> * include/abg-sptr-utils.h: Likewise.
> * include/abg-suppression.h: Likewise.
> * include/abg-tools-utils.h: Likewise.
> * include/abg-traverse.h: Likewise.
> * include/abg-viz-common.h: Likewise.
> * include/abg-viz-dot.h: Likewise.
> * include/abg-viz-svg.h: Likewise.
> * include/abg-workers.h: Likewise.
> * include/abg-writer.h: Likewise.
> * install-sh: Replace the license header with the SPDX identifier MIT.
> * ltmain.sh: Replace the license header with the SPDX identifier
> GPL-2.0-or-later.
It would be helpful if the commit log mentioned that this change to
ltmain.sh drops the (redundant?) libtool exception. I know you already
explained why that's OK, but I just noticed it again myself and asked
you about it on IRC. If the commit log mentioned it, I wouldn't need
to wonder if it's an error.
> * src/abg-comp-filter.cc: Replace the license header with the SPDX
> identifier LGPL-3.0-or-later.
> * src/abg-comparison-priv.h: Likewise.
> * src/abg-comparison.cc: Likewise.
> * src/abg-config.cc: Likewise.
> * src/abg-corpus-priv.h: Likewise.
> * src/abg-corpus.cc: Likewise.
> * src/abg-default-reporter.cc: Likewise.
> * src/abg-diff-utils.cc: Likewise.
> * src/abg-dwarf-reader.cc: Likewise.
> * src/abg-elf-helpers.cc: Likewise.
> * src/abg-elf-helpers.h: Likewise.
> * src/abg-regex.cc: Likewise.
> * src/abg-hash.cc: Likewise.
> * src/abg-ini.cc: Likewise.
> * src/abg-internal.h: Likewise.
> * src/abg-ir-priv.h: Likewise.
> * src/abg-ir.cc: Likewise.
> * src/abg-leaf-reporter.cc: Likewise.
> * src/abg-libxml-utils.cc: Likewise.
> * src/abg-libzip-utils.cc: Likewise.
> * src/abg-reader.cc: Likewise.
> * src/abg-reporter-priv.cc: Likewise.
> * src/abg-reporter-priv.h: Likewise.
> * src/abg-sptr-utils.cc: Likewise.
> * src/abg-suppression-priv.h: Likewise.
> * src/abg-suppression.cc: Likewise.
> * src/abg-tools-utils.cc: Likewise.
> * src/abg-traverse.cc: Likewise.
> * src/abg-viz-common.cc: Likewise.
> * src/abg-viz-dot.cc: Likewise.
> * src/abg-viz-svg.cc: Likewise.
> * src/abg-workers.cc: Likewise.
> * src/abg-writer.cc: Likewise.
> * tests/lib/catch.cc: Likewise.
> * tests/lib/catch.hpp: Replace the license header with the SPDX
> identifier BSL-1.0.
The changelog says "Replace" but actually it's just adding it. Nothing
gets replaced.
> * tests/mockfedabipkgdiff.in: Replace the license header with the
> SPDX identifier LGPL-3.0-or-later.
This change looks wrong:
>diff --git a/tests/mockfedabipkgdiff.in b/tests/mockfedabipkgdiff.in
>index 47c8cc8..ea8efc1 100644
>--- a/tests/mockfedabipkgdiff.in
>+++ b/tests/mockfedabipkgdiff.in
>@@ -1,23 +1,8 @@
> #!/usr/bin/env python
>+# SPDX-License-Identifier: LGPL-3.0-or-later
> # -*- coding: utf-8 -*-
> # -*- Mode: Python
> #
>-# This file is part of the GNU Application Binary Interface Generic
>-# Analysis and Instrumentation Library (libabigail). This library is
>-# free software; you can redistribute it and/or modify it under the
>-# terms of the GNU General Public License as published by the
>-# Free Software Foundation; either version 3, or (at your option) any
>-# later version.
>-#
>-# This library is distributed in the hope that it will be useful, but
>-# WITHOUT ANY WARRANTY; without even the implied warranty of
>-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
>-# General Public License for more details.
>-#
>-# You should have received a copy of the GNU General Public
>-# License along with this program; see the file COPYING-GPLV3. If
>-# not, see <http:#www.gnu.org/licenses/>.
>-#
> # Author: Dodji Seketeli
> #
> # Based on some preliminary work from Chenxiong Qi, posted to
next prev parent reply other threads:[~2020-09-24 10:09 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-15 15:02 [PATCH 0/9 v2] Relicensing Libabigail to Apache 2.0 + LLVM Exception Dodji Seketeli
2020-07-15 15:11 ` [PATCH 1/9 v2] Replace individual license references with SPDX Identifiers Dodji Seketeli
2020-09-24 10:09 ` Jonathan Wakely [this message]
2020-09-24 10:14 ` Jonathan Wakely
2020-09-25 8:38 ` Dodji Seketeli
2020-09-25 10:06 ` Jonathan Wakely
2020-09-25 12:30 ` Dodji Seketeli
2020-07-15 15:11 ` [PATCH 2/9 v2] Add missing SPDX headers to source files not specifying any license Dodji Seketeli
2020-07-15 15:13 ` [PATCH 3/9 v2] Add has-spdx-header.sh script Dodji Seketeli
2020-07-16 10:26 ` Jonathan Wakely
2020-07-16 16:20 ` Dodji Seketeli
2020-07-15 15:13 ` [PATCH 4/9 v2] Add replace-spdx-license.sh script Dodji Seketeli
2020-07-16 10:27 ` Jonathan Wakely
2020-07-16 16:20 ` Dodji Seketeli
[not found] ` <CAGvU0Hnxmptf3irjhOV1SJcfXfQtas8+ttj3kvFyCWzCBFETPw@mail.gmail.com>
2020-09-03 14:47 ` Dodji Seketeli
2020-07-15 15:14 ` [PATCH 5/9 v2] Add helper files to perform the re-licensing Dodji Seketeli
[not found] ` <20200716103259.GZ4137376@redhat.com>
[not found] ` <874kq7jup5.fsf@redhat.com>
2020-09-24 10:12 ` Jonathan Wakely
2020-07-15 15:15 ` [PATCH 6/9 v2] Re-license the project to Apache v2 With LLVM Exception Dodji Seketeli
2020-07-16 10:33 ` Jonathan Wakely
2020-07-16 16:23 ` Dodji Seketeli
2020-07-15 15:16 ` [PATCH 7/9 v2] Add the LICENSE.txt file Dodji Seketeli
2020-07-15 15:17 ` [PATCH 8/9 v2] Delete COPYING* files Dodji Seketeli
2020-07-16 10:34 ` Jonathan Wakely
2020-07-16 16:23 ` Dodji Seketeli
2020-07-15 15:17 ` [PATCH 9/9 v2] Add a license-change-2020.txt file Dodji Seketeli
2020-07-16 10:35 ` Jonathan Wakely
2020-07-16 16:23 ` Dodji Seketeli
2020-07-16 16:01 ` [PATCH 0/9 v2] Relicensing Libabigail to Apache 2.0 + LLVM Exception Jessica Yu
2020-07-17 11:43 ` Dodji Seketeli
[not found] <CGME20200903075248eucas1p2dcc11b3b1b24390a5da8bdc676bfd6b3@eucas1p2.samsung.com>
[not found] ` <878sdruwk7.fsf@redhat.com>
2020-09-03 8:18 ` Please signoff libabigail relicensing. Was "[PATCH 0/9 v2] Relicensing Libabigail to Apache 2.0 + LLVM Exception" Vyacheslav Barinov
2020-09-03 14:40 ` Dodji Seketeli
2020-09-03 9:48 ` [PATCH 0/9 v2] Relicensing Libabigail to Apache 2.0 + LLVM Exception Jan Engelhardt
2020-09-03 14:39 ` Dodji Seketeli
[not found] ` <CAJxw1w=7C_MhOQ5E6dns9-7yD4qOcsBG52BtupCu3nv-L82Jiw@mail.gmail.com>
2020-09-03 14:39 ` Please signoff libabigail relicensing. Was "[PATCH 0/9 v2] Relicensing Libabigail to Apache 2.0 + LLVM Exception" Dodji Seketeli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200924100940.GB6061@redhat.com \
--to=jwakely@redhat.com \
--cc=b.dekosnik@gmail.com \
--cc=cqi@redhat.com \
--cc=dodji@redhat.com \
--cc=doko@debian.org \
--cc=gprocida@google.com \
--cc=jengelh@inai.de \
--cc=jeyu@kernel.org \
--cc=libabigail@sourceware.org \
--cc=maennich@google.com \
--cc=mark@klomp.org \
--cc=ondrej.oprala@gmail.com \
--cc=roland@hack.frob.com \
--cc=skumari@redhat.com \
--cc=v.barinov@samsung.com \
--cc=woodard@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).