From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <30FcRYAgKCssx685tzurx55x2v.t532zsrszxrz295B8tvDr8v.58x@flex--gprocida.bounces.google.com> Received: from mail-ej1-x649.google.com (mail-ej1-x649.google.com [IPv6:2a00:1450:4864:20::649]) by sourceware.org (Postfix) with ESMTPS id 938D1395A008 for ; Wed, 27 Jan 2021 12:08:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 938D1395A008 Received: by mail-ej1-x649.google.com with SMTP id n18so562920ejc.11 for ; Wed, 27 Jan 2021 04:08:49 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:message-id:mime-version:subject:from :to:cc; bh=A2BXcNGiUe9HW17C/UbpyBBR4pzAKcdNfJeftmQ2u58=; b=tjDgc+45h6BXJfYyUrys4YNK2rnTn8Im6519ZOvU42ULtClHCbp5KlxeqBkt3afjJi VOhUvgm/2AI5YqTcFvojQJAZs5v+PzEM1Uh3OwaiuqW5/SgUySFgvXs22bOMmMftoymZ p3EockIABCjjJS7/2UbqW5NOJevHJdN95Y9iFVwN1rFnId5srqdpdjGo18Y2GUMk9Clx 7hUt3svGgpQjgEOGxVfy/4OJNGYUF6iHlWD9fIylCTKBEUmNy+TAQBZgQhi/n2aTg3ft I6k6KXv4HOkPOqiqeQQOAg5sT8ILU7degPzz2bQTF6IQaSzjclw03raYc7m9fZVimGBz EvNA== X-Gm-Message-State: AOAM531XkCNxHMuKq/HmssDG7bysd12KDUHkUusf0pmYU3Thj83xAXkf /Rw/JHSeLzLyitoGWCNwcwd+YrnVOwreq1BET/r2yxd1cH5WRdakVmkL4zAL999Mqes4Jpgglcx bicwR1O2Io6vWDRisvXsMmyrhRL6g3TSs/4ojH/PaP5x65bV+J579npnPiBxgtsjsqzI+R4I= X-Google-Smtp-Source: ABdhPJwtgctDU3vzQ2FSwpfFzqDhcY2GHUJ6GSnpeKlUoINg0yA8wMkaEAPT0MyRiTNfUGBrp5vrOqqOZWqoBw== Sender: "gprocida via sendgmr" X-Received: from tef.lon.corp.google.com ([2a00:79e0:d:110:a6ae:11ff:fe11:4f04]) (user=gprocida job=sendgmr) by 2002:aa7:dd49:: with SMTP id o9mr8613989edw.14.1611749328493; Wed, 27 Jan 2021 04:08:48 -0800 (PST) Date: Wed, 27 Jan 2021 12:08:42 +0000 Message-Id: <20210127120843.2756433-1-gprocida@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.30.0.280.ga3ce27912f-goog Subject: [PATCH 0/1] do not qualify names in diff report From: Giuliano Procida To: libabigail@sourceware.org Cc: dodji@seketeli.org, kernel-team@android.com, gprocida@google.com, maennich@google.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-15.7 required=5.0 tests=BAYES_00, DKIMWL_WL_MED, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Jan 2021 12:08:51 -0000 Hi. This is a small change with a big impact on diffs. Our (Linux kernel, C) users reported that the name qualifications were not adding anything useful to the diff reports and the extra verbosity was impacting readability. Matthias opened Bug 26012. While we could strip out the qualification in post-processing, I think this change may be useful to others but it does need some independent scrutiny. Regards. Giuliano Procida (1): abidiff: do not qualify member names in diff report src/abg-reporter-priv.cc | 11 +- .../test0-fn-changed-report-0.txt | 6 +- .../test0-fn-changed-report-2.txt | 6 +- .../test5-fn-changed-report-0.txt | 4 +- .../test5-fn-changed-report-1.txt | 4 +- .../test6-var-changed-report-0.txt | 4 +- .../test6-var-changed-report-1.txt | 4 +- .../test7-fn-changed-report-0.txt | 2 +- .../test7-fn-changed-report-1.txt | 2 +- .../test7-fn-changed-report-2.txt | 2 +- .../test8-fn-changed-report-0.txt | 2 +- .../test9-fn-changed-report-0.txt | 2 +- .../qualifier-typedef-array-report-1.txt | 24 +- .../test-fun-param-report.txt | 2 +- .../test-headers-dir-report-2.txt | 2 +- .../test-leaf-cxx-members-report.txt | 4 +- .../test-leaf-peeling-report.txt | 2 +- .../test-leaf-redundant-report.txt | 2 +- .../test-member-size-report0.txt | 8 +- .../test-member-size-report1.txt | 6 +- .../test-net-change-report0.txt | 2 +- .../test-abidiff/test-PR18791-report0.txt | 28 +- .../test-abidiff/test-qual-type0-report.txt | 2 +- .../data/test-abidiff/test-struct0-report.txt | 4 +- .../data/test-abidiff/test-struct1-report.txt | 8 +- .../PR25058-liblttng-ctl-report-1.txt | 52 +- tests/data/test-diff-dwarf/test0-report.txt | 4 +- tests/data/test-diff-dwarf/test1-report.txt | 4 +- tests/data/test-diff-dwarf/test10-report.txt | 4 +- tests/data/test-diff-dwarf/test11-report.txt | 4 +- tests/data/test-diff-dwarf/test13-report.txt | 6 +- .../test21-redundant-fn-report-0.txt | 2 +- .../test27-local-base-diff-report.txt | 4 +- tests/data/test-diff-dwarf/test3-report.txt | 2 +- .../test32-fnptr-changes-report-0.txt | 6 +- .../test33-fnref-changes-report-0.txt | 6 +- .../test36-ppc64-aliases-report-0.txt | 2 +- .../test-diff-dwarf/test37-union-report-0.txt | 2 +- .../test-diff-dwarf/test38-union-report-0.txt | 2 +- .../test-diff-dwarf/test39-union-report-0.txt | 4 +- tests/data/test-diff-dwarf/test4-report.txt | 2 +- .../data/test-diff-dwarf/test40-report-0.txt | 14 +- .../test44-anon-struct-union-report-0.txt | 2 +- .../test45-anon-dm-change-report-0.txt | 6 +- .../test-diff-dwarf/test46-rust-report-0.txt | 2 +- tests/data/test-diff-dwarf/test5-report.txt | 2 +- tests/data/test-diff-dwarf/test8-report.txt | 4 +- .../libtest45-basic-type-change-report-0.txt | 6 +- .../test-PR26739-2-report-0.txt | 2 +- tests/data/test-diff-filter/test0-report.txt | 6 +- tests/data/test-diff-filter/test01-report.txt | 6 +- tests/data/test-diff-filter/test1-report.txt | 4 +- tests/data/test-diff-filter/test10-report.txt | 2 +- tests/data/test-diff-filter/test11-report.txt | 2 +- tests/data/test-diff-filter/test13-report.txt | 2 +- .../data/test-diff-filter/test14-0-report.txt | 2 +- .../data/test-diff-filter/test14-1-report.txt | 2 +- .../data/test-diff-filter/test15-0-report.txt | 2 +- .../data/test-diff-filter/test15-1-report.txt | 2 +- .../data/test-diff-filter/test16-report-2.txt | 4 +- tests/data/test-diff-filter/test16-report.txt | 4 +- .../data/test-diff-filter/test17-0-report.txt | 4 +- .../data/test-diff-filter/test17-1-report.txt | 4 +- tests/data/test-diff-filter/test18-report.txt | 2 +- tests/data/test-diff-filter/test2-report.txt | 8 +- .../test25-cyclic-type-report-0.txt | 2 +- .../test25-cyclic-type-report-1.txt | 4 +- ...st26-qualified-redundant-node-report-0.txt | 4 +- ...st26-qualified-redundant-node-report-1.txt | 6 +- ...t-and-filtered-children-nodes-report-0.txt | 2 +- ...t-and-filtered-children-nodes-report-1.txt | 4 +- ...t-and-filtered-children-nodes-report-2.txt | 8 +- ...t-and-filtered-children-nodes-report-0.txt | 2 +- ...t-and-filtered-children-nodes-report-1.txt | 2 +- ...st29-finer-redundancy-marking-report-0.txt | 4 +- tests/data/test-diff-filter/test3-report.txt | 4 +- .../test30-pr18904-rvalueref-report0.txt | 108 ++-- .../test30-pr18904-rvalueref-report1.txt | 108 ++-- .../test30-pr18904-rvalueref-report2.txt | 108 ++-- .../test31-pr18535-libstdc++-report-0.txt | 20 +- .../test31-pr18535-libstdc++-report-1.txt | 20 +- .../test32-ppc64le-struct-change-report0.txt | 2 +- .../test35-pr18754-no-added-syms-report-0.txt | 108 ++-- .../data/test-diff-filter/test36-report-0.txt | 6 +- .../data/test-diff-filter/test37-report-0.txt | 6 +- .../test39/test39-report-0.txt | 8 +- .../test42-leaf-report-output-0.txt | 2 +- .../test44-anonymous-data-member-report-0.txt | 2 +- .../test44-anonymous-data-member-report-1.txt | 2 +- tests/data/test-diff-filter/test9-report.txt | 2 +- ...x86_64--2.24.2-30.fc30.x86_64-report-0.txt | 12 +- .../PR24690/PR24690-report-0.txt | 10 +- .../data/test-diff-pkg/dirpkg-1-report-1.txt | 2 +- .../data/test-diff-pkg/dirpkg-3-report-1.txt | 2 +- .../data/test-diff-pkg/dirpkg-3-report-2.txt | 2 +- ...libICE-1.0.9-2.el7.x86_64.rpm-report-0.txt | 12 +- ...4--libcdio-0.94-2.fc26.x86_64-report.1.txt | 20 +- ...-2.0-0v5_2.4.1-1ubuntu2_amd64-report-0.txt | 24 +- .../nss-3.23.0-1.0.fc23.x86_64-report-0.txt | 14 +- ...l7.x86_64-0.12.8-1.el7.x86_64-report-2.txt | 494 +++++++++--------- .../symlink-dir-test1-report0.txt | 2 +- .../data/test-diff-pkg/tarpkg-0-report-0.txt | 2 +- .../data/test-diff-pkg/tarpkg-1-report-0.txt | 2 +- ...bb-4.3-3.20141204.fc23.x86_64-report-0.txt | 96 ++-- ...bb-4.3-3.20141204.fc23.x86_64-report-1.txt | 6 +- .../libtest48-soname-abixml-report-1.txt | 2 +- .../test0-type-suppr-report-0.txt | 4 +- .../test0-type-suppr-report-3.txt | 4 +- .../test0-type-suppr-report-5.txt | 4 +- .../test0-type-suppr-report-7.txt | 4 +- .../test1-typedef-suppr-report-0.txt | 8 +- .../test1-typedef-suppr-report-2.txt | 4 +- .../test11-add-data-member-report-0.txt | 4 +- .../test12-add-data-member-report-0.txt | 4 +- .../test12-add-data-member-report-2.txt | 4 +- .../test13-suppr-through-pointer-report-0.txt | 2 +- .../test13-suppr-through-pointer-report-1.txt | 2 +- .../test14-suppr-non-redundant-report-0.txt | 2 +- .../test14-suppr-non-redundant-report-1.txt | 2 +- .../test15-suppr-added-fn-report-0.txt | 2 +- .../test15-suppr-added-fn-report-1.txt | 2 +- .../test15-suppr-added-fn-report-5.txt | 2 +- .../test16-suppr-removed-fn-report-0.txt | 2 +- .../test16-suppr-removed-fn-report-2.txt | 2 +- .../test16-suppr-removed-fn-report-5.txt | 2 +- .../test17-suppr-added-var-report-0.txt | 2 +- .../test17-suppr-added-var-report-2.txt | 2 +- .../test17-suppr-added-var-report-5.txt | 2 +- .../test18-suppr-removed-var-report-0.txt | 2 +- .../test18-suppr-removed-var-report-2.txt | 2 +- .../test18-suppr-removed-var-report-5.txt | 2 +- .../test2-struct-suppr-report-0.txt | 4 +- .../test23-alias-filter-report-0.txt | 4 +- .../test23-alias-filter-report-2.txt | 4 +- .../test24-soname-report-1.txt | 2 +- .../test24-soname-report-10.txt | 2 +- .../test24-soname-report-12.txt | 2 +- .../test24-soname-report-14.txt | 2 +- .../test24-soname-report-16.txt | 2 +- .../test24-soname-report-4.txt | 2 +- .../test25-typedef-report-0.txt | 4 +- .../test26-loc-suppr-report-0.txt | 2 +- .../test26-loc-suppr-report-3.txt | 2 +- .../test29-soname-report-3.txt | 2 +- .../test29-soname-report-6.txt | 2 +- .../test29-soname-report-8.txt | 2 +- .../test3-struct-suppr-report-0.txt | 8 +- .../test3-struct-suppr-report-1.txt | 4 +- .../test3-struct-suppr-report-2.txt | 4 +- .../data/test-diff-suppr/test30-report-0.txt | 4 +- .../data/test-diff-suppr/test31-report-1.txt | 2 +- .../data/test-diff-suppr/test33-report-0.txt | 2 +- .../test-diff-suppr/test35-leaf-report-0.txt | 2 +- .../test-diff-suppr/test36-leaf-report-0.txt | 4 +- .../test4-local-suppr-report-0.txt | 8 +- .../test4-local-suppr-report-1.txt | 6 +- .../test42-negative-suppr-type-report-0.txt | 2 +- .../test42-negative-suppr-type-report-1.txt | 2 +- .../test46-PR25128-report-1.txt | 2 +- .../test46-PR25128-report-2.txt | 2 +- .../test47-non-reachable-types-report-1.txt | 2 +- .../test47-non-reachable-types-report-2.txt | 2 +- .../test47-non-reachable-types-report-4.txt | 2 +- .../test47-non-reachable-types-report-7.txt | 2 +- .../test5-fn-suppr-report-0.txt | 4 +- .../test5-fn-suppr-report-1.txt | 4 +- .../test5-fn-suppr-report-2.txt | 4 +- .../test5-fn-suppr-report-3.txt | 4 +- .../test5-fn-suppr-report-4.txt | 4 +- .../test5-fn-suppr-report-5.txt | 4 +- .../test6-fn-suppr-report-0-1.txt | 6 +- .../test6-fn-suppr-report-0.txt | 6 +- .../test6-fn-suppr-report-1.txt | 4 +- .../test6-fn-suppr-report-2.txt | 4 +- .../test6-fn-suppr-report-3.txt | 4 +- .../test6-fn-suppr-report-4.txt | 4 +- .../test7-var-suppr-report-0.txt | 8 +- .../test7-var-suppr-report-1.txt | 4 +- .../test7-var-suppr-report-2.txt | 4 +- .../test7-var-suppr-report-3.txt | 4 +- .../test7-var-suppr-report-4.txt | 4 +- .../test7-var-suppr-report-7.txt | 4 +- .../test7-var-suppr-report-8.txt | 8 +- .../test8-redundant-fn-report-0.txt | 2 +- .../test8-redundant-fn-report-1.txt | 2 +- 185 files changed, 927 insertions(+), 924 deletions(-) -- 2.30.0.280.ga3ce27912f-goog