public inbox for libabigail@sourceware.org
 help / color / mirror / Atom feed
From: Mark Wielaard <mark@klomp.org>
To: Dodji Seketeli <dodji@seketeli.org>
Cc: libabigail@sourceware.org
Subject: Re: [PATCH] tests: Update to catch.hpp v2.13.4 and fix #2178
Date: Wed, 24 Feb 2021 10:41:24 +0100	[thread overview]
Message-ID: <20210224094124.GH2992@wildebeest.org> (raw)
In-Reply-To: <87mtvt24wl.fsf@seketeli.org>

Hi Dodji,

On Wed, Feb 24, 2021 at 10:26:02AM +0100, Dodji Seketeli wrote:
> diff --git a/tests/lib/catch.hpp b/tests/lib/catch.hpp
> index 31745154..8bbc0a5b 100644
> --- a/tests/lib/catch.hpp
> +++ b/tests/lib/catch.hpp
> @@ -1,7 +1,6 @@
> -// SPDX-License-Identifier: BSL-1.0
>  /*
> - *  Catch v2.13.3
> - *  Generated: 2020-10-31 18:20:31.045274
> + *  Catch v2.13.4
> + *  Generated: 2020-12-29 14:48:00.116107
>   *  ----------------------------------------------------------
>   *  This file has been merged from multiple headers. Please don't edit it directly
>   *  Copyright (c) 2020 Two Blue Cubes Ltd. All rights reserved.

Note that since you are using a regenerated file it is loosing the
SPDX identifier that was added manually. Not a big issue since the
actual license that permits redistribution is still in the file, but
you might want to see if there is a way to update regenerated test
files so that they keep the identifier in case someone relies on them.

Cheers,

Mark

  reply	other threads:[~2021-02-24  9:42 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-24  9:26 Dodji Seketeli
2021-02-24  9:41 ` Mark Wielaard [this message]
2021-03-08 10:42   ` Dodji Seketeli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210224094124.GH2992@wildebeest.org \
    --to=mark@klomp.org \
    --cc=dodji@seketeli.org \
    --cc=libabigail@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).