From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <3N4qVYAgKCqwSbdaOUPMSaaSXQ.OaYXUNMNUSMUXeagdOQiMdQ.adS@flex--gprocida.bounces.google.com> Received: from mail-ed1-x549.google.com (mail-ed1-x549.google.com [IPv6:2a00:1450:4864:20::549]) by sourceware.org (Postfix) with ESMTPS id CFDDE3894C28 for ; Fri, 7 May 2021 18:43:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org CFDDE3894C28 Received: by mail-ed1-x549.google.com with SMTP id i17-20020a50fc110000b0290387c230e257so4923175edr.0 for ; Fri, 07 May 2021 11:43:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=5wd6tkism4Et5QCTUAXOniL1eGvaWpqc2q4n4HMcnv8=; b=apZj+AnQFXpTMpSN1eHlJx3FzZllAWBA9QAR2USdhzlNnAzX1ps3kQAbFpUPM7RRcY 2sB5g9NtTLZ9ipEsGbA4Bpj43p0yWn7XBLkACQLBPrSgb4mD/9/ouGkJRRFqL1acApEa HXr9nYMVfvSNhH0FEigd5NedTjt34SRYTbMziEUd61/2Y+FzA/rUktQ8NINdJV0QDrI1 Jyp9pGXhE3CVTUpna6Q32hr7KnfjWGUulI0K4nqLXLUy/pa5PE2mCVTcWDrlztza0PLt K0ZRwUxNp/uUlDJFmchdlTjaD4W/d06j7NXP1Wmu8guvG8qxSAZKi5+/tVjiyjY2ZBy4 7Dgw== X-Gm-Message-State: AOAM532DJovsne4K9Y22ZfQwlAgFW2PHWYaUk0wNm4a8VPi5SitBaPff KwBeSv0aHHgt/ff6Ai0Dt01t5ZzHPtAO1C+RVP1W+GZYhI/Wxo4dXs0RWD681GAZWL9k5UaeyE0 uyGg4t5Wbl4CdGzkJ4l/zpC2SLlXkrnTjvs54Ee7pomCIQldJfkTMVMMgbPGf6MbLV1qcCeM= X-Google-Smtp-Source: ABdhPJx6vGITfaEY9vn58t6OYpPIzMQNReQB1XSZytkujzojBWNvguFuv/6bdqbxAm9vrwye7710Xkgg1cBbuQ== X-Received: from tef.lon.corp.google.com ([2a00:79e0:d:210:e199:ad3e:6253:8fbc]) (user=gprocida job=sendgmr) by 2002:a17:906:5791:: with SMTP id k17mr11275025ejq.296.1620412983714; Fri, 07 May 2021 11:43:03 -0700 (PDT) Date: Fri, 7 May 2021 19:42:49 +0100 In-Reply-To: <20210507184250.3946416-1-gprocida@google.com> Message-Id: <20210507184250.3946416-3-gprocida@google.com> Mime-Version: 1.0 References: <20210507184250.3946416-1-gprocida@google.com> X-Mailer: git-send-email 2.31.1.607.g51e8a6a459-goog Subject: [RFC PATCH 2/3] XML writer: don't emit already emitted types From: Giuliano Procida To: libabigail@sourceware.org Cc: dodji@seketeli.org, kernel-team@android.com, gprocida@google.com, maennich@google.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-15.8 required=5.0 tests=BAYES_00, DKIMWL_WL_MED, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 May 2021 18:43:06 -0000 The XML writer sometimes emits type definitions entirely duplicated. This happens if for some reason a type is emitted early but is later emitted as one of the canonical types associated with a translation unit. Bug 26591 - detect pathologically redundant types in abixml * src/abg-writer.cc: (writer_context::write_canonical_types_of_scope): Do not emit already emitted types. * tests/data/test-annotate/test13-pr18894.so.abi: Refresh. * tests/data/test-annotate/test14-pr18893.so.abi: Refresh. * tests/data/test-annotate/test15-pr18892.so.abi: Refresh. * tests/data/test-annotate/test17-pr19027.so.abi: Refresh. * tests/data/test-annotate/test18-pr19037-libvtkRenderingLIC-6.1.so.abi: Refresh. * tests/data/test-annotate/test19-pr19023-libtcmalloc_and_profiler.so.abi: Refresh. * tests/data/test-annotate/test20-pr19025-libvtkParallelCore-6.1.so.abi: Refresh. * tests/data/test-annotate/test21-pr19092.so.abi: Refresh. * tests/data/test-read-dwarf/PR22015-libboost_iostreams.so.abi: Refresh. * tests/data/test-read-dwarf/PR22122-libftdc.so.abi: Refresh. * tests/data/test-read-dwarf/PR25042-libgdbm-clang-dwarf5.so.6.0.0.abi: Refresh. * tests/data/test-read-dwarf/PR26261/PR26261-exe.abi: Refresh. * tests/data/test-read-dwarf/test-libandroid.so.abi: Refresh. * tests/data/test-read-dwarf/test10-pr18818-gcc.so.abi: Refresh. * tests/data/test-read-dwarf/test12-pr18844.so.abi: Refresh. * tests/data/test-read-dwarf/test13-pr18894.so.abi: Refresh. * tests/data/test-read-dwarf/test14-pr18893.so.abi: Refresh. * tests/data/test-read-dwarf/test15-pr18892.so.abi: Refresh. * tests/data/test-read-dwarf/test16-pr18904.so.abi: Refresh. * tests/data/test-read-dwarf/test17-pr19027.so.abi: Refresh. * tests/data/test-read-dwarf/test18-pr19037-libvtkRenderingLIC-6.1.so.abi: Refresh. * tests/data/test-read-dwarf/test19-pr19023-libtcmalloc_and_profiler.so.abi: Refresh. * tests/data/test-read-dwarf/test20-pr19025-libvtkParallelCore-6.1.so.abi: Refresh. * tests/data/test-read-dwarf/test21-pr19092.so.abi: Refresh. * tests/data/test-read-dwarf/test22-pr19097-libstdc++.so.6.0.17.so.abi: Refresh. * tests/data/test-read-dwarf/test9-pr18818-clang.so.abi: Refresh. Signed-off-by: Giuliano Procida --- src/abg-writer.cc | 2 +- .../data/test-annotate/test13-pr18894.so.abi | 208 - .../data/test-annotate/test14-pr18893.so.abi | 4680 +- .../data/test-annotate/test15-pr18892.so.abi | 10977 ++-- .../data/test-annotate/test17-pr19027.so.abi | 13461 +--- ...st18-pr19037-libvtkRenderingLIC-6.1.so.abi | 726 +- ...19-pr19023-libtcmalloc_and_profiler.so.abi | 4726 +- ...st20-pr19025-libvtkParallelCore-6.1.so.abi | 7850 +-- .../data/test-annotate/test21-pr19092.so.abi | 2017 +- .../PR22015-libboost_iostreams.so.abi | 10 - .../test-read-dwarf/PR22122-libftdc.so.abi | 5 - .../PR25042-libgdbm-clang-dwarf5.so.6.0.0.abi | 279 - .../test-read-dwarf/PR26261/PR26261-exe.abi | 4 - .../test-read-dwarf/test-libandroid.so.abi | 2124 +- .../test-read-dwarf/test10-pr18818-gcc.so.abi | 20 - .../test-read-dwarf/test12-pr18844.so.abi | 2821 +- .../test-read-dwarf/test13-pr18894.so.abi | 134 - .../test-read-dwarf/test14-pr18893.so.abi | 3019 +- .../test-read-dwarf/test15-pr18892.so.abi | 3101 +- .../test-read-dwarf/test16-pr18904.so.abi | 1084 +- .../test-read-dwarf/test17-pr19027.so.abi | 8154 +-- ...st18-pr19037-libvtkRenderingLIC-6.1.so.abi | 428 - ...19-pr19023-libtcmalloc_and_profiler.so.abi | 2920 +- ...st20-pr19025-libvtkParallelCore-6.1.so.abi | 4427 +- .../test-read-dwarf/test21-pr19092.so.abi | 1587 +- .../test22-pr19097-libstdc++.so.6.0.17.so.abi | 50566 ++++++---------- .../test9-pr18818-clang.so.abi | 38 - 27 files changed, 33379 insertions(+), 91989 deletions(-) Patch too large to post here. See: https://github.com/myxoid/libabigail/commit/e3f22b080743b41253f72558206109a0f94a292d