From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <3MUA7YQgKCq4UdfcQWROUccUZS.QcaZWPOPWUOWZgcifQSkOfS.cfU@flex--gprocida.bounces.google.com> Received: from mail-ed1-x549.google.com (mail-ed1-x549.google.com [IPv6:2a00:1450:4864:20::549]) by sourceware.org (Postfix) with ESMTPS id 973E33858C39 for ; Fri, 10 Sep 2021 11:23:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 973E33858C39 Received: by mail-ed1-x549.google.com with SMTP id g4-20020a056402180400b003c2e8da869bso746270edy.13 for ; Fri, 10 Sep 2021 04:23:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:message-id:mime-version:subject:from:to:cc; bh=Xu7y7WaSnvNorbliao2UVzEaj/uXy/HESpidkbfJ1Ro=; b=tOwLthmu7qUgw7lAoOVZ2WfraJFFQTjMVPecaS8tUAYwBjJp/Tkh5opndnCPjnh93t mv+5XoVxRl4Fowgm2lrKZaL7WKPRjg5UfRsTtuOR64A2qJ5eai1MzqgN+J+uVUa4Va/v j3JExGF+v7lIW20g9Jp9r44LiU3kZzoRvaSBj5WufRlHDzLiuCUAOQbnjmDD2FLOuSiW j/i/WOKCRSxtlmIFk9SsKP4UOskSf1cCUg8IdvSxlyIzHg2VqLdH6vp/TY54Ln6M+WPr hFCQrxHPifVT93qZ7L5snk32el5v6cDAEK2sYXtg1CB1eGpvYsKTK9u+Z4FEFGjhiHVG IVxg== X-Gm-Message-State: AOAM5323aMlRTDAo+jfuBAdvQwBSCdJaGPgp4SGWB3FwG07vSQ6jmO0u YQqOj554qwjepagUVRFq31iE5YkwotAKE4szIdcB1W7O9A7/4snFP9sTXNpMoPv+9w4CEZmR1+P vqhLxmbgJsPMVUifdYIcECRpfVo43GOMAbE+hvyD+24yl5lEYzfSgoLykls9IOCvKI90iXFY= X-Google-Smtp-Source: ABdhPJzU51K5AKYR5KRuL7btFsHGqeoGasInT5JI1PeGwOm4SYRhQtFqA5t17/uTATf1NM+JcVqcjecg9Ecurg== X-Received: from tef.lon.corp.google.com ([2a00:79e0:d:210:fe2b:14b7:895d:9020]) (user=gprocida job=sendgmr) by 2002:a17:906:fc10:: with SMTP id ov16mr8893852ejb.300.1631273009432; Fri, 10 Sep 2021 04:23:29 -0700 (PDT) Date: Fri, 10 Sep 2021 12:23:21 +0100 Message-Id: <20210910112325.806676-1-gprocida@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.33.0.309.g3052b89438-goog Subject: [PATCH 0/4] Looking at equality and hashing From: Giuliano Procida To: libabigail@sourceware.org Cc: dodji@seketeli.org, kernel-team@android.com, gprocida@google.com, maennich@google.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-15.4 required=5.0 tests=BAYES_00, DKIMWL_WL_MED, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Sep 2021 11:23:34 -0000 These relate to PR28320. The first two patches are essentially code movement to better isolate where insertions and look-ups happen. The third patch adds some optional consistency checks. These find one issue in the test suite. Unfortunately, they do not pick up on issue in PR28320 itself. Perhaps there is a canonical type pointer issue as well. The last patch seems like an omission. Please take a look. Giuliano Procida (4): abg-writer: get_id_for_type: refactor insertion and look-up abg-writer: refactor recording of unemitted types abg-writer: allow debugging of equality / hash issues RFC: abg-writer: add a missing check for emitted declarations configure.ac | 16 ++++ src/abg-writer.cc | 184 +++++++++++++++++++++++++++++++--------------- 2 files changed, 139 insertions(+), 61 deletions(-) -- 2.33.0.309.g3052b89438-goog