From: "Guillermo E. Martinez" <guillermo.e.martinez@oracle.com>
To: libabigail@sourceware.org
Subject: [PATCH] ctf-reader: Fix memory leak reported by valgrind
Date: Mon, 22 Nov 2021 12:55:40 -0600 [thread overview]
Message-ID: <20211122185540.1973401-1-guillermo.e.martinez@oracle.com> (raw)
Hello,
Running unit test with check-valgrind, CTF reader test fails.
I'll appreciate your comments .. :-)
Thanks in advanced!
Guillermo
runtestreadctf fails executed by make check-valgrind, a memory leak is
reported:
at 0x48397B5: malloc (vg_replace_malloc.c:381)
by 0x56E6316: ctf_bufopen_internal (ctf-open.c:1388)
by 0x56E5FD3: ctf_bufopen (ctf-open.c:1297)
by 0x56CD688: ctf_arc_bufopen (ctf-archive.c:444)
by 0x4EB31FD: abigail::ctf_reader::read_corpus(abigail::ctf_reader::read_context*,\
abigail::elf_reader::status&) (abg-ctf-reader.cc:1111)
by 0x10C6BB: test_task_ctf::perform() (test-read-ctf.cc:236)
by 0x4E8E9AF: abigail::workers::worker::wait_to_execute_a_task\
(abigail::workers::queue::priv*) (abg-workers.cc:400)
by 0x543BEAD: start_thread (pthread_create.c:463)
by 0x5369A5E: clone (clone.S:95)
This is happening because `ctf_variable_next' bumps the dictionary
reference counter, so when `ctf_close' is called it doesn't free the
memory allocated by the dict, because `ctf_refcnt' is greater than one.
Therefore `ctf_dict_close' is required.
* src/abg-ctf-reader.cc (process_ctf_archive): Add
ctf_dict_close
Signed-off-by: Guillermo E. Martinez <guillermo.e.martinez@oracle.com>
---
src/abg-ctf-reader.cc | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/abg-ctf-reader.cc b/src/abg-ctf-reader.cc
index 3e17e049..b31a1b1f 100644
--- a/src/abg-ctf-reader.cc
+++ b/src/abg-ctf-reader.cc
@@ -941,6 +941,8 @@ process_ctf_archive(read_context *ctxt, corpus_sptr corp)
}
if (ctf_errno(ctf_dict) != ECTF_NEXT_END)
fprintf(stderr, "ERROR from ctf_symbol_next\n");
+
+ ctf_dict_close(ctf_dict);
}
if (ctf_err != ECTF_NEXT_END)
fprintf(stderr, "ERROR from ctf_archive_next\n");
--
2.33.0
next reply other threads:[~2021-11-22 18:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-22 18:55 Guillermo E. Martinez [this message]
2021-11-22 20:11 ` Jose E. Marchesi
2021-11-29 7:48 ` Dodji Seketeli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211122185540.1973401-1-guillermo.e.martinez@oracle.com \
--to=guillermo.e.martinez@oracle.com \
--cc=libabigail@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).