From: Giuliano Procida <gprocida@google.com>
To: libabigail@sourceware.org
Cc: dodji@seketeli.org, kernel-team@android.com, gprocida@google.com,
maennich@google.com
Subject: [PATCH 1/4] XML writer: remove type_hasher and remaining comment
Date: Fri, 21 Jan 2022 17:30:02 +0000 [thread overview]
Message-ID: <20220121173005.3196387-2-gprocida@google.com> (raw)
In-Reply-To: <20220121173005.3196387-1-gprocida@google.com>
The type_hasher functor is no longer used.
* src/abg-writer.cc (type_hasher): Remove this unused functor.
Remove a following comment referencing it.
Reviewed-by: Matthias Maennich <maennich@google.com>
Signed-off-by: Giuliano Procida <gprocida@google.com>
---
src/abg-writer.cc | 13 ++-----------
1 file changed, 2 insertions(+), 11 deletions(-)
diff --git a/src/abg-writer.cc b/src/abg-writer.cc
index 24a1fd56..525f6682 100644
--- a/src/abg-writer.cc
+++ b/src/abg-writer.cc
@@ -107,18 +107,9 @@ public:
}
};
-/// A hashing functor that should be as fast as possible.
-struct type_hasher
-{
- size_t
- operator()(const type_base* t) const
- {return hash_type(t);}
-}; // end struct type_hasher
-
/// A convenience typedef for a map that associates a pointer to type
-/// to a string. The pointer to type is hashed as fast as possible.
-typedef unordered_map<type_base*,
- interned_string> type_ptr_map;
+/// to a string.
+typedef unordered_map<type_base*, interned_string> type_ptr_map;
// A convenience typedef for a set of type_base*.
typedef std::unordered_set<const type_base*> type_ptr_set_type;
--
2.34.1.703.g22d0c6ccf7-goog
next prev parent reply other threads:[~2022-01-21 17:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-21 17:30 [PATCH 0/4] small XML writer changes Giuliano Procida
2022-01-21 17:30 ` Giuliano Procida [this message]
2022-02-25 9:37 ` [PATCH 1/4] XML writer: remove type_hasher and remaining comment Dodji Seketeli
2022-01-21 17:30 ` [PATCH 2/4] XML writer: drop write_elf_symbols_table variable emitted_syms Giuliano Procida
2022-02-25 9:50 ` Dodji Seketeli
2022-01-21 17:30 ` [PATCH 3/4] XML writer: improve slightly emission of top-level declarations Giuliano Procida
2022-02-25 9:52 ` Dodji Seketeli
2022-01-21 17:30 ` [PATCH 4/4] XML writer: do not create extra temporary referenced type shared_ptr Giuliano Procida
2022-02-25 9:52 ` Dodji Seketeli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220121173005.3196387-2-gprocida@google.com \
--to=gprocida@google.com \
--cc=dodji@seketeli.org \
--cc=kernel-team@android.com \
--cc=libabigail@sourceware.org \
--cc=maennich@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).