From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <32RAyYggKCtoCLNK8E96CKKCHA.8KIHE767EC6EHOKQN8AS6NA.KNC@flex--gprocida.bounces.google.com> Received: from mail-wr1-x449.google.com (mail-wr1-x449.google.com [IPv6:2a00:1450:4864:20::449]) by sourceware.org (Postfix) with ESMTPS id DEF913881873 for ; Wed, 16 Mar 2022 16:31:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DEF913881873 Received: by mail-wr1-x449.google.com with SMTP id 15-20020adf808f000000b00203e488fa4eso248749wrl.3 for ; Wed, 16 Mar 2022 09:31:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=hgmre9K82O45/9cKCchiRfagQ+EIvkOeVjg1pBZVcZU=; b=Vhm8RJr24y9U/fON2UCI7yhXldMx7n1kxpeTVNBuS8p3D0wIw3uz7NXYr/gjyr68X1 xn6zjbCoIye8hCQStvjvAudyyMBr72WUcbN8kn29WHJ2i41yWrOkqdz8xVpihI0fFlfa 4ccV6XHBgKAlSxc30sOuDEVgxxxcrJzDbd32GTVCxHK65aQi2HHoFhLqJYwvazTvevBm eONHBi1y80rH5itfsH2H2XFe4qMVo/hLNqpzXKa/WGh5uXB24b97iJROSBM9Ohn14XKL 7Zm9f4k8P+b54trk/HTO1SAQ3byc3ckxLh9O52u/nG+NYItNkAOMSqR/gpKszIVMVH80 zfLg== X-Gm-Message-State: AOAM532MeoYuf8OqAoUMHM+NFyIPwSMFHC2++dd1ro+4uJXXOipftY4E Li69Dhch+OmriXPalxIWPtzKwK1vOzzj6djDG1z3owWnlGmm2xPlj0UHh3SCtlnMrEgqbXS9NWO XOtmK3Wg1Pg6MUGEx+8sqgYd9GVr+XPv/cGcSK9JUI3JmDhsvI7gE/ydjHee5Ukj+gYuqoVI= X-Google-Smtp-Source: ABdhPJyAePQQeynjAo77DX6JzBms68Do8eldWYH5FkcbodVh7TZLkTjPOhG/qY0s/OEMf/HkOgurJMgymEK35g== X-Received: from tef.lon.corp.google.com ([2a00:79e0:d:210:5871:c940:7381:f8f4]) (user=gprocida job=sendgmr) by 2002:a5d:6cc2:0:b0:1f1:dc97:d87e with SMTP id c2-20020a5d6cc2000000b001f1dc97d87emr597556wrc.470.1647448281578; Wed, 16 Mar 2022 09:31:21 -0700 (PDT) Date: Wed, 16 Mar 2022 16:30:51 +0000 In-Reply-To: <20220314181312.3436802-1-gprocida@google.com> Message-Id: <20220316163055.4127796-1-gprocida@google.com> Mime-Version: 1.0 References: <20220314181312.3436802-1-gprocida@google.com> X-Mailer: git-send-email 2.35.1.894.gb6a874cedc-goog Subject: [PATCH v2 0/4] add symbol namespace support, update symbol CRC support From: Giuliano Procida To: libabigail@sourceware.org Cc: dodji@seketeli.org, kernel-team@android.com, gprocida@google.com, maennich@google.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-16.6 required=5.0 tests=BAYES_00, DKIMWL_WL_MED, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Mar 2022 16:31:24 -0000 New in v2: * updates following review (includng tweaking a function I copied from) * better offset checking and working extraction of namespace from .ko * rework of CRCs to be similar to namespaces (use of optional etc.) * test case additions / updates Giuliano Procida (4): optional: minor improvements crc_changed: eliminate copying of shared_ptr values add Linux kernel symbol namespace support Linux symbol CRCs: support 0 and report presence changes include/abg-cxx-compat.h | 30 +++++++-- include/abg-ir.h | 17 ++++-- src/abg-comp-filter.cc | 46 ++++++++++++-- src/abg-ir.cc | 47 ++++++++++---- src/abg-reader.cc | 15 +++-- src/abg-reporter-priv.cc | 38 ++++++++++-- src/abg-symtab-reader.cc | 61 +++++++++++++++++++ src/abg-writer.cc | 9 ++- tests/data/Makefile.am | 7 ++- .../data/test-abidiff/test-crc-report-0-1.txt | 16 +++++ .../data/test-abidiff/test-crc-report-1-0.txt | 16 +++++ ...crc-report.txt => test-crc-report-1-2.txt} | 0 tests/data/test-abidiff/test-namespace-0.xml | 15 +++++ tests/data/test-abidiff/test-namespace-1.xml | 15 +++++ .../test-abidiff/test-namespace-report.txt | 17 ++++++ tests/test-abidiff.cc | 12 +++- tests/test-symtab.cc | 8 +-- 17 files changed, 322 insertions(+), 47 deletions(-) create mode 100644 tests/data/test-abidiff/test-crc-report-0-1.txt create mode 100644 tests/data/test-abidiff/test-crc-report-1-0.txt rename tests/data/test-abidiff/{test-crc-report.txt => test-crc-report-1-2.txt} (100%) create mode 100644 tests/data/test-abidiff/test-namespace-0.xml create mode 100644 tests/data/test-abidiff/test-namespace-1.xml create mode 100644 tests/data/test-abidiff/test-namespace-report.txt -- 2.35.1.894.gb6a874cedc-goog