From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <mark@klomp.org>
Received: from gnu.wildebeest.org (gnu.wildebeest.org [45.83.234.184])
 by sourceware.org (Postfix) with ESMTPS id ACFF03858C2C
 for <libabigail@sourceware.org>; Fri, 29 Apr 2022 22:02:32 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org ACFF03858C2C
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=klomp.org
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=klomp.org
Received: by gnu.wildebeest.org (Postfix, from userid 1000)
 id D9061302BBED; Sat, 30 Apr 2022 00:02:31 +0200 (CEST)
Date: Sat, 30 Apr 2022 00:02:31 +0200
From: Mark Wielaard <mark@klomp.org>
To: Ben Woodard <woodard@redhat.com>
Cc: Ben Woodard via Libabigail <libabigail@sourceware.org>
Subject: Re: Fwd: Testing Setup - More Tests and Automation?
Message-ID: <20220429220231.GD7305@gnu.wildebeest.org>
References: <CAM=pu++-JdBdizXQ9dj8eUypXg7fpPOTDzN6BL1NY-TFvk++kQ@mail.gmail.com>
 <34E58964-E930-4DF9-87CD-18D4C63DBCEB@redhat.com>
 <YmpLI/I8/I0/Bm2J@wildebeest.org>
 <20220429211304.GC7305@gnu.wildebeest.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220429211304.GC7305@gnu.wildebeest.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS,
 SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: libabigail@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Mailing list of the Libabigail project <libabigail.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/libabigail>,
 <mailto:libabigail-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/libabigail/>
List-Help: <mailto:libabigail-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/libabigail>,
 <mailto:libabigail-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Fri, 29 Apr 2022 22:02:34 -0000

Hi,

On Fri, Apr 29, 2022 at 11:13:04PM +0200, Mark Wielaard wrote:
> And it caught an issue on fedora-ppc64 and debian-ppc64
> https://builder.sourceware.org/buildbot/#/builders/libabigail-fedora-ppc64
> https://builder.sourceware.org/buildbot/#/builders/libabigail-debian-ppc64
> 
> FAIL: runtestslowselfcompare.sh
> ===============================
> + abidw=../tools/abidw
> + objdir=../src/.libs
> + echo ENABLE_SLOW_TEST=yes
> ENABLE_SLOW_TEST=yes
> + test xyes '!=' x
> ++ ../tools/abidw --abidiff ../src/.libs/libabigail.so
> lt-abidw: abg-symtab-reader.cc:557: void abigail::symtab_reader::symtab::update_function_entry_address_symbol_map(Elf*, GElf_Sym*, const elf_symbol_sptr&): Assertion `__abg_cond__' failed.
> FAIL runtestslowselfcompare.sh (exit status: 134)
> 
> It didn't fail any other builder (so it isn't power specific, because
> fedora-ppc64le is green, and it isn't big endian specific, because
> fedora-s390x is green).
> 
> But it might have to do with ppc64 function descriptors, which are
> ppc64 specific.

It indeed is. The issue is in update_function_entry_address_symbol_map
which is only called for ppc64 ELFv1 binaries.

src/.libs/libabigail.so contains two identical symbols:

  468: 0000000000427498    604 FUNC    GLOBAL DEFAULT       21 _ZN7abigail10comparison12pointer_diffC2ESt10shared_ptrINS_2ir16pointer_type_defEES5_S2_INS0_4diffEES2_INS0_12diff_contextEE
 7362: 0000000000427498    604 FUNC    GLOBAL DEFAULT       21 _ZN7abigail10comparison12pointer_diffC2ESt10shared_ptrINS_2ir16pointer_type_defEES5_S2_INS0_4diffEES2_INS0_12diff_contextEE

But those are not seen as aliases. And the assert says:

      ABG_ASSERT(two_symbols_alias
                 || symbol_is_foo_and_prev_symbol_is_dot_foo);

I don't understand the aliasing code well enough to understand why
yet.

Cheers,

Mark