public inbox for libabigail@sourceware.org
 help / color / mirror / Atom feed
From: Giuliano Procida <gprocida@google.com>
To: libabigail@sourceware.org
Cc: dodji@seketeli.org, kernel-team@android.com, gprocida@google.com,
	 maennich@google.com, sidnayyar@google.com, vvvvvv@google.com
Subject: [PATCH 0/3] Improve resolution of declaration-only enums
Date: Thu, 25 Aug 2022 12:48:53 +0100	[thread overview]
Message-ID: <20220825114856.3137373-1-gprocida@google.com> (raw)

Hi Dodji.

We noticed this sort of output in Android kernel ABI XML:

    <enum-decl name='dax_access_mode' is-declaration-only='yes' id='241913bb'>
      <underlying-type type-id='52ba91e1'/>
    </enum-decl>
    ...
    <enum-decl name='dax_access_mode' filepath='include/linux/dax.h' line='17' column='1' id='241913ba'>
      <underlying-type type-id='9cac1fee'/>
      <enumerator name='DAX_ACCESS' value='0'/>
      <enumerator name='DAX_RECOVERY_WRITE' value='1'/>
    </enum-decl>

Note that they have distinct type ids and are both referenced by the
rest of the ABI.

This short series fixes the issue and another minor bug at the same
time.

Regards,
Giuliano.

Giuliano Procida (3):
  abidw: fix --stats output for resolved classes and enums
  abidw: remove always true test in resolve_declaration_only_classes
  abidw: resolve declaration-only enums the same as classes

 src/abg-dwarf-reader.cc | 84 ++++++++++++++++++++++++++++-------------
 1 file changed, 57 insertions(+), 27 deletions(-)

-- 
2.37.1.595.g718a3a8f04-goog


             reply	other threads:[~2022-08-25 11:49 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-25 11:48 Giuliano Procida [this message]
2022-08-25 11:48 ` [PATCH 1/3] abidw: fix --stats output for resolved classes and enums Giuliano Procida
2022-08-29 11:19   ` Dodji Seketeli
2022-08-25 11:48 ` [PATCH 2/3] abidw: remove always true test in resolve_declaration_only_classes Giuliano Procida
2022-08-29 11:19   ` Dodji Seketeli
2022-08-25 11:48 ` [PATCH 3/3] abidw: resolve declaration-only enums the same as classes Giuliano Procida
2022-08-29 11:20   ` Dodji Seketeli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220825114856.3137373-1-gprocida@google.com \
    --to=gprocida@google.com \
    --cc=dodji@seketeli.org \
    --cc=kernel-team@android.com \
    --cc=libabigail@sourceware.org \
    --cc=maennich@google.com \
    --cc=sidnayyar@google.com \
    --cc=vvvvvv@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).