From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by sourceware.org (Postfix) with ESMTPS id 415E03858CDB for ; Mon, 16 Jan 2023 16:36:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 415E03858CDB Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com Received: from pps.filterd (m0246632.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 30GG4Gi6002650; Mon, 16 Jan 2023 16:36:00 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : content-type : in-reply-to : mime-version; s=corp-2022-7-12; bh=k43XZAFJ7w7tMi7sS6eeCnB7TUo7EFXTIgg879E/wC8=; b=ykC4fXypdzNqpBW/3gtDEBpWpQjk8coSJDmHIBZ3ELLI0MI2Ybn1JSPJ3sFmvqPQLqdG /ffrQHpW/VEtoFptZLNXGnmq5o4XfRQQS/Vcu3tp4TNJCkCydHbe3mylSVmWhdUw3ZsS LtvC7H3IEcCWIHHRT8luPYM92BjgWTKH86tuBGgkqzO+ekt4UwDxIQtAiDYGwOvt90f8 aQXlatmaOLCQ59xBAjJeQaqKoFpNvTfFPjTEX8d8ik1BNwmvUEJGD2hU7dYMRsMeYe4e NiC2LQGJd2MtjwHOa/rcOq3VC/O4GWPCa++jGHFdfWcB4T4rkueLavx1CbBcd7QlDhkT qA== Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta03.appoci.oracle.com [130.35.103.27]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3n3m0tk1p9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 16 Jan 2023 16:36:00 +0000 Received: from pps.filterd (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 30GEK5OO028533; Mon, 16 Jan 2023 16:35:59 GMT Received: from nam10-dm6-obe.outbound.protection.outlook.com (mail-dm6nam10lp2103.outbound.protection.outlook.com [104.47.58.103]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3n4s2r3hb6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 16 Jan 2023 16:35:59 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WK4JyUu3JNkInkku6fDfj4KfOpR64J1/SHKrECIFlzz4KFGIhelDKf0ml58+C8InQtHtyUjUY4FrCM6i7pHEgnjC/KCiMT/k2UGAAuggJKdrT/RGahjjOmMH39B/ilEb01X0g14Mc3+ndce24ehobk/Mg4d61VoGMOwUlbHZ8dj8nrEpCd1zokbIDvnKlPgWg07VSiGIt6rU5a6hAlHH5KnAFmmLtu1ZNLh52TQ1KhaGEC6JQeCE+4id8ymhWAlogyjMN/QI5+z9dPHncUKdQ6F0fl2FnV1r5qVAU7wiBJ1q09EKrh/ZHx4r1T0uxNB9zfR4f4gnFnzKRcAV5IpIIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=k43XZAFJ7w7tMi7sS6eeCnB7TUo7EFXTIgg879E/wC8=; b=m/sqfiXv11fbTTIlz/GvzCr8kJ7m+zzC5IlmKpMkt1xuucnWAlXZMR2qShB94TB60aGSb3AP9zOJxnuvUkai79LwjzGMmTow6zIa+WRfELXVGEWsbJeeM8uOC7+ImafdMNu1B7kKUX/tIeOyXeIzgEuvD6UaXq3HT12cNz/PgmnPkJYGBz2OhLyWw7e3W/pHAX0yM6mtE5psaNroT1Gjdyhe0bmTFDclGVbbjjqF5RtdqbQIfH4JRsWWhj0/4iKpi7sUicsmFbupFxJ9EyYfEvFSOVTrUKAEmfWVDR1r8sU+iTnFOyUonCZlxDV1ndKa02Phrh0Q2dp/XOQRfm3vPg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=k43XZAFJ7w7tMi7sS6eeCnB7TUo7EFXTIgg879E/wC8=; b=XRIev4OKdOTDVidg+LUefa0Ofe3ApkNF3vybjlMw3UabcRPbgMz2wd/hnQGdrjOCasIW36wlK/zKJBZ3qZ72aHJlJNrFHXl8D8IWPk5lqInoytVhAxuypniuRIFXh/hQL3D+j+pj9lb/RAbVolgu4C4iCl5jY5z245Xutxbj4R4= Received: from MWHPR10MB1407.namprd10.prod.outlook.com (2603:10b6:300:23::20) by MW5PR10MB5873.namprd10.prod.outlook.com (2603:10b6:303:19b::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.11; Mon, 16 Jan 2023 16:35:57 +0000 Received: from MWHPR10MB1407.namprd10.prod.outlook.com ([fe80::70df:cb31:cf08:5b12]) by MWHPR10MB1407.namprd10.prod.outlook.com ([fe80::70df:cb31:cf08:5b12%9]) with mapi id 15.20.6002.013; Mon, 16 Jan 2023 16:35:57 +0000 Date: Mon, 16 Jan 2023 10:35:53 -0600 From: "Guillermo E. Martinez" To: Dodji Seketeli Cc: libabigail@sourceware.org Subject: Re: [PATCH, request-for-review] Update CTF's ctf_dict_t detection Message-ID: <20230116163553.wzkw34rsn7okz4xm@kamehouse> References: <87mt6ivo7n.fsf@redhat.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87mt6ivo7n.fsf@redhat.com> X-ClientProxiedBy: SN6PR2101CA0018.namprd21.prod.outlook.com (2603:10b6:805:106::28) To MWHPR10MB1407.namprd10.prod.outlook.com (2603:10b6:300:23::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR10MB1407:EE_|MW5PR10MB5873:EE_ X-MS-Office365-Filtering-Correlation-Id: 5bc8d4da-40b7-4a54-1f27-08daf7dfbe82 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Ny5mGR8IjZloTF0HCdtqSvfoG6azovJwcp2kfbDB+yCFcKaPczFFEKl8KUC6qTXxBWunYgpcFayMy0iQ2ROwTT/PVAiF+3PQJ67DQUSrQpwL6Jy7dVubpARpazBD3dbyUJUYbzuclu5ISkHE3ecsPIZJNMJsqQZw6qGB7vlibO5FugW8Vxjydm79kKD484VrXGEUKVEKddfWLcj0Le/2JwsnvTsUwdAj2lvhJWQU+7ybEI2wqSZbG9d3w0OXSmkp0+FsTrJvPiA8niIuk3HwhSYlwJpy6WhW4XrHUibsKkV70LE75JnOuxhvt2UuRxG6RrmnyuGIkmmy26Nh8yCkE4sk29o5BNV5odtsWENAh1h3qb7ZGeAFyIUsEPUyZ3GqR+1FC7HGsFon95mqn+iqYkzUPgwe+NA+ugAvn2Npz1s9/vUFc1gFDRytoPL+G8jaWYFSG9qZRElGCYLTvc1VnLiqx4erMKtw9mo7PCTQtHPlOYSbatLB1NPvfd0vjlF95FHyZQNhtQ7ZGAnyNs73Te3nIV0RNeNt7c3/ntwIwsL+K4ON71cTNd7mDPRZJ5p1rHRvK/E44BhJrgQA5DDCT18GYinkdypa9mbN/SkvwEH16QzTNEr0D+nS+nzbj4ao2IhvCYVwmFTp5koD0RZI8w== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR10MB1407.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(7916004)(136003)(376002)(346002)(396003)(366004)(39860400002)(451199015)(38100700002)(83380400001)(86362001)(2906002)(4744005)(8936002)(5660300002)(8676002)(6916009)(66946007)(66476007)(4326008)(66556008)(41300700001)(33716001)(9686003)(6506007)(186003)(26005)(1076003)(6512007)(478600001)(6666004)(6486002)(316002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?7EFPF/dYEiN0ulBkczlJM29/2FmGn+m8jxBrBaFGprGUTF9At277T6WkX1+D?= =?us-ascii?Q?wWuPafF3pvBojSqLq5SB+VrVT/4VT/zJqHAKEfvM1U89OKTgOnLsSQKG7WqU?= =?us-ascii?Q?aC5jqI2xdjkB6WZuNj91i9SL6gibChYOcX1lUbwQjqt6TszzGt7itCuxYN7/?= =?us-ascii?Q?I/XwKcgkY4Yvprey1JDHG5gnIpXCcKclMD7TJk7gBX2o+ZGaoBPElAw8OqA7?= =?us-ascii?Q?xZTi7VH2qUW9QVh0OrFVA3wfLItq6iWlO5n7Pcy7j4mRLZV84+hWMaSo2iXh?= =?us-ascii?Q?xcrHeJ3sQXbsJ2SGBzG2M9VgCsaO1zlts4bydMUd5xZYuVuXzghOms66tMLM?= =?us-ascii?Q?/7jDLhXXj4bV/9vJVMLQ1z/Th/+rhIaJZiK4ET7ZdfvuCWYNd8QjyFSpLzjx?= =?us-ascii?Q?Q1/9gIYaHMVZHrkx4NLMwxwSMqZfzI7xK2KMJgqWPHh/BjFc+pGu4XqFA0AY?= =?us-ascii?Q?tQ+XFwFcElxyeQMQgMfdDHWNApzYK34HwsdRPaCmBLWLn2LcnrEG2JN8vCBy?= =?us-ascii?Q?1SIARqnwBf0QcM6FG42Qp1B+DqlcFlk7t8ZsDIWQFgq5++Cv4ux5477wif/K?= =?us-ascii?Q?zslClm6FjwN6u7potjfOlr7JtBcaCy2zPHgi6YCPnyba/ChQN1BXXMOGwVya?= =?us-ascii?Q?1ffozTSAwMs/nGyxuWhsahs6FmZnfmJ1+tecRvQNKA+C7DsMp3+Wqy6/X54P?= =?us-ascii?Q?Mr3cEHUEVRaLetuFB/nBjjj8a+BOJJ4IiVTjgMoLVdPcQFVuLiuLWEXFpZ8t?= =?us-ascii?Q?fVVjWO0BOegVY0PcsPrKSbstCs1AybZR177UG04HW5TTrg34Ps6JUh2JzNzs?= =?us-ascii?Q?3HYtsKk5LyPHvKK/gU3bCxIIwsZpLwDyOA0blHNrfng64Nwz35A1Xl6qmABY?= =?us-ascii?Q?9LcgHbClEU/ZFLVLYYacNGKNiQUkF9XUvwE9ejIlmyj6Zwbux0lADy11APPl?= =?us-ascii?Q?QBeZSta+n7V8Rq7CqJbCv2F9Dl2mNqpYKN8YId/fdX3rwC1qRXR0Od134i7E?= =?us-ascii?Q?kM+OnshL+EpvDS7Gb+ZXeMB8ROwrKZNj2iProDJ9ubeyjJwiqKebFXZ/ZsgR?= =?us-ascii?Q?TZy2HZc3eEqexotRKrrIu/bdOwKDMHrjYQXk9zYQ8KQhvvN2e406HfIhqZaG?= =?us-ascii?Q?Ce4JP+2gCcRzGxd8t0S2IbrUGxYWbfzRcWVtD2idvYwwfoHToQvO5xaya+c2?= =?us-ascii?Q?wfONHDW6Emdwe1fS5zLkxhhVv0pxNmTy/WviqIOXvgSlYHWSNB2OGM3pnT+C?= =?us-ascii?Q?h0JpvW2KJtgHs4GPQ9Vx33uX9bg3D3pRSneOu3uNEalOCxK4riXrEKn0ilp+?= =?us-ascii?Q?kRYv+PZ1O6BFrHxXHevV7iv1g8G9QDmuU+za8SqxJOne+1Ir6tH6APFNb8Rf?= =?us-ascii?Q?4IoXgrLzVinRMd9uEsHghjI3IRnCQFERlKrkAGS641L4tek+LBO9kYi8DIi1?= =?us-ascii?Q?TX1L9RtofaPFH9D4hArOLjQeXO3ogpTTOnOeSm2EGJ+AdY2XNW6JqMrGK+Id?= =?us-ascii?Q?KRW7eGgHUOBoxPN7ekXlAEJvbFCDqbW1iiSj7lHqjajeONVv6lwXx3Ksn9Xe?= =?us-ascii?Q?XXxw3SGmo7m6kUBmNVzoqtqIv5ehThDR8fS8MeAATvdDVvk1TH4NbJoMpigD?= =?us-ascii?Q?FXmCl19RVkD4ONZAdkRAMr0=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: K8OyfOzwWXpIjCGMUu8T13rqHyPrwoPancUm9svYVyz1/KbZGPqtG7D79IvGFKFnsQzHOVL8ZtZxAisUqxP6THLgp8HzfH7j+b0l5jWIwmn+GL0TV9Gg3HFXvWcsPNVjPlAKrTpvpH7b3yMR5EfcA30GYLuXs8huevrgRr5wuSm2gLvg3/cUDNNsZZLzwKnPOAob9lgjHdkqTOQF/jN04nt3gpZh+WDQ4BqPjMNBetP7DWp6DOo45hy3we1LX6xIWmGoe4o9ok2Mty0hA6i1nTy958g7AqJ2O+3r/j3vRtFdbKqrmE/zKFpIygJHMkvq/PyNVWdGaOjrFu4b+qf3s+TuBWWqxUoNoWs6FOScx888AuwbEo3d9CuYcpZNhvLHelPEekQYNNrLqn+RcTp9kcHAzMVhayztdeCOxZ8G+35n3VOKhLQG0XL8FOqICBsXhFCYfSlYO9VOZWCV7RVgufs5bEU99a4KbmNS8NQAZpe2L6aTDDgywvYaith6pc1wGka5AblO0CU11KGUx3G3C47Q4TMXuaqNs6ETH0A3SdHD2VI5AtX6Jt4OGzIgDv93LYfuShKhLHmZ/znrZW/yPgEqy0vfpZ8IiIg82HjFtwIPw9ukEGGu//768aPU2OOpdVZdm/zFZpZt0ObCHf4Nyn76PDuSH1TQuogkmZ9zutD1LgPYbSRsCpREKiYnMvHeDOI7emuvqOuwsn5bE8hvGAQqhwPO20wsU6e1X9+B2KRnVi2Vs5I5+50ndIbHc3R7ElafsNgaJpNePkOmdh1JnggsLGa3biq39aFTHcY0Onc= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5bc8d4da-40b7-4a54-1f27-08daf7dfbe82 X-MS-Exchange-CrossTenant-AuthSource: MWHPR10MB1407.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jan 2023 16:35:57.4500 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Kr122c4lS0R0juWFdrjtztebei/JiMnWHABgSjNkbNbLjoSTz4jyvDbnUdBKXtzyXtk33imuBvISSEswfhJtTrw1BBiAFvEgGINSrYwZp4I= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW5PR10MB5873 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.923,Hydra:6.0.562,FMLib:17.11.122.1 definitions=2023-01-16_14,2023-01-13_02,2022-06-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 adultscore=0 mlxlogscore=999 suspectscore=0 malwarescore=0 bulkscore=0 spamscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2301160123 X-Proofpoint-GUID: CwjmUPjOcUso9eu5YtyDzb5HCTtzHRuM X-Proofpoint-ORIG-GUID: CwjmUPjOcUso9eu5YtyDzb5HCTtzHRuM X-Spam-Status: No, score=-6.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, Jan 16, 2023 at 10:11:08AM +0100, Dodji Seketeli wrote: > Hello, > > As ctf_dict_t can be an opaque type depending on the version of > ctf-api.h, using AC_CHECK_TYPE won't work to detect it because that > macro invokes sizeof(ctf_dict_t). > > With this change, we don't require that ctf_dict_t be fully defined. > > * configure.ac: Use AC_COMPILE_IFELSE to try and compile a code > snippet that doesn't need that ctf_dict_t be fully defined. > > Would this be OK to commit? It LGTM. I tested it, dependencies to enable CTF are detected by `configure' script. > Thanks. > Thanks! > Signed-off-by: Dodji Seketeli > --- > configure.ac | 11 ++++++----- > [...]