From: Ben Woodard <woodard@redhat.com>
To: libabigail@sourceware.org
Cc: Ben Woodard <woodard@redhat.com>
Subject: [PATCH] Have fedabipkgdiff sleep while waiting for abipkgdiff
Date: Tue, 28 Mar 2023 12:52:28 -0700 [thread overview]
Message-ID: <20230328195228.701948-1-woodard@redhat.com> (raw)
While running tests, I noticed that python was consuming a huge amount
of CPU. Frank ch Eiger fche@redhat.com located the problem and pointed
out that python was continiously polling for abipkgdiff's
completion. For small packages, the time to completion can be less
than a second but some packages can take literally hours to
analyze. Having python spinning in such a tight loop is unnecessary. I
added a small sleep to this loop with a bit of backoff. Vanessa Sochat
helped with examples of how to fix the python code.
* tools/fedabipkgdiff add sleep while waiting for subprocess
completion.
Signed-off-by: Ben Woodard <woodard@redhat.com>
---
tools/fedabipkgdiff | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/tools/fedabipkgdiff b/tools/fedabipkgdiff
index db23d5a3..2867a8d0 100755
--- a/tools/fedabipkgdiff
+++ b/tools/fedabipkgdiff
@@ -20,6 +20,7 @@ import shutil
import six
import subprocess
import sys
+import time
from collections import namedtuple
from itertools import chain
@@ -1187,9 +1188,14 @@ def abipkgdiff(cmp_half1, cmp_half2):
# then we get its output.
#
+ sleeptime = 0.2
while True:
if proc.poll() != None:
break
+ time.sleep(sleeptime)
+ # cap the sleep time at 1.6s
+ if sleeptime < 2.0:
+ sleeptime = sleeptime * 2
stdout = ''.join(proc.stdout.readlines())
stderr = ''.join(proc.stderr.readlines())
--
2.31.1
next reply other threads:[~2023-03-28 19:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-28 19:52 Ben Woodard [this message]
2023-03-31 21:12 ` Dodji Seketeli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230328195228.701948-1-woodard@redhat.com \
--to=woodard@redhat.com \
--cc=libabigail@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).