From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id E4349384DE53 for ; Fri, 7 Jul 2023 18:01:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E4349384DE53 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1688752885; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=gKDqDqKEwrs6sFPTKKwmItYmtqvzgIDyBr3hv9tWns4=; b=H6M2LzP4YiKWumVi5RJqh/VvMi9Wlg4y3jFVXkpunYwvAq6Fsa5KGqW79dYsq3oSpRaAHA T3C1EBLeo3siO8L/4B9RZlLFEk2dnJjdtEmpFxhJRgKO88Gopy08NU9HBqwUkrhOGswGcY dw0YGkskPGcngrvkOebXL7HxuExZ90w= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-92-snA3kUhLOB6v59Zw_tSCtA-1; Fri, 07 Jul 2023 14:01:24 -0400 X-MC-Unique: snA3kUhLOB6v59Zw_tSCtA-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 59B18185A78B for ; Fri, 7 Jul 2023 18:01:24 +0000 (UTC) Received: from toolbox.redhat.com (unknown [10.22.32.77]) by smtp.corp.redhat.com (Postfix) with ESMTP id 38EDFC09A09 for ; Fri, 7 Jul 2023 18:01:24 +0000 (UTC) From: Yaakov Selkowitz To: libabigail@sourceware.org Subject: [PATCH] Fix fedabipkgdiff configure check for Python 3.12 Date: Fri, 7 Jul 2023 14:01:12 -0400 Message-ID: <20230707180121.3101370-1-yselkowi@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-Spam-Status: No, score=-9.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: importlib is the Python 3 replacement to imp, which was deprecated in Python 3.4 and removed in 3.12. * configure.ac (REQUIRED_PYTHON_MODULES_FOR_FEDABIPKGDIFF): Test for importlib.machinery instead of imp with python3. Signed-off-by: Yaakov Selkowitz --- configure.ac | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index b4e7e38e..b3f97ba2 100644 --- a/configure.ac +++ b/configure.ac @@ -739,13 +739,15 @@ if test x$CHECK_DEPS_FOR_FEDABIPKGDIFF = xyes; then # urllib.parse. Oh well. if test x$PYTHON = xpython3; then URLPARSE_MODULE=urllib.parse + IMPORT_MODULE=importlib.machinery else URLPARSE_MODULE=urlparse + IMPORT_MODULE=imp fi REQUIRED_PYTHON_MODULES_FOR_FEDABIPKGDIFF="\ argparse logging os re subprocess sys $URLPARSE_MODULE \ - xdg koji mock rpm imp tempfile mimetypes shutil six" + xdg koji mock rpm $IMPORT_MODULE tempfile mimetypes shutil six" AX_CHECK_PYTHON_MODULES([$REQUIRED_PYTHON_MODULES_FOR_FEDABIPKGDIFF], [$PYTHON], -- 2.41.0