From: Giuliano Procida <gprocida@google.com>
To: libabigail@sourceware.org
Cc: dodji@seketeli.org, kernel-team@android.com, gprocida@google.com,
maennich@google.com, sidnayyar@google.com, vvvvvv@google.com,
Ilya Biryukov <ibiryukov@google.com>
Subject: [PATCH] operator!= fixes for C++-20
Date: Thu, 31 Aug 2023 16:59:15 +0100 [thread overview]
Message-ID: <20230831155915.573382-1-gprocida@google.com> (raw)
Without these changes, more recent versions of Clang will start to
emit diagnostics:
src/abg-ir.cc:15407:13: error: member 'operator!=' found in multiple base classes of different types
15407 | return *l == *r;
| ^
src/abg-ir.cc:14123:12: note: member found by ambiguous name lookup
14123 | type_base::operator!=(const type_base& other) const
| ^
src/abg-ir.cc:5162:12: note: member found by ambiguous name lookup
5162 | decl_base::operator!=(const decl_base& other) const
| ^
This fix was contributed by Ilya Biryukov.
* include/abg-ir.h
(qualified_typedef): Add definition of operator!=.
(pointer_type_def): Likewise.
(reference_type_def): Likewise.
(class_or_union): Likewise.
Reported-by: Ilya Biryukov <ibiryukov@google.com>
Signed-off-by: Giuliano Procida <gprocida@google.com>
---
include/abg-ir.h | 20 ++++++++++++++++++++
1 file changed, 20 insertions(+)
diff --git a/include/abg-ir.h b/include/abg-ir.h
index 85c14266..e6728112 100644
--- a/include/abg-ir.h
+++ b/include/abg-ir.h
@@ -2252,6 +2252,11 @@ public:
virtual bool
operator==(const qualified_type_def&) const;
+ virtual bool
+ operator!=(const qualified_type_def& other) const {
+ return !(*this == other);
+ }
+
CV
get_cv_quals() const;
@@ -2354,6 +2359,11 @@ public:
bool
operator==(const pointer_type_def&) const;
+ bool
+ operator!=(const pointer_type_def& other) const {
+ return !(*this == other);
+ }
+
const type_base_sptr
get_pointed_to_type() const;
@@ -2418,6 +2428,11 @@ public:
bool
operator==(const reference_type_def&) const;
+ bool
+ operator!=(const reference_type_def& other) const {
+ return !(*this == other);
+ }
+
type_base_sptr
get_pointed_to_type() const;
@@ -4092,6 +4107,11 @@ public:
virtual bool
operator==(const class_or_union&) const;
+ virtual bool
+ operator !=(const class_or_union& other) const {
+ return !(*this == other);
+ }
+
virtual bool
traverse(ir_node_visitor& v);
--
2.42.0.rc2.253.gd59a3bf2b4-goog
next reply other threads:[~2023-08-31 15:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-31 15:59 Giuliano Procida [this message]
2023-09-07 13:31 ` Dodji Seketeli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230831155915.573382-1-gprocida@google.com \
--to=gprocida@google.com \
--cc=dodji@seketeli.org \
--cc=ibiryukov@google.com \
--cc=kernel-team@android.com \
--cc=libabigail@sourceware.org \
--cc=maennich@google.com \
--cc=sidnayyar@google.com \
--cc=vvvvvv@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).