From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::228]) by sourceware.org (Postfix) with ESMTPS id 9603C384A438 for ; Tue, 16 Jul 2024 14:55:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9603C384A438 Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=seketeli.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 9603C384A438 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:4b98:dc4:8::228 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1721141747; cv=none; b=H2L5oM1m6kOI4RbjwDOxfemaxAjY+FCG+O6IdJRYxceJLJsn+AtZLiALBkImDAq2cP/+oawy4ds8IYs1Og9rdC5eBpnqYCj7VwibkaesOMYjo8NrCc94swMrmmVcQG8Ym7Yzszv5zCN+Kvam5DRNEUUX0jZjRmie9mE2tMprW9w= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1721141747; c=relaxed/simple; bh=ie7g+mxhK1j2rAk1ixtQOlDlel0guFUMhTxd8r6C1Iw=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=cllIcmeqgthqtRw64EvNrltI+L0tzj1wGidgQx0B/TechmzWDGjNaHGVZbE4krhPIs15pYehdB8IC63Uavb7MvqBDUGbPR0xyZFi1uvd09rJ1YwMPgOWPED7hvc3bGWc7u5biS1GrsxS7IQy1/nAliXQdLlutgMG9IC8LdTa9TU= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail.gandi.net (Postfix) with ESMTPSA id 1E6C31BF207; Tue, 16 Jul 2024 14:55:41 +0000 (UTC) Received: by localhost (Postfix, from userid 1000) id 345DDC1B76BB; Tue, 16 Jul 2024 16:55:41 +0200 (CEST) From: dodji@redhat.com To: libabigail@sourceware.org Cc: dodji@redhat.com Subject: [PATCH 01/17] ir: Fix a potential crash in canonicalize_types Date: Tue, 16 Jul 2024 16:55:12 +0200 Message-ID: <20240716145541.473065-2-dodji@redhat.com> X-Mailer: git-send-email 2.43.5 In-Reply-To: <20240716145541.473065-1-dodji@redhat.com> References: <20240716145541.473065-1-dodji@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-GND-Sasl: dodj@seketeli.org X-Spam-Status: No, score=-11.4 required=5.0 tests=BAYES_00,GIT_PATCH_0,HEADER_FROM_DIFFERENT_DOMAINS,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: From: Dodji Seketeli I noticed crashes in canonicalize_types when it deals with nullptr types. Fixed thus. * src/abg-ir-priv.h (canonicalize_types): Avoid crashing when de-referencing an iterator to a nullptr type. Signed-off-by: Dodji Seketeli --- src/abg-ir-priv.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/abg-ir-priv.h b/src/abg-ir-priv.h index 78a05e72..a9002561 100644 --- a/src/abg-ir-priv.h +++ b/src/abg-ir-priv.h @@ -1620,7 +1620,7 @@ canonicalize_types(const input_iterator& begin, // First, let's compute the canonical type of this type. for (t = begin,i = 0; t != end; ++t, ++i) { - if (deref(t)->get_environment().priv_->do_log()) + if (deref(t) && deref(t)->get_environment().priv_->do_log()) std::cerr << "#" << std::dec << i << " "; canonicalize(deref(t)); -- 2.43.5