From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by sourceware.org (Postfix) with ESMTPS id 5C4CE3858D28 for ; Fri, 1 Jul 2022 16:09:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5C4CE3858D28 Received: from pps.filterd (m0246630.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 261G2upF002374; Fri, 1 Jul 2022 16:08:59 GMT Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta03.appoci.oracle.com [130.35.103.27]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3gwrscq9a3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 01 Jul 2022 16:08:59 +0000 Received: from pps.filterd (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (8.16.1.2/8.16.1.2) with SMTP id 261G5ExH027970; Fri, 1 Jul 2022 16:08:59 GMT Received: from nam10-bn7-obe.outbound.protection.outlook.com (mail-bn7nam10lp2106.outbound.protection.outlook.com [104.47.70.106]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com with ESMTP id 3gwrtat7e5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 01 Jul 2022 16:08:58 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=J91faajTK9GVDJ0xsAlr4tNP55V62JO4+Sbpxj4+NRm1Bn5Y2U1mqBAkc00a2E55EQjlf33tLul+t3UEYR8TyPN8iCSAkLgs9P2AYAzy2mtKxkuBRxEIbJ+4BlPgv4YU1/sEdajpJqYeRG/+fhFi4caXPhcxcu6rSIifmfrmB9sr8n6EobjwPVZH1q2melNqbEm4y4fV5PTeFA3lCVWRzoyNOTqbDKIdBFHLbGj4qpsXLlILJTUu9W9yE7BnR5hWIfux1aVisDiYp+Hm9k9CGT4LTa/hd/q9lHQbKBtGOC346bTHR7rdkkiQb6wFjEPoAZb60BjDwiNjS5iFdqSzpg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=O8P1I3zLqu1ezd+UZkmcV/oeD6H3CLc7UYxiPP05RXw=; b=eu6A95eobxMKF4FLtlxY4KTz6TJ7kGXb9nJKnFwv5aGmD34FJKZDYu/myj4UxnoMPd+GIsI023jaMFJR/1S8zO/OeeNsPzZ+aQ5xVNl+Ti+38amGqxUGUfmQzyZNrvrJsz6DjH+RerZywk+U16nMp6WFmqb+BI4s7hrJekMWjCwHQ7OZy2On7HG3MVxedQs5W5sxxZ+JCs27o4ZmquE6jguKlXtPUuzOpV8BWhjvchftQC0GZmUtuBqWCRIrSLpT8VcScYnzm3x1f5HexmIhfrO7XKu/kOW+u6LNxrcqLk3zmj+HxwlmhEZk2rZIs9SwtNmMJ8qHwdW36feL1mRbew== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none Received: from MWHPR10MB1407.namprd10.prod.outlook.com (2603:10b6:300:23::20) by BYAPR10MB2712.namprd10.prod.outlook.com (2603:10b6:a02:b3::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.14; Fri, 1 Jul 2022 16:08:57 +0000 Received: from MWHPR10MB1407.namprd10.prod.outlook.com ([fe80::40f0:f59d:aca7:92ea]) by MWHPR10MB1407.namprd10.prod.outlook.com ([fe80::40f0:f59d:aca7:92ea%3]) with mapi id 15.20.5395.015; Fri, 1 Jul 2022 16:08:57 +0000 From: "Guillermo E. Martinez" To: "Guillermo E. Martinez via Libabigail" , Dodji Seketeli Subject: Re: [PATCH] Add regression tests for abipkgdiff using ctf info Date: Fri, 01 Jul 2022 11:08:52 -0500 Message-ID: <21542305.EfDdHjke4D@sali> Organization: Oracle Corp In-Reply-To: <87ilogdhgp.fsf@seketeli.org> References: <20220623151642.1904752-1-guillermo.e.martinez@oracle.com> <87ilogdhgp.fsf@seketeli.org> Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" X-ClientProxiedBy: SA1PR05CA0023.namprd05.prod.outlook.com (2603:10b6:806:2d2::17) To MWHPR10MB1407.namprd10.prod.outlook.com (2603:10b6:300:23::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 59bcf5fe-d108-4da7-6c60-08da5b7c008a X-MS-TrafficTypeDiagnostic: BYAPR10MB2712:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: yIgEOKvHst2/Dy5H/K7pbdjt0AVOy/AgnO0ELdr5mE9tg+rTXhbtSM5/vwFL6tJbLFelagnI3Af21A/VSIt5auqt+CKJIOQ1ReCq68ujvbzoWipF+p9zzlQjpEABQdxpI3hdhjcCLj7SmDn42/7SMz7ZiDdgYgLf25+wZk+pnZ5STcV1CuRqoPFHRvJ+BRM0/6ieDPxbDquomsM1mgbk9QMt1p6wOinCmz5QsI4IhLnbr39F5/7kxmtlR71dKWDVHh/oDgdSeWWOXh0U8ljRiTw2mbUK3MBYjGW/oOtLcI1nVTomlhbP/FFcJig07fhYWKCvYjdUS1qPdH7srcWj3QVh3/6cflLdTol571MxtG/D7Rw1MTVoWLi3HNH/1DDnUoZPbZmlKeWsTLcMb9qP4/waQxe1IpVoqpsv8fPYeSUGP8eotGt+KpUzY8kYqzstR1XdYLJH/8+G88fND5ArAQKnH9S5V5ttK8yf3tF2wiVhQBkcWWShFfn+95NqNzCdblcIquLMMJ6QwtZpYTlpH0vcunR0E5mk2GA85K5U9Gdcn4fixWIKFOFnKKlh/G9hSXuW709B1pGWnT/xj1z/ZPS3yj5s5p9hVPW9HvaPLK3EukhBLOvcnNbgZplyUuNAjllTr784ujx/pDL26C9lFOzk2Er7atiwPkkWnakTUePfNy8opG01F7QqgH0xX85n5B30r/9Fi4kIryZvVu5NHmkuT+ePL++0suz2Zi9dgKG0qQZy348isSpHnlS0+d7g7I8ZhzJ19PzEj9WZiRMT3Ew9/ePHjnxQYGhuImgIAID/qbreIt8gyLynbafuS7cG X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR10MB1407.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(7916004)(346002)(366004)(136003)(376002)(39860400002)(396003)(478600001)(36916002)(52116002)(316002)(6666004)(86362001)(41300700001)(186003)(6486002)(5660300002)(53546011)(110136005)(66946007)(33716001)(83380400001)(2906002)(66556008)(8936002)(9686003)(6512007)(6506007)(8676002)(38100700002)(66476007)(39026012); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?LAbTB4Z/QVIl/FyAtE+x2ke8/861D9TOaS8HDgicLbcuI3vBeg4r1ApVE+?= =?iso-8859-1?Q?I8YM9M53WErDmTu2FEn3H9mxZoKnAHYR3zkhF/3sIEqtLgXkaiKpM7o5Yb?= =?iso-8859-1?Q?bXDnZ3rII3ECne/fXdW6s4w8r8fLeDt7xStC2862/vvfR6jqZVVVwe6KSX?= =?iso-8859-1?Q?BUOEiNJraMg3bkcfp+YP3VqQhzciSzKdG2Dwc1y62EgXkfH/Nah4VEBx/7?= =?iso-8859-1?Q?4UMwQX7LJ1kll3jYUttk8PNEgOJWk9GYLMcPHbHQ09Q5TA4TBqCWpBcdwf?= =?iso-8859-1?Q?wb1u5xRsnw4QqeS4SMrcCZwvThaieQUDCH2P5PS/LaXp6/o3vgoK8xDUte?= =?iso-8859-1?Q?1VkxvLWHUuIyTlyhFa90j6Iw2ZM30fy7swN2HDRNAauibNbgQTTDnipcTK?= =?iso-8859-1?Q?9CdCeZZE0cg03XWvjC/S6Wg95a3iAzlc1Z8f/BKxpVCg6L6KfqPx+Shj59?= =?iso-8859-1?Q?AXi6yfRLDHzCQUq9AM9h0ecxULEy5j/CFHv/1k+34g5qeCupLyqLKe7kwi?= =?iso-8859-1?Q?Oc4lPGW8e1dKZxHc5uOLeWKGMK8xL2TebXwsGi3bLPvR6x+IzEhsEBDYFH?= =?iso-8859-1?Q?4+xmXI4l2pU8GYkfARCuuZ3QJRCeIMIEuAZ60PYzZvokCx8mtzJvvaC5N3?= =?iso-8859-1?Q?n0l5ev3JToOEDoVFpp4/ZKkGPPF/zutRk0qmW++3HOzPJ2rN6Q1p28EB5C?= =?iso-8859-1?Q?Nn9cqGqKqFEUZZ2w9+w01X7ARp67gCAQBEwjxt/tTcPLJLi5IEH829MGLL?= =?iso-8859-1?Q?1rBYfqwKiVLnFlCHghe/QWm1XC8BNOaZCtP6yVU0hMiKND/YmvtkbA8a2q?= =?iso-8859-1?Q?Cd0pXPZsTECcemNldAuP+8fWmmM9QTs/MPQ/6kOlKX0s6PXd1Xy1y6w2XU?= =?iso-8859-1?Q?OavRlelQFjfmHZn1tB10xjqTxIyBjWI3/UjowWiuk2D+l5Ne0UEStaObDc?= =?iso-8859-1?Q?Y7fMwVYZYS30663sn61c3R3IgloP4JsCGBpchJc/fwwRsQ6FykGy75uvJ5?= =?iso-8859-1?Q?m1znTjt7KvmQFfDckoRimXI47v01Ege++LmWwO+XFk9I1JmxCI/UYL/04Y?= =?iso-8859-1?Q?eCVpy/0F22IzdezueM9vMStgvZO5IIBvsVAuR+mApZ1ynJ/c+FpWAHnAtS?= =?iso-8859-1?Q?UPPU9HoZ6ZA1jvTLRqD50JXsf722j5Slf0QWdZerzsHCord0AWJ4DERhRR?= =?iso-8859-1?Q?3UplFVTUmuZGgO6pSh7P1nui6od2xRevwLNp34ASDdh/7yshdlywYXwHrm?= =?iso-8859-1?Q?xsQmaDcEcf3Ila4UTTzMQ0+AWpU6Jn5YuwYkgU1TB8cXqca93l2A7RAn2H?= =?iso-8859-1?Q?M6GjvBy3YD2IfDzB/QxC/QMXEVrVK36RfKVn4DWyK/wIi/0OvoVliZ+r3q?= =?iso-8859-1?Q?V+tqW/1LXyEzkv8KgaXVxx1059EvifmPLbiXNUKhF115Q2qgNLvS8GEq0j?= =?iso-8859-1?Q?e2TXRARheFE2Fi43MtYPgpSJiiL61nfxubk/6V6NWsYqcUcc2AY8JbnJif?= =?iso-8859-1?Q?gLRbAefh2EIxoOkt3oRIs2Fx4xt3CwJ4EHdL5FEtcIH6W6l07ZFYRBtXjj?= =?iso-8859-1?Q?HFNcnAj6XfzCmvP99jIO35vtfhAjHDRG0i8QDup0EPJ3gQuYAowwFX5XVB?= =?iso-8859-1?Q?d9fx3+ok/SsWlGpo6T29OyTotIdjbtvjS587w+UXtTxQ9g4pBjwHNu4gl2?= =?iso-8859-1?Q?N4U/hp9RbIDtwUnY7ZtguF84Jnh3jnSZE2FR6hJp?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 59bcf5fe-d108-4da7-6c60-08da5b7c008a X-MS-Exchange-CrossTenant-AuthSource: MWHPR10MB1407.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Jul 2022 16:08:57.3396 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 9NdDixH6bVc8TQ0yo2zJf+O+3FqNjIhih0u596/ufSIJpMggMvzRtBkf8C99yxKNwoH7q8nnPLRSV/WrxyYUdL8RJb/GGYvKIZnnwMNL+Ts= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR10MB2712 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.517, 18.0.883 definitions=2022-07-01_08:2022-06-28, 2022-07-01 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 suspectscore=0 mlxscore=0 phishscore=0 malwarescore=0 adultscore=0 spamscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2204290000 definitions=main-2207010064 X-Proofpoint-ORIG-GUID: yOwP4RM4ngElK_zJisWMZqPFJvZT8nmg X-Proofpoint-GUID: yOwP4RM4ngElK_zJisWMZqPFJvZT8nmg X-Spam-Status: No, score=-6.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Jul 2022 16:09:05 -0000 On Friday, July 1, 2022 9:40:22 AM CDT Dodji Seketeli wrote: > Hello Guillermo, Hello Dodji, > "Guillermo E. Martinez via Libabigail" a > =E9crit: >=20 > Thank you for working on this. It's appreciated. Thanks,=20 > I have a question however. >=20 > [...] >=20 > > This patch implements the regression tests for abipkgdiff tool to help > > process packages win ctf debug information. Since the code shares > > lots of functionalities already used with abipkgdiff in comparing > > packages with dwarf info, a library was built. >=20 > I am wondering ... >=20 > [...] >=20 > > * tests/test-diff-pkg-ctf.cc: Testsuite for abipkgdiff --ctf. >=20 > Why come up with a something else but test-diff-pkg.cc just to test RPMs > using abipkgdiff --ctf? Actually that was my first approach, but looking inside of the acts to perf= orm the abipkgdiff DWARFs test, the steps could be changed in the feature (new steps in `perform' member function applied to DWARFs not applicable to= CTF), so it was my motivation to split the tests. But of course these are my thoughts, and I will follow you advices because you have much more experience. So what do you think, worth split the tests for DWARF and CTF? > I mean, can't we just use test-diff-pkg.cc and fill in entries made of > instances of struct InOutSpec with InOutSpec::prog_option filled in with > a string prefixed by " --ctf " ? >=20 > Of course, those ctf-related entries would be guarded by #ifdef WITH_CTF > or the like. >=20 >=20 > Wouldn't that work and be simpler? For the current implementation, absolutely.=20 > [...] Regards, guillermo