From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by sourceware.org (Postfix) with ESMTPS id F19D93856DF0 for ; Fri, 29 Apr 2022 13:50:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org F19D93856DF0 Received: from pps.filterd (m0246627.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 23TB1uT7015535; Fri, 29 Apr 2022 13:50:39 GMT Received: from iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta01.appoci.oracle.com [130.35.100.223]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3fmb9axs6t-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 29 Apr 2022 13:50:39 +0000 Received: from pps.filterd (iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (8.16.1.2/8.16.1.2) with SMTP id 23TDUrOS004107; Fri, 29 Apr 2022 13:50:37 GMT Received: from nam04-mw2-obe.outbound.protection.outlook.com (mail-mw2nam08lp2171.outbound.protection.outlook.com [104.47.73.171]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com with ESMTP id 3fp5yq758f-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 29 Apr 2022 13:50:37 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=H/ouQuS5PiwPDXLZwY1UlNsI/0bEe/5rZuAQU3lqhVEsHznmkiG4nS750OVAoEE13UhOrG3iOQHQgPauWyoKAHAZ4iL8rix9kVCEEKTk7757PiyMGHi26eQ5c4eWvlYdHf+eiuLlWUkgmkh5l2bSS+gT2H3lp0c3XQjv46h0vT0uTLjGXZD+cLZC+/Ofv2SRrhKC+x068CfWREdSDDYNCFvs8kUazkAjDVLeTSkCVgOBzsjc53H9zxZzHy1d3P529pg46iCJB00TgCNh21hnnrcEOPRcuuEab8iGejvuSVsv9hnuhTcYnBV9cuG3hAFGTevPwyIXBwTxDjenpNCiww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BkuEgN0zWuQbFKV7DZhwh8h9L5qbLidAtkmM+CRgx40=; b=kF0fAX5EpiUK5lERONexdVrlHWVD3brSu6zGshfB6YyqXBeCMDRwyZY0xSrSd3yix8N/AljZ7XiU+1vMVhpyOV7k4ZwGLOxyEap4dIhd9n9YIha8IpZb7wKkoEivTOe9tNATkl7GgsmLNKLKy1uIMtlGp4DSCp0SGyvf/Vuy5/GNu3wk6OjX/Z+xmeskRQ9klDmp4P6ibUbnNKU/uCcq6U51UUIIsCw6JAVzCDE63pdbMRn80+iImcL18IbgK8JEE2HJj00+4a0XaFVDFf0Fp9r1nd8czzet0MMiFaM581k2wQqNu55ablX80bf9D/oIE1POO5ivRe6D6LyDlvL9UQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none Received: from MWHPR10MB1407.namprd10.prod.outlook.com (2603:10b6:300:23::20) by CY4PR10MB1765.namprd10.prod.outlook.com (2603:10b6:910:e::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.15; Fri, 29 Apr 2022 13:50:35 +0000 Received: from MWHPR10MB1407.namprd10.prod.outlook.com ([fe80::107d:de35:fa5f:3cc0]) by MWHPR10MB1407.namprd10.prod.outlook.com ([fe80::107d:de35:fa5f:3cc0%7]) with mapi id 15.20.5206.014; Fri, 29 Apr 2022 13:50:35 +0000 From: "Guillermo E. Martinez" To: "Guillermo E. Martinez via Libabigail" , Dodji Seketeli Subject: Re: [PATCH v2] ctf-reader: Add support to undefined forward declaration types Date: Fri, 29 Apr 2022 08:50:31 -0500 Message-ID: <2181323.iZASKD2KPV@sali> Organization: Oracle Corp In-Reply-To: <87wnf8f97s.fsf@seketeli.org> References: <20211212041452.380448-1-guillermo.e.martinez@oracle.com> <20220318013036.2306102-1-guillermo.e.martinez@oracle.com> <87wnf8f97s.fsf@seketeli.org> Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" X-ClientProxiedBy: SN6PR04CA0083.namprd04.prod.outlook.com (2603:10b6:805:f2::24) To MWHPR10MB1407.namprd10.prod.outlook.com (2603:10b6:300:23::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6d1cdbda-33ba-4b33-548d-08da29e73c0a X-MS-TrafficTypeDiagnostic: CY4PR10MB1765:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: MNcKZ22pneK59goQPjisevY5qonQI66xmnl3Tp9ye8kNqCT139TU9WE+X7sA28GQ/FbMsZWLFYmVsuCdirohbXbSyCLMJYc0jvNfVP8CJPz5IRHMwDpqSRZRrCqdkSO/gr6i2XiQoVcemxPmgSUJA52xPnzYe0XsWm1e5PwRt3Ha+p6D3J4CR75n/UL3EnulO8HKpN7TiIp7vvvfWes8w9p+i5no2mD0ZurL2vtfaToKJBx35p6jp9XRuwKK/3AO0+y6+IQudMn2gYHFHI0A8jfpFhQQz2v+Tptlf053ix2FkiCRP3+SCq11u5Of7/gwSuL1Ev7PQlueDNtSCbdiXi+6k/t7hjBtKOE3EJo4i3CQXJw19EN3NSWeq1nB17dJFF9vGEJxEy1SYSPN/Dp27ObXgBfTz4p95fnV7ilVEV9giaIUd9fFVycKcmY0kBP6BCTeC69M1w8yISJfkRPZXGp0MeNIH7vA3Ouzp9wxvusdZ/yx2/vmX1QKZkPXXtFe7gtrCQI7NZ/4W43XEkdZ3CC5kRjYf9qeHEbWodN0Xqh2OJ7acarhSM7Z9sexc7jjrGrNpXOzcM1MxgoK9YOWsnc41F6Z77p9bzUNBbY0R7vLKD8PD3npNlprVYHASn7PzsM0aF4fvCGp3AWyW5W4HmFEznzAbq4DC8J0AgxOnXZpGCm26cIM1S17duWRCM6QcMyGzfBzYTfRvq4sXHxBH7DI6BYoBjeENtRRXtE82vg= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR10MB1407.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(7916004)(366004)(83380400001)(86362001)(9686003)(6666004)(6506007)(6512007)(26005)(186003)(8936002)(66476007)(66556008)(8676002)(38100700002)(33716001)(53546011)(52116002)(38350700002)(5660300002)(36916002)(2906002)(66946007)(110136005)(6486002)(508600001)(316002)(39026012); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?Gll4Nv9tznBDpgfX7Cma5Mf+kHq6kChYuZ4/mg2K1E22qGJG9IQ0mSqew0?= =?iso-8859-1?Q?0jJHj376t1IYnglh4Ic9DYwwgh5QZgzvizZzB3iqyzbgrSJmCZCemCxhvb?= =?iso-8859-1?Q?WauYJteHEUnWsRhwnnl7F/WlD2TrPww5iYIvB/pqDHJGPQoSv1f3Mp01q6?= =?iso-8859-1?Q?GUWi3fu96HiVkht0dEzdFnA4JpV0YgmedC+TLdM9jxgAvuuc4tWyilJQRu?= =?iso-8859-1?Q?8uLj9f1Lnws1ExOk+qZg6GxEGLfiTi0zoECS6r2FugTTNZ0Cq+856XPOXk?= =?iso-8859-1?Q?CFngDskLQSmrbRHF0DJBzPm9Slb7b1mD6yN1mEXhwizhyGkxp8eRG79JAX?= =?iso-8859-1?Q?oJ9+gaW51PyfLkPLpVTR03Aw0R44Lh9BIkNUXOFlyYNjuc9j51iSfpPC4G?= =?iso-8859-1?Q?+xer1pv9a9a/NS6ZeKpMIR8HUfQAPaB15o3F7lMkqz+bYBgvL/mynqm2ys?= =?iso-8859-1?Q?kuLxa38iP13xg+95e+QS56euv7dbiC5tK+nYw5MmweGhUsMEvmDzrpsLn+?= =?iso-8859-1?Q?rWsJjY+T1LHJ13YwiFQn1k0631qee0K7T9X+P4qQaI4ViQEiyp/2TGkRBh?= =?iso-8859-1?Q?PH8q6ay3TgoNgi7UYLUKF56Rdov6b2JiXVa4kGA7C8Wb1L2ZKVp8lcHCPr?= =?iso-8859-1?Q?8z7b21X3nYJYlBc+IPsOKNnYSe3zd7QLLFRsbhMDjv638WfyiHjD7B/50Q?= =?iso-8859-1?Q?OaKXZ4ZOfjKnNzrtBjf8H6GsOAdf6sMw2014ot6rmT8tATuXogGtAt/JwO?= =?iso-8859-1?Q?dRBp0xghgGzs1lJibvML0MAjaD7xA703oTqmZVNmLt2nfTM+d2aGAIplEc?= =?iso-8859-1?Q?md88KznRb3cN2K5Sw+tfsNjnqiy5ZdiwcSb5A5JRg4ktJ0slChLkdvWYDm?= =?iso-8859-1?Q?0bf8WYBR1nB3UUUpgEKgbb2sdINyW8aL9sb1V1zwXJ2mr5ro78fyW/1VJD?= =?iso-8859-1?Q?S5dSOQSsdITMISzfLoq5Y9becNJvHQPjaYZw/BsaC/hw8H3N03wlRfZs49?= =?iso-8859-1?Q?hPAqaeBSktyqnmO23VCWSlez4MOj6jTRFP7VQa7aff9s7dg7IafzNnd5vj?= =?iso-8859-1?Q?u3NtLO/S3QZkjVM7Bo7xymVAAZN5Csu6nEfrpMqMC4nyMi58Fcn12O9Y4j?= =?iso-8859-1?Q?dvZYj9bwxRKTc84q0GVsVFuJ2VNhjNAqxMOJMYrKopMXErU7poArDOZ/Fm?= =?iso-8859-1?Q?23dA6DLGGXplbJFMRoU9rgDuyM16jXPamQSv5tQuQedk0rgFWPfPK2Hfyh?= =?iso-8859-1?Q?t9wEsY39xoKd6ci+cBZfakJ8U9CpcVo2LFlHDelnrOm/gK/kD8YrlaR562?= =?iso-8859-1?Q?OqhH2XPtuZSx0b0NSlILC4ofJ7r3OwJmmMSExsS7F80LtnhQKVSq2J2fCK?= =?iso-8859-1?Q?X7/xBjYk5QaHkZU8XgTkLpb5clJXWnXznHvLPuaz4EgVO4bi75fW/t/51K?= =?iso-8859-1?Q?ufUrUVKGxJQ9mCniJIEjVHPU77Z6es5A+jUDC622085xT35HtJD9sg8yTM?= =?iso-8859-1?Q?qg3zWXyBSL9mREPQRhiED9Nozij8q0E0/Wx20c6AS4hEXUmN88JUWbw5KO?= =?iso-8859-1?Q?7bNZobma8093MlXiMtj0igdkbXHXhASualufeLTnvk+cG6JqW6ZkFiX6R2?= =?iso-8859-1?Q?f4jcBzESD7XFoV0mPShvZEAbxJkFH2Cy10ClPL2Vxy2H4ZmD6ZpMrPHkb8?= =?iso-8859-1?Q?ZdjEbTmVUAJCSCPlW8eNqd2QsGup4WpxC+kwgiozMHPsPtTklhhxD3eujN?= =?iso-8859-1?Q?zvR5Bu9GqUqD5bahRABuLlAGg/zHwhRHqJ2C49hX1lpti9jFbIHoykftgg?= =?iso-8859-1?Q?GpXi8XXlzKCobFkCCo/gYqcwo1pMhDwNK9TgH+ho+0LupP3q0TmG?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6d1cdbda-33ba-4b33-548d-08da29e73c0a X-MS-Exchange-CrossTenant-AuthSource: MWHPR10MB1407.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Apr 2022 13:50:35.0184 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: wA+V7cNjuynwsyaH8uNwioib4n31CSGrLNbBgw8gfp573hSUUU2pU3DjiZ50Zra522GLdezY70JbgoBhDs97ADhZ7XTmhT3XEj36ZK84FKM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR10MB1765 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.486, 18.0.858 definitions=2022-04-29_04:2022-04-28, 2022-04-29 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 mlxlogscore=999 mlxscore=0 suspectscore=0 malwarescore=0 spamscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000 definitions=main-2204290078 X-Proofpoint-ORIG-GUID: GGggxteJrIbPWXNasNt47tk4HycZZFQV X-Proofpoint-GUID: GGggxteJrIbPWXNasNt47tk4HycZZFQV X-Spam-Status: No, score=-6.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Apr 2022 13:50:44 -0000 On Friday, April 29, 2022 5:57:27 AM CDT Dodji Seketeli wrote: > Hello, Hello Dodji, > "Guillermo E. Martinez via Libabigail" a > =E9crit: >=20 > [...] >=20 > > +static type_base_sptr > > +process_ctf_forward_type(read_context *ctxt, > > + corpus_sptr corp, > > + translation_unit_sptr tunit, > > + ctf_dict_t *ctf_dictionary, > > + ctf_id_t ctf_type) >=20 > This function lacks a doxgen comment. I have added it. Thanks > Also, the 'corp' parameter is not used in the body of the function. So > I have removed it. great > [...] >=20 > > /// Build and return a struct type libabigail IR. > > /// > > /// @param ctxt the read context. > > @@ -813,6 +860,12 @@ process_ctf_type(read_context *ctxt, > > result =3D is_type(struct_decl); > > break; > > } > > + case CTF_K_FORWARD: > > + { > > + result =3D process_ctf_forward_type(ctxt, corp, tunit, ctf_dic= tionary, > > + ctf_type); >=20 > I have updated this call to remove the "corp" parameter as it's not > there anymore. > > + } > > + break; > > case CTF_K_UNION: > > { >=20 > [...] >=20 > > * src/abg-ctf-reader.cc (process_ctf_forward_type): New > > function. > > (process_ctf_type): New CTF_K_FORWARD case. > > * tests/data/test-read-ctf/test-forward-undefine-type-decl.c: > > New testcase. > > * tests/data/test-read-ctf/test-forward-undefine-type-decl.abi: > > New expected result. > > * tests/data/test-read-ctf/test-forward-undefine-type-decl.o > > New test input. > > * tests/test-read-ctf.cc: Add new testcase to test harness. > > * tests/data/Makefile.am: Add new test input files to test harness. > > > > Signed-off-by: Guillermo E. Martinez >=20 > Applying this to master, thanks! Thanks!! :-) > Cheers, guillermo=20