From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by sourceware.org (Postfix) with ESMTPS id 64C553857407 for ; Mon, 16 May 2022 22:21:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 64C553857407 Received: from pps.filterd (m0246617.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 24GKb2Jw009397; Mon, 16 May 2022 22:21:12 GMT Received: from phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta02.appoci.oracle.com [147.154.114.232]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3g24ytmmbx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 16 May 2022 22:21:12 +0000 Received: from pps.filterd (phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (8.16.1.2/8.16.1.2) with SMTP id 24GMFvCE000891; Mon, 16 May 2022 22:21:11 GMT Received: from nam02-bn1-obe.outbound.protection.outlook.com (mail-bn1nam07lp2044.outbound.protection.outlook.com [104.47.51.44]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com with ESMTP id 3g22v2b4ca-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 16 May 2022 22:21:11 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=L2a5xNTDVYPJFwz6k6LrnQDTiWzLNnx95dldTWOwBj4xZzJnNaROOH6r+RhLDt+/bnwc1W7lS7S9TSln6LnHaFR+6p7Z7NfIf+i0V7al+vor58sEAP01VQm+a6gxKbs+K5LVLuRY1YT+AXnByqdbNX6W4wex8KJZoB9p/cNs8lAVhzMqStQTkXQ4zz/ZjKpF7/+2tOXS0Z1pi/wYJ/3b51lk1xXL+IrakL5iDtzqbSe4YVMSpKjSlkFEVv6sQyyXUTPkB07yJuAC0qXjMltyAcXo0X28su++6xc8FJ8VvC+O092/60x0nxcBmjXbvUGYVOePJOaH3EyCcYF3EnoMtA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=T+tgbhzR/s7dm4oddReDF2rditIu3Xi6SAJfX7aTO+M=; b=S8u7aPWDNW9iA4cRiR7U9yI0B5xnnZMXuMgHV/LKSej2V36rCDyqiFeexIz6Sxyi/9Z7xL5DjG9KA2hqWCV0mz5IJ6Sl1M48pcR2sTnpGPBZsuW/00sCh4CMI2d7d5euFRQLe0DmjCwqNvmzWOQcYjZuy7BtnXKhPNjCyXAFfZlr8rKD5CBGo/U6vskzz2EKdQxnrrIdb1mtjVAG1Fg7OVNndm9/50pbkR7JYA/Q0RjID71g4i/uoN77HyffC5lvFLF0tglRRl11ycJ7pw/NfF0bZb9rnwiARul4x0k5SF5dygQjCk7EoTJPGPYeneMwm0Wc3o3sggAkHJXjso4QQw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none Received: from MWHPR10MB1407.namprd10.prod.outlook.com (2603:10b6:300:23::20) by MN2PR10MB3886.namprd10.prod.outlook.com (2603:10b6:208:1bf::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.14; Mon, 16 May 2022 22:21:09 +0000 Received: from MWHPR10MB1407.namprd10.prod.outlook.com ([fe80::c88b:fab4:f199:fc1b]) by MWHPR10MB1407.namprd10.prod.outlook.com ([fe80::c88b:fab4:f199:fc1b%4]) with mapi id 15.20.5250.018; Mon, 16 May 2022 22:21:09 +0000 From: "Guillermo E. Martinez" To: Dodji Seketeli Cc: libabigail@sourceware.org Subject: Re: [PATCH] abipkgdiff: Add support to compare packages with CTF debug format Date: Mon, 16 May 2022 17:21:06 -0500 Message-ID: <2710573.BEx9A2HvPv@sali> Organization: Oracle Corp In-Reply-To: <875ym5uo28.fsf@seketeli.org> References: <20220507020326.1417379-1-guillermo.e.martinez@oracle.com> <875ym5uo28.fsf@seketeli.org> X-ClientProxiedBy: BY3PR10CA0014.namprd10.prod.outlook.com (2603:10b6:a03:255::19) To MWHPR10MB1407.namprd10.prod.outlook.com (2603:10b6:300:23::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7413b8b6-ccd4-4fda-0de8-08da378a605c X-MS-TrafficTypeDiagnostic: MN2PR10MB3886:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: XW/FgTzxKuJx1MW7yHj19JpLcxvVtIxJ2jzBTDQG74VuX3Hn0L7aVr4204FbBrbUJALt0Zg32FJC7pyG9fekZ+SYndCg9AbKrcBJ0pDyCiG8Aend/9e+1pamk9jaAvr1T7HIeMvWpRTCsLVh4kQT7fogj+YPZpYwnEatENu/cvTPNeYPIERgrXZOvp5VOBxbyw0WsvqzBjYSejz+WYeEAzhxL/NamqUgyvFH1rnEvR4YRvzZ9Zyg15H1pe6lnjLFt8wenz66S/OueiPVu+5ptY4uWm4G3GqqoQBaG5NQD1YNpxFAECCWd30VhZ5NyxDSx01U7kJWNxCNzNEvJi1z6meRis37QdkUOkEXFRWKjPj/WTpiqzHFGPBcF7nHeqx/idi9iu1Oago6gC2Kx1qLdlit9oQzrjYlr98bIDplVUKN0Wc4IpEeugN4myJZpNa6bpLVBIweOucwyoWjdVsJ18QkFzrrzqtbNT61bQKpv8Vy3pHNFFHZM4qneYduBeRCeWwzn+sn6Ab4tyKaS7CSaLqeRm5rELrINXLUwM+VBz3GAumMKibGi8iVLRanODbWudSpNFYoBTuHd7QVhxdTpqEAm7ia/XO+B+94pNICL52kZGLFLOit9fw6wu0PP8WmS5oxnmMVVrY4T3v5We+UNkw/Qi/ABqBkhgGDlvF8bjzrjT6C+HDrcZhvPPuMagxLcYtBLDzZWXm58TgTYHxhK6Uon0bLZh0qMne6KzK0ZcLrYfAyiKx3eGcfnPp1Z3YlVox+CdqU1grhO5dCp5NZ//nokNHiGbeSkGUDNo7ReME= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR10MB1407.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(7916004)(366004)(316002)(6512007)(6666004)(166002)(6506007)(9686003)(36916002)(2906002)(52116002)(6486002)(508600001)(33716001)(8936002)(53546011)(966005)(66946007)(86362001)(66476007)(66556008)(8676002)(4326008)(21615005)(186003)(6916009)(38100700002)(5660300002)(39026012); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2 X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?wi/s2jJubMh7gF9Hlap6XmPlZwQ+c+3QJrsDl8UTzGp4nQMn97xeOYquk/?= =?iso-8859-1?Q?+o6YIiTNgpn4Q3tc07GFzLQhv8fe6riTl5rK6H2uUJGeqFBiEl4bYuB+yG?= =?iso-8859-1?Q?bW+gJdvL+aX6VVTqWSAfGQLgsk+1PD2U1w6THSvvA/Kn55pLqpkS/p5QPo?= =?iso-8859-1?Q?8ELJDK7BAIayJ3NtFy+3nRsGnQW4S0jVNwrofHj+DImswg9FUqcKf5sUsL?= =?iso-8859-1?Q?A4If5IUanrFrgaUS3pg9JbkOp8cpr22VDY1JEQUNe6Djo6pC6bwrW+M4L6?= =?iso-8859-1?Q?/O5xRHRtjd0wf8V7B9jPwQXwGxD/riJf/7sPosiupgM2yKa39Ln13CxFl8?= =?iso-8859-1?Q?rqBhW7APm11bgAfTOOa6ksgjRSGFguB2nXk1imkOmVErAqevIDPZFWiVB3?= =?iso-8859-1?Q?Ux4fziBg/eRNbbMSSZaQ8HWEfXybYGv7m+ujXbJX3hFFXNSxQkXrLRzMjb?= =?iso-8859-1?Q?nCljbWurthBdZcAx9gsLOWeOA18V0rPYnrkaH33gqP8MfPlUsn1+KkRarI?= =?iso-8859-1?Q?p7GegURyxj3toSf7m7ThkyYymOt3YbwnpkwNoJFeJwjWFWs+y2aOOCpFho?= =?iso-8859-1?Q?DIU/s+dH4pnID1GRcjhyIoFViOGvaSkpkkhK4C8at1+Z5rIZ4rRZiQ4Lmo?= =?iso-8859-1?Q?AQEpa0yaH0+CFXmb1+28dFaSM+d5jmjf2vKFS3Yji1N2fIuJIjsmrN+aWn?= =?iso-8859-1?Q?EHmyznTNlELBOZLvyi7LkcKQ+jG82WBGojxhyH69TMUdAvhHrJSitPOyzd?= =?iso-8859-1?Q?43kZJIOrtVNH2ARw3vRpD7XKvsWxVBUZhwwzfofxUAMsjzBQm+DTSfSAwt?= =?iso-8859-1?Q?S3A8M2jbg2rsCy0gOtpVeveAYTWqx181EMJQxr8Vb7GUk2Fxysy8PQ8XxX?= =?iso-8859-1?Q?QxR3/m7EKqCeVeRDlgVBtTBsxB11/iklHemfRZURy96uh0zrHDwTqZFd3R?= =?iso-8859-1?Q?P1W5Y2YOHwiYs3TOK3hX2KObu53jO7f5VG0bk38isMUvlbehPP3zTW2U4T?= =?iso-8859-1?Q?UlVuaL88Q7Rwwlw9UPj9YQ6HLF15Yjy+w3vg2LZ7UKLzRnHBzP7BZe+lgJ?= =?iso-8859-1?Q?Xd+Q0QHozH1hfwEzDIJw6iAIfOcpc3sNEBkFAuNKOPhR8aT7xgU/93wyId?= =?iso-8859-1?Q?0mc7p+E9heYJS5M0IuMXUSg17UAgXc5ZIvUmU2iF7MpqQmXJFmsV1BP4F4?= =?iso-8859-1?Q?idyb/YfVa1sipUA/p4t4KEQphykw/drM0GsGaLnUrVufhiq0o1oIXvl0QJ?= =?iso-8859-1?Q?VJqnjX2ji5VTMVANmhY3tfdh+w7Oc/E7BdB2V51s9NVu9Slv/EQclQnF5I?= =?iso-8859-1?Q?l4pJWdQM247e0XwBP64Q6QHTDVi2oGc8FM9raN0nC22TXMKzwx6CF1O8hl?= =?iso-8859-1?Q?1J/ntFmHmZ5zXdQgrxuCu/pDo9yw0T/i82Ek/raO1D/mOLIE8p4hC++JYx?= =?iso-8859-1?Q?gnhJp3D5rdZUEqUjNq4IJeNXKwc+rh/HdffYKmx5JIVWGyQ2wCn9kTIDpr?= =?iso-8859-1?Q?Po6uqkaxwNe5l5htnYye8/nk6u+7bPMAL6+Q29Ks+88rnIFHxcfSEmFR/7?= =?iso-8859-1?Q?+tzudsjUpNe/9RqlW33y1XJ4TOMhT+XBebPvLKIOFtBiN6R3yRufHepf18?= =?iso-8859-1?Q?AP2p4LVuYRm28UQCAfjqeRugqexbQISrCFjzN8EpZAHNMUOYrFsKpOqeU3?= =?iso-8859-1?Q?61fJwmEEdiAMRcgBRzHzjI832TNSNPP2h+tc38rrt514iW5WNGEc92cWuu?= =?iso-8859-1?Q?vBq1fyKq0CYR1nXcuogpNO3+8WESNoKQPAPyXoHo67gzlTP71bP2Lrk6k4?= =?iso-8859-1?Q?HWCioLvlxIkldsRPICnqf78P4IClkKCGMSVZ+g69jVlvEgsYfeesHm6trL?= =?iso-8859-1?Q?TX?= X-MS-Exchange-AntiSpam-MessageData-1: M2g3BLqvblUxfA== X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7413b8b6-ccd4-4fda-0de8-08da378a605c X-MS-Exchange-CrossTenant-AuthSource: MWHPR10MB1407.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 May 2022 22:21:09.0194 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: dCyku2x6lBXOTeuQc0KqOxebd3fionPAUcyj8jZwuA6UsVrVJBdSs9jp+1EeQu+KJISt57/+upZT9ybJLgxqVgsTrDi/WIKk4rFXk0dRP9o= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR10MB3886 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.486, 18.0.858 definitions=2022-05-16_15:2022-05-16, 2022-05-16 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 mlxlogscore=999 spamscore=0 bulkscore=0 malwarescore=0 adultscore=0 suspectscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000 definitions=main-2205160124 X-Proofpoint-GUID: byZHTUlhbd3vG55ElkjhJOjpFgWT2wMv X-Proofpoint-ORIG-GUID: byZHTUlhbd3vG55ElkjhJOjpFgWT2wMv X-Spam-Status: No, score=-6.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, HTML_MESSAGE, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 May 2022 22:21:18 -0000 On Monday, May 16, 2022 5:09:51 PM CDT Dodji Seketeli wrote: > Hello Guillermo, Hello Dodji, > "Guillermo E. Martinez via Libabigail" a > =E9crit: >=20 > I have applied the patch to master, thank you very much for it! >=20 > I have however made some little adjustments. Please read about them > below. Ok, thanks!=20 > commit a433820d809bfa134210f5647ee2d1e303d591e7 > Author: Guillermo E. Martinez > Date: Fri May 6 21:03:26 2022 -0500 >=20 > [...] >=20 > > --- a/tools/abipkgdiff.cc > > +++ b/tools/abipkgdiff.cc >=20 > [...] >=20 > > +#ifdef WITH_CTF > > + if (opts.use_ctf) > > + { > > + ctxt_ctf =3D abigail::ctf_reader::create_read_context(elf1.pat= h, > > + di_dirs1, > > + env.get()); >=20 > abigail::ctf_reader::create_read_context only takes two parameters: > elf1.path and env.get(). So I removed the di_dirs1 one. Oh, this is because there is a previous patch to use the `di_dirs1' paramet= ers: https://sourceware.org/pipermail/libabigail/2022q2/004361.html[1] my fault, for get mentioned it. > [...] >=20 >=20 > > +#ifdef WITH_CTF > > + if (opts.use_ctf) > > + { > > + ctxt_ctf =3D abigail::ctf_reader::create_read_context > > + (elf2.path, di_dirs2, env.get()); >=20 > Likewise. >=20 > > +#ifdef WITH_CTF > > + if (opts.use_ctf) > > + { > > + ctxt_ctf =3D abigail::ctf_reader::create_read_context(elf.path, > > + di_dirs, > > + env.get()); >=20 > Likewise. >=20 > [...] >=20 > =20 > > This patch add support in `abipkgdiff' to compare binaries with CTF > > debug information inside of packages, when `--ctf' option is provid= ed. > > =20 > > * tools/abipkgdiff.cc: Include `abg-ctf-reader.h'. > > (options::use_ctf): Add new data member. > > (display_usage): Add `--ctf' usage. > > (compare): Add condition to use ctf-reader to extract > > (parse_command_line): Set `options::use_ctf' when --ctf > > option is provided. > > and build CTF corpora when `options::use_ctf' is set. > > (compare_to_self): Likewise. >=20 > Do you plan on adding some regression tests for this patch? That > would be neat and useful. Yes, it will send soon :-) > > =20 > > Signed-off-by: Guillermo E. Martinez >=20 > Applied the patch below to master, thanks! Thanks! =20 > From 28a629347f598e3b5a35152538c4a4638ca3995a Mon Sep 17 00:00:00 2001 > From: "Guillermo E. Martinez" > Date: Fri, 6 May 2022 21:03:26 -0500 > Subject: [PATCH] abipkgdiff: Add support to compare packages with CTF deb= ug format >=20 > [...] =2D------- [1] https://sourceware.org/pipermail/libabigail/2022q2/004361.html