From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by sourceware.org (Postfix) with ESMTPS id 8BB953858C60 for ; Tue, 14 Dec 2021 04:24:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8BB953858C60 Received: from pps.filterd (m0246632.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 1BE1jkbW017888; Tue, 14 Dec 2021 04:24:07 GMT Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by mx0b-00069f02.pphosted.com with ESMTP id 3cx5akabgm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 14 Dec 2021 04:24:06 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 1BE4L2Vd140997; Tue, 14 Dec 2021 04:24:05 GMT Received: from nam11-bn8-obe.outbound.protection.outlook.com (mail-bn8nam11lp2175.outbound.protection.outlook.com [104.47.58.175]) by userp3020.oracle.com with ESMTP id 3cvnep8vp8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 14 Dec 2021 04:24:05 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZWgNck3rHWKRWK4I03SlU4TBfhsi7dG1oDqUweIYcAEcDnSS6HD0AOU5SLXdnqCXas3v+HehVfC5sQtoiufQCVg63z8d+yT/KMjl5RPf0fxg9BPs074L76VSOSuz/r+jmeVlRcXDTGAgrHvRnau1Idcsp2TbdKK6F80tUVzZuKzxPMdGgcEbx238dB886AbQSo8i1mMANmqtg0W2yaMk20AOs7nmSzrj4Ww08XWNPgVBS2Bn598iIMMnSyHQxqX8/ic+DfWX0Y0CVhsnlZTvpubaik/doTDA2brzxglGCjtTHeEkDIY4LTOOKpQC8Z1ZZtmDw4odCo1mzIl81THSgg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oPUFh7r7Sc23we2G0X9lpEzyH5gWqNCdszzW6Ju3ccM=; b=UjGVBf+sBmTL9Jxa/EShLNVcGotDAexxaw8sR1RP74CWeKBhgLgs2vY+Od/9ReQXJM6tzLoTRl9ZyFRYGdNYq51Zh1AyJtAPq1/rvZ6fWAsADzah94UJ4dEKdOfwpB0RAgQSc0R+NAUytiKp9dNRfAWua/XG3ehU2ORSjSuwzW0RIN3H1mGV/Y7orkmoQCjo5tXLqhLiwLYRQazO9Tt0PpqF3an5dwtgTedxjL+stecRu+o/xngHKM+1bwoJBphHDUVYeqPzFVJJbZ8W8J04eUKbvleiLa1JDLizeB8LWnF1qAogpznYHzIJBilUJnb44LMMvBUDb6729p4K8abW1Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none Received: from BL0PR10MB2852.namprd10.prod.outlook.com (2603:10b6:208:76::22) by MN2PR10MB3919.namprd10.prod.outlook.com (2603:10b6:208:1be::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.17; Tue, 14 Dec 2021 04:24:00 +0000 Received: from BL0PR10MB2852.namprd10.prod.outlook.com ([fe80::6927:5e6b:31ff:14bd]) by BL0PR10MB2852.namprd10.prod.outlook.com ([fe80::6927:5e6b:31ff:14bd%3]) with mapi id 15.20.4778.018; Tue, 14 Dec 2021 04:24:00 +0000 From: Guillermo Martinez To: "Guillermo E. Martinez via Libabigail" , Dodji Seketeli Subject: Re: [PATCH v3] Add regression tests for ctf reading Thread-Topic: [PATCH v3] Add regression tests for ctf reading Thread-Index: AQHX5mCEcPQcX4mQh0O7BoRIbALaqawwq5SzgADMfgA= Date: Tue, 14 Dec 2021 04:24:00 +0000 Message-ID: <2954198.2K3TvWQTzv@sali> References: <0211122213353.2456208-1-guillermo.e.martinez@oracle.com> <20211201030645.3804678-1-guillermo.e.martinez@oracle.com> <87ee6gqyb9.fsf@seketeli.org> In-Reply-To: <87ee6gqyb9.fsf@seketeli.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a895fa92-acb4-4913-c6ca-08d9beb98dcf x-ms-traffictypediagnostic: MN2PR10MB3919:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: QlBnP9TNNmUVveMsb+Zlzv8WflcdYR7Uno27DXZiNa2fpGyLajdiZe/XqqlwJJK4Q+JqF+ib2iL2fBe8QCOCIPjYfz9jXY6EQSH5XH9NMWZXJfOQvKy/45bQP+WkJDXyfkdzbOPduG9pgR+dVs7kdGrR1pP/me+Mf3KXZyGEayoZZgZ8jwGIuacYM5SLp4QrKGUI3v45qMEuhHkGAT7OwXrXQBKESnOJZtmDV634CP38ergfTD/NCYsbwb69DVTXsD7LH0hniL4QFypKPDk/n7hEE8DK3cSSO1jT0byvpBMlvpVijLL888VDVDgiz7VHS6J5M09a2Rx4I9r683k6wviQ+DTg17Kfv1lFp+otVufmETd+9e8256grH+vVqhEfdIqRJICWQg9H9EvCBbP9vKRVrRka9Uv46m1JXtvWczj/74UloMTtHGa2XwuXOdU6eJ0RnJqi33PXb45Kjsh/oHpFWe8lzSbQa685K5tLso/OLIatcoicg8xKrw7k9wzMt5bhJXFlPSUd6t1khUFyFM32b2b3BFdV3rhXPuUvS+VXzF37QAi/Ip28zIJs8660LoodKy0GZsHLVUtamUG4LJftdfVX1BHd5wgocAwq7+LawRW+j7R3NoLeH6ToFkNqaqxnShQBCUH7s//cZo9lyCI73fp3zwBFRK3BXOH7QI/dZzkFpL3MF+OVOm4O03FOQ7wUsugnsUiDpQCzashCTsNkBGvuH02MQ/LoYfBS28Dr7bZ7IreLUQq8dX/M9oGdVyiiN/wi3f2Mh/NZWoY9smyMwD1YDxMcEfy37xow1aOXQM7EdYil0KyJbjTs1N1k x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BL0PR10MB2852.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(7916004)(366004)(9686003)(6512007)(122000001)(38100700002)(38070700005)(316002)(71200400001)(8676002)(8936002)(83380400001)(966005)(6486002)(110136005)(5660300002)(76116006)(91956017)(66946007)(6506007)(186003)(53546011)(508600001)(66476007)(86362001)(66556008)(64756008)(66446008)(26005)(2906002)(33716001)(39026012); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?IIhWdXSDWjCXNnNQ6Qx8CvTJzoQJMh7gVIuXErkD/7MP2fn8fQ0eHvlhUn?= =?iso-8859-1?Q?yJydDrc4nWEKDruLj8dNc0DIAGdOvtjBGQrjzRfEOq9IAaMnj8jlvMejSS?= =?iso-8859-1?Q?EQlzut3K5nz/g10276e9xjFpZLbeYMhKqdy5CniQMQUSSqQkc/GY9+FSZf?= =?iso-8859-1?Q?+RqD9BgpJTXZZM+HVc1oJIIPjSfTwgrLxRLWtGiNqLoKUKEUcfTVI+9wyr?= =?iso-8859-1?Q?GG1lq1rRxPulmGh1i2FycJMCrG8y5m782DrJeVqGYFbLHFbyUNSE7KML8b?= =?iso-8859-1?Q?bxN4bepxIMCVnnYJ1TTM9WyKgJwuGdtdwDbREfozGq38S0IQshQJyXPvyc?= =?iso-8859-1?Q?UKXB0ze4BUrlyOdccg26kft9IU+SDq1nEkLSj0CVWT0BKydoyE1cW68n1Y?= =?iso-8859-1?Q?gYoLl+yx7eGhQ+nwpSTkoY367A4ki/tFpp+1Tz0ol6/xX/6yXnYRaAIPbk?= =?iso-8859-1?Q?Z2/lhNMV3w600f3XyYdN5LDRmRJh2/IiLmIy7/cF7twfnmSDfyA3hESne8?= =?iso-8859-1?Q?9CsY9mN+/2gcqEGQYWbEU9UQNyUTJvae6LOiuvXViAxbc8cdGuAVHqFmYY?= =?iso-8859-1?Q?r1dh80/I1RDO4nl1k9wHn6S0J1iBkyVtdpGNH1VZyqSZo48RRC82MBv5uN?= =?iso-8859-1?Q?+RJmSMUxmzXj49PvJHSYjtv/1bs1WlU3hnQC+60xWvU6vhGEKsUKZsxRuu?= =?iso-8859-1?Q?c0RG9kL6F3kpdg93EqClFYAA5Smixyn68nudIntjggcisQgPFL/E/63bjv?= =?iso-8859-1?Q?Wq2PnlP5jblcLmftO4aAcHCPeLIFNeokenkXDnFiwRiOT5Kq9d8NYwrmEP?= =?iso-8859-1?Q?WbYxmTKJhNVjT1dY6LcsHcj2fjHpFSM09ufioNFTj7A3G6dNR8dDYqGaaU?= =?iso-8859-1?Q?kojQ1C/wKF2QOLIxqGykUMkfTBAFwM26F7q4smEeZFPZR+/PqinCxMQJFO?= =?iso-8859-1?Q?QDiyhd4U69knIHdGElZHmjqb7/yrwvEi5CkB4bVZ5D9LLZKt8FPcFHlC6m?= =?iso-8859-1?Q?r3dvFZkwOiQLZzUCWOpae6WF3n3g33r5ZaN8T8N72fHTngpzUx/+5wY7G9?= =?iso-8859-1?Q?jn5puGSYkATqMi9CGTI4tqPiujw8XPWKjgmOcqg2GS0RXGsfpWV/PyoIVI?= =?iso-8859-1?Q?Qx5VU2+XEaU491AwmJzLzwHHMJao/OJSzX6NAZAyDRwFz4IIZQrdxjaTqm?= =?iso-8859-1?Q?Zlj6R1KsFHqRoxYnvY+uNnbRoLT7BueWT2srLCNy5uUi+qCoS2ApDlKgW3?= =?iso-8859-1?Q?WpeD5t5q/o8ku5xVTSxjFGhDyr9xyrhokBIayABindT88YPO7DJAMOjDHO?= =?iso-8859-1?Q?e0fPLC3DiGTUj1aZBd2cqDjq9IvBw29S2/UN+PITxRFyfRa2HrCJTe7db+?= =?iso-8859-1?Q?0VbJIJVe78KGOyFTyG0TEl/BN1dsUbuj+Ao2IVKDLsX6OUOxNb78/V7UJp?= =?iso-8859-1?Q?eNe2yDkG1acftzrJsYbuUHakMKsAFjfOuKUHh84ZCdb+vUDce9msRjhTmJ?= =?iso-8859-1?Q?H+VwrrE9G322CxflpKIgEI4N1C0gr5dFr7lZ+tWqFQf+Erodjpl6W8D1Ny?= =?iso-8859-1?Q?m1qt10fkLjyDVO+oBWQ5MqCpCk9qeJS5qF22MC1bnqvXgGPiX/+rQWUgjz?= =?iso-8859-1?Q?DgEIdxtbclLgJm7zid3kgxdnLa6ZetKHCfqakCp5lNsXfhn1SVOGecAUtq?= =?iso-8859-1?Q?8RG8PqGBI4mrpYj1+oapW8DqHCDZyj+M8bm5H7bJFoPdixG/YRVOZlxvgo?= =?iso-8859-1?Q?LMuCjwYsmNpYR3OuRBYBZRzjk=3D?= Content-Type: text/plain; charset="iso-8859-1" Content-ID: <55D1FA341D1C9D45A6AD40C493E474E7@namprd10.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BL0PR10MB2852.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a895fa92-acb4-4913-c6ca-08d9beb98dcf X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Dec 2021 04:24:00.5228 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: NqLCg336taXdPZ/03L5whoAbNmhP0zzDTPetU1y5hlNQbkc8ATAQhizFt0MKtnHjNYHjxRMZUNCa7eH+zQcMY8W8kaaua/AWKGBs/oJAMsY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR10MB3919 X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10197 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 adultscore=0 malwarescore=0 bulkscore=0 spamscore=0 mlxlogscore=553 mlxscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000 definitions=main-2112140021 X-Proofpoint-GUID: ffuSQmhpBq4rG-6z1KCt6VVU1zQkwEv_ X-Proofpoint-ORIG-GUID: ffuSQmhpBq4rG-6z1KCt6VVU1zQkwEv_ X-Spam-Status: No, score=-12.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_LOTSOFHASH, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Dec 2021 04:24:12 -0000 On Monday, December 13, 2021 10:11:54 AM CST Dodji Seketeli wrote:=0A= > Hello Guillermo,=0A= Hello Dodji=0A= =0A= > I ran the tests and found some issues on my system. I have described=0A= > them below.=0A= > =0A= > "Guillermo E. Martinez via Libabigail" a=0A= > =E9crit:=0A= > =0A= > [...]=0A= > =0A= > > * tests/data/test-read-ctf/test-enum-many.o.hash.abi: Likewise.=0A= > =0A= > [...]=0A= > =0A= > > tests/data/test-read-ctf/test-enum-many.c | 10 +=0A= > =0A= > [...]=0A= > =0A= > =0A= > > +++ b/tests/test-read-ctf.cc=0A= > =0A= > [...]=0A= > =0A= > =0A= > > + {=0A= > > + "data/test-read-ctf/test-enum-many.o",=0A= > =0A= > This file is not present in the patch.=0A= > =0A= > So running the test yields:=0A= > =0A= > $ ./build/tests/runtestreadctf =0A= > NOT PROCESSED TYPE 18446744073709551615=0A= > NOT PROCESSED TYPE 18446744073709551615=0A= > NOT PROCESSED TYPE 18446744073709551615=0A= > NOT PROCESSED TYPE 18446744073709551615=0A= > NOT PROCESSED TYPE 18446744073709551615=0A= > NOT PROCESSED TYPE 18446744073709551615=0A= > NOT PROCESSED TYPE 18446744073709551615=0A= > NOT PROCESSED TYPE 18446744073709551615=0A= > NOT PROCESSED TYPE 18446744073709551615=0A= > NOT PROCESSED TYPE 18446744073709551615=0A= > NOT PROCESSED TYPE 18446744073709551615=0A= > NOT PROCESSED TYPE 18446744073709551615=0A= > NOT PROCESSED TYPE 18446744073709551615=0A= > NOT PROCESSED TYPE 18446744073709551615=0A= > NOT PROCESSED TYPE 18446744073709551615=0A= > NOT PROCESSED TYPE 18446744073709551615=0A= Those message are corner cases that i future patches will be fixed. e.g:=0A= https://sourceware.org/pipermail/libabigail/2021q4/003994.html=0A= =0A= > runtestreadctf: /home/dodji/git/libabigail/patches/tests/test-read-ctf.cc= :277: virtual void test_task_ctf::perform(): Assertion `__abg_cond__' faile= d.=0A= > Abandon (core dumped)=0A= > $=0A= > =0A= > The program aborts because "tests/data/test-read-ctf/test-enum-many.o"=0A= > was not found.=0A= Upss, so sorry! =0A= > You can detect this kind of problems by running 'make distcheck-fast'=0A= > before submitting the patch. It's super helpful.=0A= OK, thanks for the advice, I will do so=0A= > =0A= > Also, please be aware that all new files to the tests/data/* directory=0A= > sub-tree have to be added to the tests/data/Makefile.am so that these=0A= > files are added to the final distribution tarball. Otherwise, "make=0A= > distcheck-fast" will fail.=0A= Ok I'll keep an eye on this.=0A= > [...]=0A= > =0A= > diff --git a/tests/data/test-read-dwarf/PR27700/test-PR27700.o b/tests/da= ta/test-read-dwarf/PR27700/test-PR27700.o=0A= > deleted file mode 100644=0A= > index 3f084d21..00000000=0A= > Binary files a/tests/data/test-read-dwarf/PR27700/test-PR27700.o and /dev= /null differ=0A= > diff --git a/tests/data/test-read-dwarf/test-PR26568-1.o b/tests/data/tes= t-read-dwarf/test-PR26568-1.o=0A= > =0A= > [...]=0A= > =0A= > > +++ b/tests/test-read-dwarf.cc=0A= > =0A= > [...]=0A= > =0A= > > {=0A= > > - "data/test-read-dwarf/test-PR26568-1.o",=0A= > > + "data/test-read-common/test-PR26568-1.o",=0A= > =0A= > This file data/test-read-common/test-PR26568-1.o doesn't exist in the=0A= > patch.=0A= > =0A= > As a result, running runtestreaddwarf yields:=0A= Upps, sorry again.=0A= =0A= > $ build/tests/runtestreaddwarf =0A= > runtestreaddwarf: /home/dodji/git/libabigail/patches/tests/test-read-dwar= f.cc:590: virtual void test_task_dwarf::perform(): Assertion `__abg_cond__'= failed.=0A= > Abandon (core dumped)=0A= > $=0A= > =0A= > It aborts because at least the file=0A= > "tests/data/test-read-common/test-PR26568-1.o" is not present. This too= =0A= > can be detected by running "make distcheck-fast".=0A= OK=0A= > [...]=0A= > =0A= > I hope this helps. Thanks.=0A= sure thing!!=0A= > Cheers,=0A= =0A= Thanks so much for your comments, I'll send patch v4 soon,=0A= Guillermo=0A= =0A= =0A= =0A=