From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by sourceware.org (Postfix) with ESMTPS id 4D6F73858408 for ; Thu, 11 Nov 2021 15:16:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4D6F73858408 Received: from pps.filterd (m0246632.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 1ABEmaT0028586; Thu, 11 Nov 2021 15:16:42 GMT Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by mx0b-00069f02.pphosted.com with ESMTP id 3c87vxt94c-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 11 Nov 2021 15:16:42 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 1ABFBgbs145766; Thu, 11 Nov 2021 15:16:41 GMT Received: from nam11-dm6-obe.outbound.protection.outlook.com (mail-dm6nam11lp2173.outbound.protection.outlook.com [104.47.57.173]) by userp3030.oracle.com with ESMTP id 3c842dyr4w-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 11 Nov 2021 15:16:41 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UR3wq9otJhFvqx8wdHakS19KFTjl1yQshu1SpNxtvW1BPYhHPPdEImRirjMNj9yC6d01TeFHmJyNTh5CYiWXzDRpJ9j4P9JziFCMJefaZV7YdQ+beL/Ch/Zngr5DRsdPC+jjrKpsuVOBKWtOakILMm6+WZA+SzHAE6JwW/gniRWHaw+34yrT4NdlGj1LIMe2DdVOqhivIFuWAm7jlkZEFKbn+Uf8znby1LjziH+YzUyIMvSI8KNOsSQ5nE5LBzJpSM6ph9NxI60NyvQfZztxQUw04bhwehs3d/b4PR+g/lDOb0V3OuCF6kF6fgqRiKGD6XIvfVFzUS2xwNoljYLV0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1YGTfeS9aXpwbU2dXdF+D3V6EyM7mbEwd40sAUhCcdo=; b=iLrzXeVK+5vtKU7RuZt+bQptjJtuxhY+LI8DUZvdvMvNlHkuohc9fV8mOHm3Z6oTvnlHFiT1SB6t3qtbKzC5/KIqanndlyF63cZmfFjduMmT4of4Jfw2aaaiE+Bpc59ARhP9djyAN3RGoC47rgJlp9dW1PMyEkdb/cAl8EvbKYYtXcgPRyTlHqMY4dtQc7Y20cpMr+E9wYPqq7A1pqUmk7Fp0h9aYjGxK9UtEPKru1o/dCJQcYHy0EZoAn6JVqBB5LmDyTPr2m0CtPtUSXKVkF0QFxbByGJ1+Q2ubfQDJakwYQnAOXTDyLYF2CnPFsww0YeDvy5kKVDvWfVN6770Aw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none Received: from BL0PR10MB2852.namprd10.prod.outlook.com (2603:10b6:208:76::22) by BLAPR10MB5140.namprd10.prod.outlook.com (2603:10b6:208:320::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4690.15; Thu, 11 Nov 2021 15:16:39 +0000 Received: from BL0PR10MB2852.namprd10.prod.outlook.com ([fe80::7126:e98e:9cff:8765]) by BL0PR10MB2852.namprd10.prod.outlook.com ([fe80::7126:e98e:9cff:8765%7]) with mapi id 15.20.4649.019; Thu, 11 Nov 2021 15:16:39 +0000 From: Guillermo Martinez To: Guillermo Martinez via Libabigail , Dodji Seketeli Subject: Re: Regression tests for ctf reader: Avoid duplicating files Thread-Topic: Regression tests for ctf reader: Avoid duplicating files Thread-Index: AQHX0QP5eyOfKjsjZkq48NTJH8DFiKvzCcH2gAd9+oCAAirw1YAByYqA Date: Thu, 11 Nov 2021 15:16:38 +0000 Message-ID: <3027653.ZpbPo3QBVt@sali> References: <1859179.TfuLjZUhfy@sali> <1990370.rjD3G2zAS3@sali> <87sfw575dc.fsf@seketeli.org> In-Reply-To: <87sfw575dc.fsf@seketeli.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 587b56d4-08e6-42d9-021e-08d9a5264264 x-ms-traffictypediagnostic: BLAPR10MB5140: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: UYzwGmVMTywwu993M+r456UnPfPrgRiT7i9KKYeijv/QybACimBln1XKr/SiTHqC/N8YOMDs1wESR0W78QKc0plRPjwTWN/quCz4fZuXfgarFO4FV7afi3DvYqSgzOShCeU08hL4NUemJwFdkVMjblA0Ba8vKFvSumDmPN8RWxX52+lRl+///j38AtyQhiJzhAAYECehQVHNMiukTdnPZDke4qvQKRxZho6VI9M6G+et9VeblXqvXk/i5xHWnK9Lt4XXOEn1kGG1xJ7SMMrTHw34dlSuW2B67HiZ0137Tw1bmkuNGRovJm8oHviIEJ2kJBt/Hj3UhGzAkkw5yU/6sG2XvUCO6CE7SWLGszZPbKn1Fr4ZLpw0/H23py+QqjGE40J2NktObFuDObXmmGa96PSorpZb4gOlNuVvD7h5jOkxQRohdSu/bbdjuVhm2o+QA7xXaxzHRnyg4lmQ6NEDf5yKZHyQAzHQLg0zCf8aJw3KWfrTWnBlpX5BGYeUIkJkC9z1DwutV8nQBXQCjIhFsWnESIh/suChzlDjja7o1SPUR6qKjR6hCrE60XVwXcp7l2wu1Tuv4GlkOHFRYHyHuQlijQf2maBvFW4KA6UQ8w9VEB7hA51D4FI++QN4G1wa5Ik92aQRz+xHQLkpcA2nLqYLI9mBmXXNg3ki41M+h9zi7NgbYeUozjcJFCrBJJqvTfKfeeoFoZyZ+3t2SpN2yQXUO9HVIBhoohgpjw1nG/A= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BL0PR10MB2852.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(7916004)(366004)(91956017)(83380400001)(26005)(76116006)(66946007)(19627235002)(53546011)(66574015)(186003)(86362001)(64756008)(508600001)(122000001)(38100700002)(316002)(110136005)(6506007)(6486002)(5660300002)(2906002)(66446008)(66556008)(66476007)(6512007)(9686003)(71200400001)(38070700005)(8676002)(4326008)(8936002)(107886003)(33716001)(39026012); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?tqwIAuKk819eaICZa16MXdL/l9gkqDJnenXyf/mOFRR0WIVmQP3LL+EM3v?= =?iso-8859-1?Q?iCE36HeDLbT7pjFippGczbHawpaFQAxe6v/eayr3+BW0Ni+17E6SKkC/eM?= =?iso-8859-1?Q?5HvneTlZdRsLu6i64ojOT1aP5+ndZuUHTId8vQQaXdvzmalznkvL3ja3as?= =?iso-8859-1?Q?rREWzjQToIqSdmSw+w/ZDT/SjnanX2mvDkMF/syRljN8z+7s3j+EigFjgf?= =?iso-8859-1?Q?NzfqM+vH7iinwGjgaykCOQkIB1rqRqbwDc29JqQH/mdTAm0YrqoIbPfkNA?= =?iso-8859-1?Q?V32Prbed2iI6oDFXqRRoJ7HOt/G0LghmjgtMGblAmU9VIZno6L6anWsWzJ?= =?iso-8859-1?Q?HKvSCjNKrS8+zwpRA9MVoOsV4kc4OTESTIZvLrUF72Rw3gR62Gtc2ukSBV?= =?iso-8859-1?Q?w8h5uldPdoQ3eYUSLsWqAdpeu1CSmE38Cl6KddLf2sl5BVtClvhkHo2Csx?= =?iso-8859-1?Q?+XZidc5S5DiXsPa7KfHPl6AW74LKFJ7wps4eA3KWhga9GZtoUrGdoxUTOJ?= =?iso-8859-1?Q?5dsVBkYtDjbX6RpvVU/zAPKT+qe2FSTJ+HZ3qTM+KxxTRZuPEgvShMwNm0?= =?iso-8859-1?Q?bs4Z/sz4fM1P/u+EwkIc+HDBr8jCF9w6IAz8pVzIxlpq4ecWO8SEY30vRa?= =?iso-8859-1?Q?+jJWI9HmAdXcWTDxqgbKe8XsivB9d2NUnfQzGeH8OfSuvl01EAD7QH1FZf?= =?iso-8859-1?Q?O69Yk30b4JrOzbtkWM40ilgWBKj+gb8qHPGTh1oMm77p0PTDM0qhVo6CWD?= =?iso-8859-1?Q?zftlUUHSrGN8SdJ59jLs/WziWVYAy1SDEWi+PNSzLMRZl57yWAOlRFEpJp?= =?iso-8859-1?Q?RYNFdFib0SvSSBLkvCOrV6ZEt8WjTL+2IkzAJU6Cb3D//nG4R/N9To7b/9?= =?iso-8859-1?Q?5cuKgGJt5+zPM486EdgBKqS8eOkiTaSBK5L2AV+4vtMarqQIXFVYskDUH9?= =?iso-8859-1?Q?2qNLKMVx73oznc0b3XtBVuI0spD1BQ6xc8nL4QkwPBFbiR3LFjL7uwz9eO?= =?iso-8859-1?Q?AQLemFRyvgo1Nr5QhU2+HSRbtzZzV8ZbhdZl2uuotJl1LoQwel4sdniuhl?= =?iso-8859-1?Q?MTswMlxWFXnf89zaHa0K2pkUqdFQv2egawaPkkTtW4/KE0id5kTTPozJkR?= =?iso-8859-1?Q?JFRgnpp4c5IxZFvm0H9LxxcjscUFxxMKUn3SK7jjJjH57iNg1t47WbjYAm?= =?iso-8859-1?Q?64vBPAfOc7qXVMOwgv7QJfUXa7B+/JMgPINshRrMi1uQDFTBpbhGX0U6qt?= =?iso-8859-1?Q?65AWKQLmRuSCJgcM/9CJkOWARGKBHH5hbcvfcqZgllDpI8mLvRnOqnYfnC?= =?iso-8859-1?Q?DxqyKzd/9Bv2GmMSOtMDIf6A6FJ8IGBJjCbLXIgU5nbUm+k3j02fieEr2+?= =?iso-8859-1?Q?Xx7H0+VWif1sJ9HbYkjiKhrND6RPC9H2oueBKPPtmpiSz+xxdBZgawTxD3?= =?iso-8859-1?Q?kXoHVh/SaI7nQoVvSvAJh1d5wbZNwSVAqLxmh6NRztc+KPPmYs3CRJNYzR?= =?iso-8859-1?Q?1cxTQz5h4Tn7U1AdrE4ZpA0pmpGEVQbhG/ffWOS+77N5OtM0M7PM3QheVI?= =?iso-8859-1?Q?05IDDEZEykxiR6OLU99I2MD5U9B1ISJx39RNk4oM9jZhNTfXUifDlqjG7I?= =?iso-8859-1?Q?x0vm1bJ+KLuAwiHxijsDXHdBV8LybVLbNvu8v2Vg4HZNFkUqlxnEOtevIB?= =?iso-8859-1?Q?KC1PiF+7ZUH02UKDASOf5VRwWAfhjQPB9zBrlS77Sd20afQ3XenFArOBrx?= =?iso-8859-1?Q?xWo9B/+wtduO7vgybu0b4G9wg=3D?= Content-Type: text/plain; charset="iso-8859-1" Content-ID: <71C6A808E6EAA44A8C9EBD9EED8184A7@namprd10.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BL0PR10MB2852.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 587b56d4-08e6-42d9-021e-08d9a5264264 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Nov 2021 15:16:38.9857 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 6FjH3q+NPBPC5cUd2jhOtj0dj2/V7C4fcYjB2umgzU3o9VceDvRH5oHGDSzqnemUeJc8cSvS6FU2dAUrp9etbHW7pFVB5W5dqRD6OuhIJUY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR10MB5140 X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10164 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 malwarescore=0 spamscore=0 suspectscore=0 adultscore=0 bulkscore=0 mlxlogscore=999 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000 definitions=main-2111110085 X-Proofpoint-ORIG-GUID: xrm8JW8ZfONDh1fFC0bw3aTfqhZDJR79 X-Proofpoint-GUID: xrm8JW8ZfONDh1fFC0bw3aTfqhZDJR79 X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Nov 2021 15:16:48 -0000 On Tuesday, November 9, 2021 8:47:43 AM CST Dodji Seketeli wrote:=0A= =0A= Hello Dodji and Jose,=0A= =0A= Thanks for your advices!=0A= > Hello Guillermo and Jose,=0A= > =0A= > Sorry for my late reply.=0A= > =0A= > Guillermo Martinez via Libabigail a =E9crit:= =0A= > =0A= > > On Thursday, November 4, 2021 2:27:57 AM CST Jose E. Marchesi wrote:=0A= > >=0A= > > Hello libabigail team,=0A= > >> =0A= > >> > I'm working in the implementation of regression tests for ctf reader= =0A= > >> > (tests/test-read-ctf.cc), it's very similar to test-read-dwarf.cc, s= o=0A= > >> > they have some C and header source files that are common among=0A= > >> > them, e.g:=0A= > >> >=0A= > >> > tests/data/test-read-ctf/PR27700/include-dir/priv.h=0A= > >> > tests/data/test-read-ctf/PR27700/include-dir/pub.h=0A= > >> > tests/data/test-read-ctf/PR27700/pub-incdir/inc.h=0A= > >> > tests/data/test-read-ctf/PR27700/test-PR27700.c=0A= > >> > tests/data/test-read-ctf/test-PR26568-1.c=0A= > >> > tests/data/test-read-ctf/test-PR26568-2.c=0A= > >> >=0A= > >> > So, we're planning move those common source file to:=0A= > >> >=0A= > >> > tests/data/test-read-common/=0A= > =0A= > Great.=0A= > =0A= > >> > But we still need *two different* binary files with the debugging=0A= > >> > information: DWARF (-gdwarf) and CTF (-gctf), that they would =0A= > >> > need to be recompiled. The current implementation to test ctf reader= =0A= > >> > use binary files previously compiled, so there is one file for =0A= > >> > each binary format:=0A= > >> > =0A= > >> > tests/data/test-read-*ctf*/test-PR26568-1.o=0A= > >> > ...=0A= > >> > tests/data/test-read-*dwarf*/test-PR26568-1.o=0A= > >> >=0A= > >> > So, Are you agree with this approach?=0A= > >> >=0A= > >> > We are looking for the way to avoid duplicating files :-)=0A= > >> >=0A= > >> > Thanks in advanced for your comments!=0A= > =0A= > On Thursday, November 4, 2021 2:27:57 AM CST Jose E. Marchesi wrote:=0A= > =0A= > =0A= > >> An alternative to have two copies of compiled objects is to have just= =0A= > >> one copy (in test-read-common) compiled with both -gdwarf -gctf.=0A= > =0A= > Right, we could do that too. You'll thus need to adjust the existing=0A= > tests in test-read-dwarf.cc to make them pick their data from=0A= > test-read-common instead, e.g:=0A= > =0A= > This:=0A= > =0A= > {=0A= > "data/test-read-dwarf/test0",=0A= > "",=0A= > "",=0A= > SEQUENCE_TYPE_ID_STYLE,=0A= > "data/test-read-dwarf/test0.abi",=0A= > "output/test-read-dwarf/test0.abi"=0A= > },=0A= > =0A= > would be changed into:=0A= > =0A= > {=0A= > "data/test-read-common/test0",=0A= > "",=0A= > "",=0A= > SEQUENCE_TYPE_ID_STYLE,=0A= > "data/test-read-common/test0.abi",=0A= > "output/test-read-common/test0.abi"=0A= > },=0A= =0A= hmmm.. as far as I could see at the end of tests/test-read-dwarf.cc=0A= there is an assert test invoking the diff command for two ABIs files=0A= one of them is generated by reading the ELF file (InOutSpec.in_elf_path)=0A= and it is serialized in InOutSpec.out_abi_path and the other one is=0A= the predefined file stored in InOutSpec.in_abi_path. I'm nor pretty=0A= sure how can I store "common" ABIs for both formats (CTF & DWARF) in=0A= in_abi_path, since out_abi_path file is just generated with information=0A= depending of which test we are running: tests/test-read-dwarf.cc=0A= or tests/ttests/test-read-ctf.cc, and the diff command will fail.=0A= =0A= I think that in data/test-read-common/ we can just store the source file=0A= and the compiled file with both (-gctf & -gdwarf) ABIs file should be store= d=0A= in a separate file one for each debug format.=0A= =0A= What do you think?=0A= =0A= Worth it mention here that I found a couple of test that generate the XML A= BI corpus=0A= *same information* but the XML nodes *are not* in the *same order* ... and = the=0A= diff command fails :-( ..I'm not plenty sure but we could read the input XM= L ABI=0A= (InOutSpec.in_abi_path) and build the corpus, after that compare this one w= ith=0A= the corpus built with ELF file (InOutSpec.in_elf_path) and so avoid rely to= diff=0A= command, something like to abidw --abidiff works=0A= =0A= =0A= > =0A= > The tests/data/Makefile.am will also need some adjustments.=0A= > =0A= > I think that sounds a fair path to take, as far as I am concerned.=0A= > =0A= > > Thanks Jose for your advice! .. any other alternative? .. I would like = to start=0A= > > working on this :-)=0A= > =0A= > Great. If you see that you need to share code between=0A= > tests/test-read-ctf.cc and tests/test-read-dwarf.cc, maybe you can just= =0A= > create a tests/test-read-common.{h,cc} files, if that helps. This will= =0A= > obviously be welcome, unless someone objects to it, of course :-)=0A= =0A= Totally agree! :-)=0A= =0A= > Cheers,=0A= Thank so much for your comment!=0A= =0A= Kind Regards=0A= Guillermo=0A= =0A=