From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by sourceware.org (Postfix) with ESMTPS id CC6093858D28 for ; Mon, 25 Apr 2022 18:38:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org CC6093858D28 Received: from pps.filterd (m0246630.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 23PHIbGj031281 for ; Mon, 25 Apr 2022 18:38:38 GMT Received: from iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta01.appoci.oracle.com [130.35.100.223]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3fmbb4m03k-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Mon, 25 Apr 2022 18:38:38 +0000 Received: from pps.filterd (iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (8.16.1.2/8.16.1.2) with SMTP id 23PIUSW0003420 for ; Mon, 25 Apr 2022 18:38:37 GMT Received: from nam04-mw2-obe.outbound.protection.outlook.com (mail-mw2nam08lp2169.outbound.protection.outlook.com [104.47.73.169]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com with ESMTP id 3fm7w26tyj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Mon, 25 Apr 2022 18:38:37 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FffdPsnKO2AonPhaEHr52oy/1nIKaDHfAF9YVMLKJ0laBAgDuCfSqz3UDbdCwlBLXWZZwJtGkXLuoBLXnOQy4OObJburCYFVAKJ6RQPN/FIoZ/1IduwJlyOz3KGCZu//SsW96VDZ8R1N7AOF0fekusN6SH3H79E77kWz9XzowQqwJyAp2y8xY0wrGh+2GHKcTmAKVpnKTUy35iBrYLdzDTT/3655do2cWlHj2ZX2Y4xHvvyyRYrqHlyuQqUTj2WGZMIDEmMM7hPb2hGpFQJGrgDBDoLCpqjCfiihecdJFe3u35WxFXzmsOoyhOXa8K8boplQFUSgy5oxBX8m3xAbPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=naFrQoTo2JMGNuzw7N38utohQmc7dOcBd/CZel9ebLg=; b=iwIOYqV062IooooskMBybOL90OSXE7q35YvHCAMnUzCrWkZ9YNzhMKli3X/IxqHJVGgAzXaQ34oL8ynY9IEJduWk6uf2vaKbmgi6dPDsUZjd7NoIqGd8j/yhG8v16X8s+MEwCf8j6FqwECfLTLizDYM5eEXunNtJz1ZxPcLOWsuWfg3SVfplKFY0rm7UvSvAsk99fr4WYdLMs6ejIJEyux3/S+zKWTqGruSJnBuGsg/5VlRWWfG0Bj3KpPe6VbXqDhFdQqqmECosojeTgSbSjCWPL5COb9FlIyJIUWBPyOpFhB/P53IHIya7T+dMzddufcen4QiNaVP6kaLQak7HIg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none Received: from MWHPR10MB1407.namprd10.prod.outlook.com (2603:10b6:300:23::20) by BYAPR10MB3079.namprd10.prod.outlook.com (2603:10b6:a03:89::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.20; Mon, 25 Apr 2022 18:38:35 +0000 Received: from MWHPR10MB1407.namprd10.prod.outlook.com ([fe80::107d:de35:fa5f:3cc0]) by MWHPR10MB1407.namprd10.prod.outlook.com ([fe80::107d:de35:fa5f:3cc0%7]) with mapi id 15.20.5186.021; Mon, 25 Apr 2022 18:38:35 +0000 From: "Guillermo E. Martinez" To: libabigail@sourceware.org Subject: Re: [PATCH v2] ctf-reader: Fix multiple var-decl in anonymous struct/uninons Date: Mon, 25 Apr 2022 13:38:33 -0500 Message-ID: <3171653.44csPzL39Z@sali> Organization: Oracle Corp In-Reply-To: <20220406165907.1474155-1-guillermo.e.martinez@oracle.com> References: <20211216052007.374822-1-guillermo.e.martinez@oracle.com> <20220406165907.1474155-1-guillermo.e.martinez@oracle.com> Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-ClientProxiedBy: DM6PR13CA0024.namprd13.prod.outlook.com (2603:10b6:5:bc::37) To MWHPR10MB1407.namprd10.prod.outlook.com (2603:10b6:300:23::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 768ddb95-0662-49e0-4de2-08da26eace92 X-MS-TrafficTypeDiagnostic: BYAPR10MB3079:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Jme3B6D3HhY9IFqfWJqeJA3WeeVQDZXGhxB4gzNRWMYQXv4+YRDakvS/tkJ1wIjxgO2xiJ0B/4xgYhEs/1g290Blf3R+Y6i7XHumiLZ8B0ZZQEADqHpNSMzHN7jm1NoqF1AJ9ucxZ7+t4fya13xwtRGDO6b/pJzswwrepNegyt+vwc1DxdURf2QhyapOkyV4bI5npe0FUs5lXbJrk5XH+9X5a8+Fyxfv37VhFOWUH6otMd5MQyQ6Ab2ALIm6HtrOtHMchvRp8Ma8FZnf8cXlsDRsaLQNOXJ9UlNvJik/JZyWzw2F7i2JeAbz9EgrYwrsxn3iBSeoqHGlPGipKLEB52Rt++G+r4d/zcRvL/1tLzYkVPUEyNwxufaYF1h9hokbnyMVfkXe1Ff6qm1IQszLMNl3H3UmR/+8Id+Ws5Z9OC7e+rPETUPF8r8OJ9hUiLK89rEcsHy5y/qHJxiG1v5p9WmXnkodHnKEhBYmKJT7KpRi8FoBHHw4A8AMRQKqt22PGBCH8RZwcL4sDKEnQn04OwUJ0XVx1lbiNapCLkyxY8mCCDyl4Ttw3h28ywN+8qPRnhSEeH/dOtFhUV5jlFlAx8IAHqRerbqzXdGL6f9PC8i977wGDNhQewCns4WfwaisEddyyElvnQQzjwDE+8hXtxuZHiVNkj4F8VLec4i8jgzAJV0O5roiKsGieupT7AjmMPLBm19uSFf6mgRZIvuw3A== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR10MB1407.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(7916004)(366004)(66476007)(4744005)(66556008)(6506007)(66946007)(36916002)(8936002)(316002)(8676002)(5660300002)(86362001)(53546011)(52116002)(38100700002)(6512007)(186003)(33716001)(9686003)(508600001)(2906002)(6916009)(6486002)(39026012); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?s86tk+gqLYbZYzHCS8wlQ0p7spL6d+KbhNqXJb58BbfQjmlNStDnR7UoX2HO?= =?us-ascii?Q?118xoHcXTt4TPiPkgeHmL1PLm3cdZiwIQQR+xWT8/p/BOJUxuk4W/8e3BWAJ?= =?us-ascii?Q?p+eiw3HeThcCLTiLMxSheH7hSyV7TgezTPCnuuBVnQoWcYQez/hc6NEX0u7p?= =?us-ascii?Q?aNbH2R/lH46uU2rFnXDN7v84loaYNihmSvxefgnIms70rZcExyNzvzk1zA6X?= =?us-ascii?Q?i0nyLTi91PKWX8S49+FqQdJYvM/R11rR0vUz0jR5j5X5ALcRaBmJSwGUbzqs?= =?us-ascii?Q?D11AbqYNfphtPEL6C+eYR+2qmQwWjssEowfxEgTPBhLLUZ1dw4AIKp1JKxDF?= =?us-ascii?Q?u8XwOLoqAp2BxO9y31673W1X4mQJ2+dEkimn6pU/A8YHvmNyA89w3bIl6GGr?= =?us-ascii?Q?zCd39WUGX/SU8sSN2i3PuLa6D9VaBZWq7pPTeML20A/xEt6R9gGVni+yj2A5?= =?us-ascii?Q?hNAypko6Qytek/pbFo1L7QXxTkBSF5QUHoIPTTAR8yLxjTNQ8brcmKbD9xMc?= =?us-ascii?Q?xdTWYeOLoZdeSeaczHNLlOk1GTU6RYTEGsar+LrcIhjkKt47uhgUF8ukIE13?= =?us-ascii?Q?NzsoPrW3VxIiBMBHnBJ9I0a4MO0lgTib/B5DlGb/oIEhdE30RB4AJLcFzO4T?= =?us-ascii?Q?GLfwG/5lAPuYIhug2EgnF0V/KbLFIjxcbCVbiu5DqdUL3ME47KjUA7yC8S49?= =?us-ascii?Q?cTIG7LZ99ikYbJ5DaARm4WMs79XYdPlXXaWuTFNYo/Og4dCxwBtG1ARrI5rv?= =?us-ascii?Q?TX62EExboVDKErrZfbwFqAiaqjgrhMupgTUUux2Q0LCFaaPUJXEXMYdJLuxp?= =?us-ascii?Q?tSUTyUxla9fpRrVX+g64tljeBUMJ2GMWa6z2qhYazmJLeEJ2CM9zMpa3b3jS?= =?us-ascii?Q?FhdbEs8s/C75YK9PzxJwJBTOuo9k/jxmpOJQdtc2WL63v7e5LmIaC64rIIEe?= =?us-ascii?Q?L/j2ML2REGKnQi7i4HgM8p6+b0hFVQtBAzn7FXEBl7O8HQyt1ZKOtUelv5Z6?= =?us-ascii?Q?Eo/jTSj1TOeLOEx+dC/oTEKFRv/k7Q2fqFjXfbbFSwQTDr1pxQitAirXrmTA?= =?us-ascii?Q?dS2ogTkBw/I63+bE3YvtmcfRk8/2ilXexOTd0pJzj3pYtfgJ0tmjpCnqvFBC?= =?us-ascii?Q?PGhbxuHEtqQ20LPSbajtZhJ1gFF8LvBCdQuwxq6rEKQRDykXe3HOM9wJ22kF?= =?us-ascii?Q?n3yz9fMdERMxjMjovT8dkKdeQ7rhzegaym8KSAX4HWFm2y4RI3fk0nO1d4d6?= =?us-ascii?Q?mM/e6JutL30zdwxnGIs6ylFlVicY060noYCvpBGaDXnIPPvLmBPi1BRmoYpe?= =?us-ascii?Q?kAmyQ4pA0UN9i5acLBzRvNGx77tUQNL90KUVY3uNgsRxBGmcd2Cn2lQrzmDR?= =?us-ascii?Q?vq5K0HyUFh6uCt/YuLXBAv3H4uLy7/inrDRx9P5ToAmgTBuj+JuB3dSND5qQ?= =?us-ascii?Q?Kh7blGDzPVii6/h1rNoWDk+UUFzdN7bxZ2BBphWN1hkJRkhlurgk60DmJYGM?= =?us-ascii?Q?/dIkKNrpqinX76HgSNQF0NFo31NyCqE982bciO2/9hPYM+QjkHFALhBf20QC?= =?us-ascii?Q?w+oQrQ2epmraK5g66IxmEzWbD26JuSjyeoDRl/3CeVD6xQL9uyjPP9RuJKWH?= =?us-ascii?Q?YLo9glVjZ3cAStkuI0sTjuH+gTgA5dukH1GpNRszNaoQjQgwxPimzzb6Pv4B?= =?us-ascii?Q?9kb+gPa/cAMC7zTr0DOWOhmEBXf4v/3fGIg9AlRxflCbkilVkzSsJHimXc2D?= =?us-ascii?Q?1XygxNDJYC8r0QDtC6GOC71Gwj6qVtgsqRXVqACg9TzO0KVSc/hHltK+CHOh?= X-MS-Exchange-AntiSpam-MessageData-1: c73MuLpCPXfwEg== X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 768ddb95-0662-49e0-4de2-08da26eace92 X-MS-Exchange-CrossTenant-AuthSource: MWHPR10MB1407.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2022 18:38:35.7181 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: CyJ2qc/6CNHmFmZcvqMxeHP6g1v+uDh+JsMXZh5Pn29OjHJWQdxNni/JtIqNqNVRo75ZQ/F39AU768pJsQXJyHDjb1aqEQMkOFzJWbe4TtY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR10MB3079 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.486, 18.0.858 definitions=2022-04-25_08:2022-04-25, 2022-04-25 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 suspectscore=0 spamscore=0 malwarescore=0 mlxlogscore=722 adultscore=0 mlxscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000 definitions=main-2204250083 X-Proofpoint-ORIG-GUID: txqB1lMW3EVQ7Ap_anQ6pWVeP7b_zA1Q X-Proofpoint-GUID: txqB1lMW3EVQ7Ap_anQ6pWVeP7b_zA1Q X-Spam-Status: No, score=-6.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Apr 2022 18:38:40 -0000 On Wednesday, April 6, 2022 11:59:07 AM CDT Guillermo E. Martinez wrote: Hello libabigail team, Any comment about this patch? Thanks in advanced!, Guillermo > This patch avoid multiple inclusion of `var-decl' node for the same > field in anonymous struct/union declaration in the abixml, e.g: > > struct uprobe_task { > union { > struct { > unsigned long vaddr; > }; > > struct { > int dup_xol_work; > }; > }; > }; > [...]