From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28237 invoked by alias); 27 Sep 2019 14:40:27 -0000 Mailing-List: contact libabigail-help@sourceware.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Id: List-Subscribe: Sender: libabigail-owner@sourceware.org Received: (qmail 28222 invoked by uid 89); 27 Sep 2019 14:40:26 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.100.3 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-6.8 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.1 spammy=sincerely, Sincerely X-Spam-Status: No, score=-6.8 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on sourceware.org X-Spam-Level: X-HELO: gnu.wildebeest.org Received: from wildebeest.demon.nl (HELO gnu.wildebeest.org) (212.238.236.112) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 27 Sep 2019 14:40:24 +0000 Received: from tarox.wildebeest.org (tarox.wildebeest.org [172.31.17.39]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id 5589B302BB42; Fri, 27 Sep 2019 16:40:22 +0200 (CEST) Received: by tarox.wildebeest.org (Postfix, from userid 1000) id 1162D413CB5E; Fri, 27 Sep 2019 16:40:22 +0200 (CEST) Message-ID: <336fbf713811afb4622c59fea73b92acd63babf8.camel@klomp.org> Subject: Re: Buildbot failure in Wildebeest Builder on whole buildset From: Mark Wielaard To: libabigail@sourceware.org Cc: Dodji Seketeli Date: Tue, 01 Jan 2019 00:00:00 -0000 In-Reply-To: <20190927133002.895CF81A9E2@builder.wildebeest.org> References: <20190927133002.895CF81A9E2@builder.wildebeest.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.28.5 (3.28.5-5.el7) Mime-Version: 1.0 X-Spam-Flag: NO X-IsSubscribed: yes X-SW-Source: 2019-q3/txt/msg00053.txt.bz2 On Fri, 2019-09-27 at 13:30 +0000, buildbot@builder.wildebeest.org wrote: > The Buildbot has detected a failed build on builder whole buildset > while building libabigail. > Full details are available at: > https://builder.wildebeest.org/buildbot/#builders/9/builds/287 >=20 > Buildbot URL: https://builder.wildebeest.org/buildbot/ >=20 > Worker for this Build: fedora-s390x >=20 > Build Reason: > Blamelist: Dodji Seketeli >=20 > BUILD FAILED: failed test (failure) >=20 > Sincerely, > -The BuildbotThe Buildbot has detected a failed build on builder > whole buildset while building libabigail. > Full details are available at: > https://builder.wildebeest.org/buildbot/#builders/14/builds/268 >=20 > Buildbot URL: https://builder.wildebeest.org/buildbot/ >=20 > Worker for this Build: fedora-ppc64 The ppc64[be] worker was offline for a while. Which is why the issue was only reported today. But it has already been fixed. We already saw the s390x worker fail (also big endian) and Dodji fixed it with: commit 4fba6bea177ffa1981b8252f7f1967814b3ecf94 Author: Dodji Seketeli Date: Mon Sep 23 15:55:08 2019 +0200 Fix reading of relocation sections when endianness mismatches =20=20=20=20 When the endianness of the ELF binary differs from the endianness of the host, some byte swapping needs to happen when we read the reloc section to either determine the format of the kernel symbol table or to get the set of symbols referenced by the kernel symbol table. =20=20=20=20 So we need to use elf_getdata rather than elf_rawdata to read the data from the reloc section, because the former handles the proper byte swapping for us. =20=20=20=20 This patch does just that and thus fixes the build breakage that is occuring when running the testreaddwarf test on s390x (big endian), especially when trying to read the AARCH64 little endian binary data/test-read-dwarf/PR25007-sdhci.ko. =20=20=20=20 * src/abg-dwarf-reader.cc (read_context::{get_ksymtab_format_module, populate_symbol_map_from_ksymtab_reloc}): Use elf_getdata rather than elf_rawdata. =20=20=20=20 Signed-off-by: Dodji Seketeli All green again: https://builder.wildebeest.org/buildbot/#/builders?tags=3Dlibabigail Cheers, Mark