From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by sourceware.org (Postfix) with ESMTPS id 3393C3858C3A for ; Tue, 21 Dec 2021 17:28:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3393C3858C3A Received: from pps.filterd (m0246632.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 1BLHK7Qg023697; Tue, 21 Dec 2021 17:28:14 GMT Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by mx0b-00069f02.pphosted.com with ESMTP id 3d2qk2by19-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 21 Dec 2021 17:28:14 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 1BLHGxUk089177; Tue, 21 Dec 2021 17:28:13 GMT Received: from nam10-dm6-obe.outbound.protection.outlook.com (mail-dm6nam10lp2100.outbound.protection.outlook.com [104.47.58.100]) by userp3030.oracle.com with ESMTP id 3d14rvukwp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 21 Dec 2021 17:28:13 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NkntAVTNpXfV3D5qmkKCHKngqxKGz6yhdW7XR2k9sAJvEwfMFTXGksE2SkLBPZfgn4YetICWeO7jcRbmFFKRevUaw/2ZgPMEKyVR7YQKHENgjGUDgY/E8EFahQk3HZTvXg78ati97/iQ4tMVgCbF/u4mSrqt5cTn7zAxIn2PpvFG+en18zvAwF/Xj8LiNZQqZ8LuD+l7u58r62fEUgNfpRCdlvR02X9Pf2h54fnk+J27RfxPI7+8nUeYd3j2S+uCatzTfXb5yc5wmjuYa3Mp4ofEah5h5Lq1NJt3OSB8CepvVhpL47KkN6ZO+nwByVXrxfrauFMV16IdRDoZ2TCXoQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9FSvTFYZ1bIt/pVGvscuLWlNgBpeHbpsDJeSLtmlvWI=; b=DYGwkaBFaRHa74v9bUaMVEGJuS2zbbYOnZinGvcpJCI6mFV2IR3y+3zH7EtNKwgFx2YlmAIFmzQMj1yfSzWWmRsVN6CmM7UDYmxeK7G6GsNZk8yFdy5JBgqPrSQWc8Zf+VPUy/LFutFK0mNt+1F0G5l+UwbJ8LlhyJRv42jLjpmK+6DV7vUDz4a2j0Uf+zjnOKSiL25oQRz0uiinUqJFMaezoAlG3OuyQfOTj/0oKoxCYimG4n1ig7lSars0Aig04Z/C98C9MXNYsyIs/5SwRwR9FiV97HPvr5LSLPCv+ZJ0v3eTL1HMKa6f8LetrQAuWI1u7QOjjW3bQEdyjcrJSA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none Received: from BL0PR10MB2852.namprd10.prod.outlook.com (2603:10b6:208:76::22) by MN2PR10MB3919.namprd10.prod.outlook.com (2603:10b6:208:1be::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.17; Tue, 21 Dec 2021 17:28:11 +0000 Received: from BL0PR10MB2852.namprd10.prod.outlook.com ([fe80::6927:5e6b:31ff:14bd]) by BL0PR10MB2852.namprd10.prod.outlook.com ([fe80::6927:5e6b:31ff:14bd%3]) with mapi id 15.20.4801.022; Tue, 21 Dec 2021 17:28:11 +0000 From: Guillermo Martinez To: "Guillermo E. Martinez via Libabigail" , Dodji Seketeli Subject: Re: [PATCH] ctf-reader: Assert on ir::hash_as_canonical_type_or_constant Thread-Topic: [PATCH] ctf-reader: Assert on ir::hash_as_canonical_type_or_constant Thread-Index: AQHX7XEPZ3bb8FcW7UqLD/fiQ5K1paw9Mxb6gAASRQA= Date: Tue, 21 Dec 2021 17:28:11 +0000 Message-ID: <4083835.gyKPWaj1Z4@sali> References: <20211210025252.2309157-1-guillermo.e.martinez@oracle.com> <8735mm7ws6.fsf@seketeli.org> In-Reply-To: <8735mm7ws6.fsf@seketeli.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 4c4a921b-b7ff-46c4-1a88-08d9c4a74326 x-ms-traffictypediagnostic: MN2PR10MB3919:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: WCTpGaSIpRrl0PIp8oFKXqvSYJPzhuy2SsiPZt0q0/KvTYpR6BrQl0y3xbYFCKGPRIYPNdYWt/PyaQVedYZBE8LLzY2+/M8vtFrUn6WipOLv1vxJRO/ky9lcFOFl539BtuHxLFd0pMvEqYWxgM+5QtZhU80QaM0Y/32nvA/9TY5yDtJMymJfwLAGw67ZNzCZ8sr/mfpit7vu1mKDK3Lpg9nnXL1Y32rjqDLY310KDs43gBGAlR03bRAFRr71j5ASNbpVtRIdwIO0wZjKEweS45bSzACAu4fJ6OZbxDlpisRuixPM6joqsx/+pURQYbD3qBc7ORyppieZtU6PX4okcwssHWUezDSIdXWZELBw7gxE2Ljnh8Ww6XgwpCFI7GYOcj5Na3iO8nHuyJygT6E7WxiebbHdwwUdeozKdrdXQ1lzxNvR35omxe2XBm0n5zCvNRooP3WVAB8yZ+e2xOzQvsjSJ4TYytNm+QcYGaGqvo1/KZeM8i6lHQhShFxrhXCSSFgeiuCsXiaSXp96dVjSEbrRQmGrR0SVabro2zfM2pSxlr5pZtzwG1kjGntQ6dawZvZUTamr/8LQLTgGzUFuZnLETp0ueJeUxbVfZCI9tfPeL6XnnT6/FXyKO67XhmaCgqqrtKgexviOT/6lQ/eUiHUkKwzr/bpr9l6FtoISwgR4awrByLT0a29HoSHHanv59iJSr6HUqzsZptk0F1gAi7PulBbsq4vp+RBYRY6Wu+Q= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BL0PR10MB2852.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(7916004)(366004)(122000001)(38100700002)(76116006)(2906002)(5660300002)(86362001)(33716001)(38070700005)(53546011)(66476007)(6486002)(6512007)(186003)(66556008)(8676002)(6506007)(71200400001)(508600001)(110136005)(26005)(8936002)(316002)(64756008)(66446008)(66946007)(9686003)(91956017)(39026012); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?FPqO8C0jPHgqJP63fDR/Ka8jgQ5vyGaQXlVfkPKq/dt3/lyyc2gs4+y66I?= =?iso-8859-1?Q?8tiuGKjwBXNK1H21Az4neCBxqXnGdeR309UKajoeVI9zZg1o3DRElafPVj?= =?iso-8859-1?Q?1aaeUPx+fBSUW4+GLOe/QGIBfnOud8OyHqlRO5y4K5lpl8AM9lSVUDKCsA?= =?iso-8859-1?Q?BDJDeuQQ3k2bHpS6dxBfKukOXFgV0a+vlMvgR5KVE3G2IxPUxyHnzL+wU0?= =?iso-8859-1?Q?GLkR/wbuwh78updCLe4cTSB6ECW0LKPVjnD4NHhHw6mvynKmfuRJlzD0MG?= =?iso-8859-1?Q?fu/x/aKohOb2HRNustUQIiIAeqI98lkUdv7yFq9NxO0qHJdVqpecyOs36m?= =?iso-8859-1?Q?13rqajG20GY9rPbBr9JNHKbiE2gkN2W1uOv9IF1izq/DOJG1Yfcvr/jvv2?= =?iso-8859-1?Q?mvCO8VKZ1+Fhq9JlGZ4YODoRMKN39cwUYa3NTvXRWSOX6f+lRlH+Bvz/sz?= =?iso-8859-1?Q?DrVFsBBjLr1lz9EjueTQOJ8XpaLgJxUNrST5fk8CwaUAxuFvh7tR/xkMcE?= =?iso-8859-1?Q?5cVdzhfWatniKelA+vGU9nBRZInQW/oT+D9vvaWmZl51cwTlA5/D0+zgkd?= =?iso-8859-1?Q?faJ3P3DG8m31DegEb94DzUYfyjM0s1+wFe6AsP/ycn6Lik7TwopeyLpsnu?= =?iso-8859-1?Q?AW4hDZV8Ws5YYw/JM5D8eXk+sjNvQ8KgisFoVWcGpwT4JEr9fc/JbhuYdZ?= =?iso-8859-1?Q?r4VhQ4vDLbjRjU6OU2gKqEyln+ZkGB0vyU4HFYPxLFB0OzbXp32HcELRJq?= =?iso-8859-1?Q?KXkvOnqyiaFPNTY20gX+hPX8WuJtHBbtEVHkQCT6oC+AfSLGxtYvq6hn6a?= =?iso-8859-1?Q?g+TNt4QwFlKMMNT4n1CrZZTF25jmQVDWhkk47lEaFBZa4zVOWbBJD7J6uZ?= =?iso-8859-1?Q?NHveL7MakwZcRr+wwJlPuPWLmkfo04PKJJ9cbOh/bsfqG71LWdPfvqFGSz?= =?iso-8859-1?Q?6uXzZ/kilDE+owfMrGPydVD1h8YlAJZ6nx4P4Nf8A7lKHX/Gheov8X2RWy?= =?iso-8859-1?Q?aU7DLWm2m1GAKjPccfA+sSeyes1I2mlm6K9+pxoTm2gMJTuZAqLRKHsF/S?= =?iso-8859-1?Q?oo/4HKkokrTdRB8qPJ0QFbV36rPvw7XtJM6TXj18yuI/3KLOSmyVxBf997?= =?iso-8859-1?Q?rS7XNuHwngdkBUM/7744sWR1UMIo/dWIxxcSYfBoc7k/+UK0kUo9+nofqP?= =?iso-8859-1?Q?0ADJhNRx2egwkXQTpRMz+39wPLsCfOptXGfEalYfxz401BlEl+Jv0X9O+/?= =?iso-8859-1?Q?6eE3MXct4MQfZzpDtB8FsPoslQfIai3aZfVO8NUzJnZHS5gu95ro+sDx2G?= =?iso-8859-1?Q?JBEk2jQJ+C93AEpQzHpwq5LpmNfR/+Pir/GWFpt0t8111FPX5E5hb60kVZ?= =?iso-8859-1?Q?VWevpHPvSfAHMiDYc8VXzXaQZBUOA+k4sqys9I1Y7xN1/Cinh8XyiTIuuS?= =?iso-8859-1?Q?FWkrAaRLSu1qutHZPn5KvIYmGWMlbL8Zvgz/FmNMtV7WyqrS2N/SoVHGAh?= =?iso-8859-1?Q?Usb4Kl1ld7vsTZwUf3zWU++W+69PZSwY028lT0xUUB/9ysZKRZTZ1gOnEX?= =?iso-8859-1?Q?mCzZ8BW1Mx9XE7WO2ADG1VW95S6jxlw/qWT8IxYR0Eh7GtsbyXjv1xs6dl?= =?iso-8859-1?Q?MC+bMM/yvQXZloL6Wd/OODRrsTpBSy+0dXyyMIPdIBNzeqB37OcKyj/o9p?= =?iso-8859-1?Q?iC0YVyGXwUSqYTMMG7gj8rcqkmdXlTLzC94gihJW/SKvCsRIZnab01rzFn?= =?iso-8859-1?Q?l5xHXGSr+phLHqHXc8j7oaQzM=3D?= Content-Type: text/plain; charset="iso-8859-1" Content-ID: <665E9F6858AD7B4FA4EA19292114BBB0@namprd10.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BL0PR10MB2852.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4c4a921b-b7ff-46c4-1a88-08d9c4a74326 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Dec 2021 17:28:11.3919 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: L4PP8fH93ktMoq22GLCZEhH5gz5GbWwK+cvwHnkroN09nqXrJ1Vij8DYGeP7eyVbNiEZ2CGcxp8qckCvKCyQSoGT753gvZGQ/5omPGQT4jw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR10MB3919 X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10205 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 malwarescore=0 adultscore=0 phishscore=0 suspectscore=0 mlxscore=0 mlxlogscore=999 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000 definitions=main-2112210086 X-Proofpoint-GUID: CqLqt8IVNT9MN7KSxk3Wz0Cq2Ky8wwDz X-Proofpoint-ORIG-GUID: CqLqt8IVNT9MN7KSxk3Wz0Cq2Ky8wwDz X-Spam-Status: No, score=-12.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Dec 2021 17:28:19 -0000 On Tuesday, December 21, 2021 10:22:33 AM CST Dodji Seketeli wrote:=0A= > Hello Guillermo,=0A= > =0A= > "Guillermo E. Martinez via Libabigail" a=0A= > =E9crit:=0A= > =0A= > [...]=0A= > =0A= > Thanks for the patch!=0A= > =0A= > I have tested this patch and I've found some issues. Please find my=0A= > comments below:=0A= > =0A= > > diff --git a/tests/test-read-ctf.cc b/tests/test-read-ctf.cc=0A= > > index b448ddc5..7f5381f6 100644=0A= > > --- a/tests/test-read-ctf.cc=0A= > > +++ b/tests/test-read-ctf.cc=0A= > > @@ -220,6 +220,54 @@ static InOutSpec in_out_specs[] =3D=0A= > > "data/test-read-ctf/PR27700/test-PR27700.abi",=0A= > > "output/test-read-ctf/PR27700/test-PR27700.abi",=0A= > > },=0A= > > + {=0A= > > + "data/test-read-ctf/test-callback.o",=0A= > =0A= > This *.o is not present in the patch. I think the remaining *.o=0A= > below are not present in the patch either. So test/runtestreadctf=0A= > fails.=0A= > =0A= > Also, you need to add these files to the tests/data/Makefile.am file.=0A= > =0A= > As I've said elsewhere in the past, "make distcheck-fast" can help you=0A= > check if the files are really present in the tarball.=0A= Ohh, apologises, I'll do that. Dodji thanks for your comments!=0A= =0A= > [...]=0A= > =0A= > Cheers,=0A= =0A=