From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by sourceware.org (Postfix) with ESMTPS id EFE3D3858D1E for ; Tue, 29 Nov 2022 18:53:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org EFE3D3858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com Received: from pps.filterd (m0246617.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 2ATIYr55031378; Tue, 29 Nov 2022 18:53:30 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date : subject : to : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2022-7-12; bh=ElXdhh3BjfNL3ev6yPdDmnxz0o2NFghrz0nPlaa4BL4=; b=r34T+xv628d6XFLJ0x3AIyVe+tvdUeJzkgxEWuhZDO5tZLvATRSUs5WhxY6aHnONhHHS pPLhj3kpaJpvuMYuxgHw1l7R8et1X887QEGcowQmCVA8b4VIaM0I/BGaPi9Fi4F56geP MbnGfeerQRw7En+APczaBq523Xonh0oLwJrzSf+SThdpgf2hLVp75TRXct3iwsaGuf+O LWfJr2MTE870KzubedzK9t/JeuAPea5S7GZa7/FW7tXJl173UHby6l5SCLaHLWK6aTK9 QO4DJnk4UfkPlllTTzBiFrm/3IDnXTVmzpJvF0s0r1loNghQpQLsmM+R11/E9fjLyM6H Xg== Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta03.appoci.oracle.com [130.35.103.27]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3m40y3xs8d-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 29 Nov 2022 18:53:30 +0000 Received: from pps.filterd (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 2ATICnbO019276; Tue, 29 Nov 2022 18:53:28 GMT Received: from nam11-dm6-obe.outbound.protection.outlook.com (mail-dm6nam11lp2176.outbound.protection.outlook.com [104.47.57.176]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3m398dycnk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 29 Nov 2022 18:53:28 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KaHmxEUSg2oLaEkS5PNBhXYoKfCuTznspM4n6OUMXZSAPS/KixpbxNnHbMIhCh1C+M0O7EYomQNvnbXETrauxDbDOhUJvY1mIGzpLRH+m6jSKI5KurqEDbVheMjWyJC6LiyEiNUbB+F0HjSSHvxhfz2aSk3j1ejTuum5YPVbGfGKghsiGb7n3hSY06NGXOlh7yS3FqulbFmU66qMDqwo6XxGjZL6tWbTZQZ2npkuQ/tAYYe7ucyidYGSZscRWvQpCh/yO/b+KgJyxkRfLtBpw/EU+i0P9/R/02qa/iaK7Fnqyvo3hGl962bph6qdGaPMROgCo89njHPq3jZzWDn8zA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ElXdhh3BjfNL3ev6yPdDmnxz0o2NFghrz0nPlaa4BL4=; b=kBqU12LJ7/94kw89645WSxbHmdvA2dzzGODMZCvgdr3lW2GduEQJILBfml6nlnlm+6SRg/OmqW+i0XaTbaMhpCUZ+xkTHibJRFRcL0xj1rPFyor830flag7jAGRx+UDnmc2GqGmvOvxbQHCzJ4uHyW3T8GNLz65I/DTnXbJirXgZQG47KTHROUCWtQSRYkX2Q6LoDkgSm7E9i0915t2DEL4LrGeZa2Td5smg3EYmMCIavvPMFjzlALV6SyDkSzxyjZ2UCW4vrE9WvV4JZWKeoBV176MjRwYQf9ITKMr4qre8VUjUy+4hDVY7z9jIPjj+ouRLHeQr7GyC/L7Hw/ZxJw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ElXdhh3BjfNL3ev6yPdDmnxz0o2NFghrz0nPlaa4BL4=; b=OhorxqP1zKdyR2NfE3YMB89EblrQYopz2/Gvj8ap2OkDp6AFXi0hxqaNyX1jdnLnMoaE8Pd1BesAG7MU0Cv8ecy4JBPICeGWOAW236qS14OoyoHMCOZJ6OVUtZKLWejdkL1ETQSWGK4vlfzWIy7YQOT3GVtQwiJz2dDjbebYSMg= Received: from MWHPR10MB1407.namprd10.prod.outlook.com (2603:10b6:300:23::20) by PH0PR10MB4597.namprd10.prod.outlook.com (2603:10b6:510:43::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.23; Tue, 29 Nov 2022 18:53:27 +0000 Received: from MWHPR10MB1407.namprd10.prod.outlook.com ([fe80::931c:1fd0:72a2:dfd2]) by MWHPR10MB1407.namprd10.prod.outlook.com ([fe80::931c:1fd0:72a2:dfd2%10]) with mapi id 15.20.5857.023; Tue, 29 Nov 2022 18:53:26 +0000 Message-ID: <478886ff-7a15-9dd7-c20e-4af7b713637d@oracle.com> Date: Tue, 29 Nov 2022 12:53:24 -0600 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH 2/5] ctf-front-end: Fix size and name for underlying types Content-Language: en-US To: Dodji Seketeli , "Guillermo E. Martinez via Libabigail" References: <20221117034305.184864-1-guillermo.e.martinez@oracle.com> <20221117034305.184864-3-guillermo.e.martinez@oracle.com> <871qpmou3k.fsf@seketeli.org> From: "Guillermo E. Martinez" In-Reply-To: <871qpmou3k.fsf@seketeli.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: SA9PR03CA0024.namprd03.prod.outlook.com (2603:10b6:806:20::29) To MWHPR10MB1407.namprd10.prod.outlook.com (2603:10b6:300:23::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR10MB1407:EE_|PH0PR10MB4597:EE_ X-MS-Office365-Filtering-Correlation-Id: bb69db81-889c-4800-9f66-08dad23affb1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: UpDNbcHCcD0AejAqieHQ0WBPQWjWXFpFutUQ4J/DbICUxVY/2lUV6tccpwVsTNI6UAl7iYJzcQOyJTYOb3GsmeqQ3zfWbjl+98H73XBwaQ0CCy3M4jLwc86Mz2F/lWeviH2DN5OnYg+/QLyAhHDF9iEQmsG9SX+2WYUemok6vsc2K7osk0FzRMzQKV/sJEjzZISqpHoN2fDnfv4cYP+oH54qfWiylmF+cMThBnVvzKDd2zwWMYa7eG56mwJUkXEz0S6S+h0vz5q+yXihO7dNWYTTU0grKLIB8AVdFMsGqHKoKGnyGVLWG3K0XK0NjUn9pm5nNio6Nws2CLxm6XNeTsAfeTGoXxCKXjG3bEp+Ofb6f/BqhkmFlfMzvhng+YdOG31PoX7WqsfR6xfXnShH7ViT0HozT0KlVGb6pReBjDnbZBasVNuJZhS+Ul6V/va24QCdzX2LSWN7/hR0AfthHqvRTU/5LQ+YVEbAHGFHLfSPtTcb/Kenjz+3V4u38GD/ilRnZoO09sKaexRKeiLnXVhAp+nms7gDF/FR0TNGwDTX95Tdzt0agE/eO0/mZWNNx7H+N8+GDT/JCsht8NYuT97tq6NnoK0umHS2zSxZCbtyw8PL2jkN1dbHaSnaQ/NOzxMJ5Sw84ZqSmJ2+O1UsEsDe7378El4cp9dudWWJrZ4vVcs0NZQLq4g079dRxpt6upfvaUnwo9ymAygqjzlGx9dKjkSzHkc/UY8m4bSCh6sCYPneNi0S7Mz/SO0T16bM X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR10MB1407.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(346002)(376002)(366004)(396003)(136003)(451199015)(38100700002)(83380400001)(31686004)(6512007)(6506007)(110136005)(966005)(6486002)(86362001)(31696002)(36756003)(186003)(2616005)(478600001)(8936002)(8676002)(5660300002)(53546011)(66946007)(66556008)(41300700001)(2906002)(66476007)(316002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Tncza3B5b1lmeE1IVkxmNUNwcWFUeVJ6WDhQUWVNQVpILzlqV3N0a1NMVDVS?= =?utf-8?B?SDlTMEtMUElyY0w1eExBVWRreUpqTjl1OW9NcFVaeUs2NjUvVmhCRjI3b0k4?= =?utf-8?B?SVRFOURVcUVLQVB2TFdCckdwc3o1Sm41cEVxTDNhVmVOd3MvaWZpNEZaTVUz?= =?utf-8?B?OWYzeXlFb3ZhZUZUNlI3d09LVm5qbzFJVkFXTDk5TkRYdjFNOUxKT2dsY21F?= =?utf-8?B?Ui80VW5TR0FVOEdrODFEcVJxOUJOOHBSaWdDa3JaSFRpQnhKUnRVVkdkWHgx?= =?utf-8?B?dkhCcjFPdHBXNXpuY01EZXdkQzUvaHBIT084dndDdEpjNWVYNnZqNU92MWpU?= =?utf-8?B?cTJJSWQ4UUg2aFNzQ3ZBODNlbCt2N0NDOXVDUW42VGVHdmRyNnpuc3NKcHZM?= =?utf-8?B?bVJ0Q3hKSkc1VUQybE82TTF0TmRVR3B5dFhKT28yU28xUzRJaGZGY1pQY3R3?= =?utf-8?B?bjZXQUpvbm5TQzVLRDBJOCtrUFhBcDB0RnlmNlNHRnduVDdHUmM5Z0hKQWQ3?= =?utf-8?B?R1VLTU5KT1AraHBmQnlWZ3V5dVcyQmg1YS9XNitTRm4rMG5MbW9GaHVvYzQy?= =?utf-8?B?dnR6eUpSNkZvNWZHajhsTno0NVVZdkkrdjFvVzF3MlpvQ3E2bllwS2UzOVg5?= =?utf-8?B?OFI2eTQwVGlGbEtNZW1iN3F0MnJMaENDazNnY0VIZEt6Uk1sdXNhbVVmZ1lt?= =?utf-8?B?UFRlcWtqaEwwYUFkanl1L2Q4d0QyT0ZEK0FBdGt0SjRxZlMzcEVwbnI2SGw3?= =?utf-8?B?WFVxM1pEdGo1VXVJUm9ROTFtbTY4YzJMdk15c3lsWVVEY2N2QStIbzJpR1FE?= =?utf-8?B?QkY3S0hpdDZUSXk4TjJOaTVwZFlIZVdPazJIQmlVTUQ2SkNHM2JXM3h1ZERZ?= =?utf-8?B?WThjRytTaW9UbUlXdVVVRlpITTZ5azJlY1hCL0hlY2lsTC8yV1JUZTZ4S054?= =?utf-8?B?Mk9WV2dvUnV0ZWVSQnBSVjNLaUNiQmVSTW10cVhNTDhYcjBWT2V3TmdjL0tO?= =?utf-8?B?cW1maTdlVWQ1Qkc4QjZWUk5wSlhzbEhKTU5DQ2p2Tk9iWlhNVTJ1SjJrMGJy?= =?utf-8?B?bU8zRlNRL2JTaTgrbERqU1ZpWUh0SVhZYkpqYmEzRm52ZEJkdEhqZVczTjFN?= =?utf-8?B?KzI4WkduWTd1ZUdFWDRPdVh1OWlQd0lIVU1BUlBZWWt1citQSTlmY053Z0h6?= =?utf-8?B?S0p0U05lQ0htbjhYeGwwbHlyd3RJc1dmcVFxUXBNYWptNmNQdm1FU25RQWVW?= =?utf-8?B?Q0drVE1MMDBxZ3c0ajBKWUhmNDR5Yk5vL1c4SmdxeW1JUUZWbFg1d0xiS2Fs?= =?utf-8?B?WitYM0gwZmE5Z0xMeTVhc3R0V2hrVStQRTRSY2RPSEp4NnEyazgvZ3NsRkto?= =?utf-8?B?Y01maFNXUzRFU09xcVozWjFjby8rV0NpalAzQTcvcDd6cm9uODQzcVVuZ3BW?= =?utf-8?B?ZFlXaC9xckF3VEpWMktJL2ZERXFvQ2lMeVl5UDFMaURzdW84UlMvWXBSN1hi?= =?utf-8?B?QVhPNDQyREtKdm01VFZCNEE0Ujd1VzNKM2lMbVNjTWdicExFUEsveGI4NUVZ?= =?utf-8?B?YzR3Ny9IcytaT0JnVXFSRzM5ellBbHlacW9wWEJnVG42RVFibXBONy9nQVkz?= =?utf-8?B?QXVJMHRRSUQ1bHpSZlFUM0hESC80V1N5aTFEeHFWNWJneTdBb3pYWFcyZ1JZ?= =?utf-8?B?cHJuSk5RQ3lhSi9NL0FHRVlROEdPUURVRFZERGlJMjVQTWY2c2ZCb3NuYVo0?= =?utf-8?B?SlJUaWhWdm0yZHA0eDJ2T3RQc2ZZWDJMemkzTGlkdkc4S2Z6TktwdzA4UWdj?= =?utf-8?B?YTZjZjg4OSsxTHQ4UDlZWGV5YzFPdkdHWGpyQjNMWlVGU1Y5dzJkQUd1MFp3?= =?utf-8?B?MmZ5TzBtdnNIVVkrRTd6NDJheS96K3dOeGZxQkM3MXMyNTRjZzNwbDNLRTk1?= =?utf-8?B?cnhBbEh6WkR2NGMyUHlHbE9Td2FsMDNsc2xWSGRidnpPUUY5a1Bka1NrRlhn?= =?utf-8?B?RXFmVXY0My9pa0NQMThydEY5OEg1SlZXSlBRTVpybXo1RjA3VGRBRDFDL2pC?= =?utf-8?B?Q3BsZnUvQXBEZ2NvcTAwaTRUZmFTR201UmpTbU9CcGllMDl4TStXN1hpc2to?= =?utf-8?B?cnh6djNGZHhsSFgwdEM5VUFPUWFUaHA5Z1FvMEJjR0d6M092eFNEeEFwVWti?= =?utf-8?B?ZEZIakxRZkNMZ2l4ZlB0anUycmpvdVUrdUFEYnM5cThkY2taYldtMERmeXhZ?= =?utf-8?Q?g0EX8RwPSh2Y3aEUOJkyoDI/1NEHxaHLH0X/g8FI8o=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: vX/X5hUYT6b8FyQi2/v53iOsQNmJeMnpsgufdnCFIG9E4dayyFf33m0SEhbFxyNYu9eCk4ExBX87yXrUom/33U+NjfM8yJjHB69009UNQftvcqqAf+oWw8pnBekcjwKgOniOCQGGKB1cQtot+0510WXVBNa1WMYzIuAiW3QV1sCwKBJRwyliAwcB/sVHnR8nmd0B71kT5IglLxJtza+x4cXBKXidXmuDF0xw5iHVC1TAwJhF8/uaQJSuqdh3+nBSvc+lQWy9B+J99DU74letHTvvvxRorIrkfzZIA6R+ugVpbGxA3I7AmcQoI9fTeYRB7nbK+hBtTlA/cjFxQrnIiFdXuadPUBlfhww6RXYCxCWu5revhH/14vH/xVek7MpsV1TJTVh4B7INlpkQIBeawm8KNeN2XVbUp5Sx0dgkYiDlrlKWy6TWBHOVBWMxkQHaPMCH2aajOGWdjjdEw/CuM7DHQ+3YB3QJcKHhyNrRKdZSFYdd2iWx1IJT0uMzZhU8xr+ps07BaAOPHeo5hHyX2bJMpGDoTIGPLSjfrrk+HyQICQ07Rx9FtD+JfH2b8i/avsjs1hEOmWFbCC6RDSiTyiaDpsQhFtis46vxOCNOwRAwq3bFfBb5QjkQk04BRCyFeQ5m4XlrijxngFvAzZtaW7x3gbFjA03SfIuaOZN3vbLTs9q0Y/5jSahbF8cVVHZhbI75tbBSmltS+vFjSrXqUqxrk2Dy5Dq96Qh62XTgbSjL3IlC66yzXNXoJMNfJ85Y8YOO1e43BNJpLhfUhRVn6YJ4ocWTCRashufyesLPpJQ= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: bb69db81-889c-4800-9f66-08dad23affb1 X-MS-Exchange-CrossTenant-AuthSource: MWHPR10MB1407.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Nov 2022 18:53:26.8144 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: geduQt6I2u5V1FX65HLq3WTQHvBTGIg6mVHAfAkiKlTmGtYgxi9Xzux651mGVW+FM2SHh8xM9hr9zlWvTAdhDFsyvLDysKvqzFIrnLCPazc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB4597 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-11-29_11,2022-11-29_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 suspectscore=0 phishscore=0 mlxlogscore=999 mlxscore=0 adultscore=0 bulkscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2210170000 definitions=main-2211290108 X-Proofpoint-GUID: tvoGFwTRqnVzGd-vCgVfojhEnwAd2nPB X-Proofpoint-ORIG-GUID: tvoGFwTRqnVzGd-vCgVfojhEnwAd2nPB X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 29/11/22 5:53, Dodji Seketeli wrote: > Hello Guillermo, > > "Guillermo E. Martinez via Libabigail" a > écrit: > >> It fixed an incorrect representation in size and name for underlying >> enum and struct types when it has a bitfield members: >> >> struct foo >> { >> unsigned bar : 2; >> unsigned baz : 1; >> }; >> >> >> >> So, `name' empty property, no showing the right enumerator's type and size >> in bits: >> >> > > Hmmh, I think here, the name should be "unsigned int", because "unsigned > bar" implicitly means 'unsigned int bar". And the size-in-bits should > be set to 32. > Oh. Sorry, that's right. > I have thus changed the introductory paragraphs of this commit log to > the following: > > This patch fixes an incorrect representation in size and name of the > underlying type of enums as well as underlying types of bitfield data > members types. > > For instance, consider this struct. > > struct foo > { > unsigned bar : 2; > unsigned baz : 1; > }; > > The data members bar and baz have an underlying type that is "unsigned > int". Yet, the CTF front-end represents the underlying type of these > data members as: > > > > The name property is empty, and it should be "unsigned int". > > The size in bit is '2', but it should be the size of the underlying > "unsigned int", in bits, which is 32. > > In other words, the underlying type of bar and baz should be: > > > > Note that today, libabigail doesn't represent the bitfield properties > of the data member. Those bitfield properties are properties of the > data member, not of their type. This is a known "Not Yet Implemented" > feature request that has been filed upstream at > https://sourceware.org/bugzilla/show_bug.cgi?id=27334. > > Similarly, the underlying type of enums is not properly represented by > the CTF front-end. > > Fixed thus. > > It's a little bit more verbose, but hopefully, that should give a little > bit more context for future code maintenance. > Totally agree. Thanks Dodji. >>[...] Kind regards, guillermo