From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gnu.wildebeest.org (gnu.wildebeest.org [45.83.234.184]) by sourceware.org (Postfix) with ESMTPS id F04BC3857C4E for ; Tue, 18 Jan 2022 13:14:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org F04BC3857C4E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=klomp.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=klomp.org Received: from tarox.wildebeest.org (83-87-18-245.cable.dynamic.v4.ziggo.nl [83.87.18.245]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id 72CDC30BE62D for ; Tue, 18 Jan 2022 14:14:17 +0100 (CET) Received: by tarox.wildebeest.org (Postfix, from userid 1000) id E2BC140006D8; Tue, 18 Jan 2022 14:14:16 +0100 (CET) Message-ID: <498b857811cbb744b017c0d00b42dc07e375a7a9.camel@klomp.org> Subject: Re: [PATCH] DWARF reader: use size_t for more DWARF expression length From: Mark Wielaard To: libabigail@sourceware.org Date: Tue, 18 Jan 2022 14:14:16 +0100 In-Reply-To: <20220118130354.8649-1-mark@klomp.org> References: <20220118130354.8649-1-mark@klomp.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.28.5 (3.28.5-10.el7) Mime-Version: 1.0 X-Spam-Status: No, score=-3.9 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Jan 2022 13:14:20 -0000 Hi, On Tue, 2022-01-18 at 14:03 +0100, Mark J. Wielaard wrote: > From: Mark Wielaard >=20 > commit 6e0d3f7 "DWARF reader: use size_t for DWARF expression > length" is a partial fix for the assumption that size_t =3D=3D uint64_t. >=20 > This commit updates a couple more functions where this (wrong) > assumption was made. >=20 > * src/abg-dwarf-reader.cc (eval_last_constant_dwarf_sub_expr): > Change expr_len argument type to size_t*. > (op_pushes_constant_value): Change ops_len and index argument > types to size_t; change next_index argument type to size_t&. > (op_pushes_non_constant_value): Likewise. > (op_is_arith_logic): Change expr_len and index argument > types to size_t; change next_index argument type to size_t&. > (op_is_control_flow): Likewise. >=20 > Fixes: 16207c4af7bc ("Bug 28191 - Interpret DWARF 5 addrx locations") > Signed-off-by: Mark Wielaard Sorry, this is equivalent to Giuliano's patch in=20 https://sourceware.org/pipermail/libabigail/2022q1/004114.html I was confused about was was/wasn't committed. Cheers, Mark