Copy that, thank you for reviewing.

















At 2022-09-20 16:22:46, "Dodji Seketeli" <dodji@seketeli.org> wrote:
>Hello,
>
>Xiaole He via Libabigail <libabigail@sourceware.org> a ¨¦crit:
>
>> In 'src/abg-reader.cc', the function
>> 'walk_xml_node_to_map_type_ids(read_context& ctxt, xmlNodePtr node)'
>> find all of the child nodes of 'node' that has the 'id' attribute,
>> and then put the child node into map where the 'id' of the child node
>> as key and the child node itself as the value.
>> But the comment for this function writes:
>> /* src/abg-reader.cc begin */
>> /// Walk an entire XML sub-tree to build a map where the key is the
>> /// the value of the 'id' attribute (for type definitions) and the key
>> /// is the xml node containing the 'id' attribute.
>> ...
>> static void
>> walk_xml_node_to_map_type_ids(read_context& ctxt,
>>                               xmlNodePtr node)
>> ...
>> /* src/abg-reader.cc end */
>> The second and third lines of the comment above says the the child node
>> as the key of the map, but it should be the value of the map.
>> This patch fix the problematic comment described above, from
>> 'and the key is the xml node' to 'and the value is the xml node'.
>>
>>         * src/abg-reader.cc (walk_xml_node_to_map_type_ids): fix comment
>
>Thanks for catching that typo!  You are spot on!
>
>I've applied the patch to the master branch.
>
>[...]
>
>Cheers,
>
>-- 
>		Dodji