From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <mark@klomp.org>
Received: from gnu.wildebeest.org (gnu.wildebeest.org [45.83.234.184])
 by sourceware.org (Postfix) with ESMTPS id C3AAA3858405
 for <libabigail@sourceware.org>; Tue,  4 Jan 2022 14:51:50 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C3AAA3858405
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=klomp.org
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=klomp.org
Received: from tarox.wildebeest.org (83-87-18-245.cable.dynamic.v4.ziggo.nl
 [83.87.18.245])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by gnu.wildebeest.org (Postfix) with ESMTPSA id 2C8D33000648;
 Tue,  4 Jan 2022 15:51:48 +0100 (CET)
Received: by tarox.wildebeest.org (Postfix, from userid 1000)
 id DE46C400E962; Tue,  4 Jan 2022 15:51:47 +0100 (CET)
Message-ID: <4cd065ae39c835fcd54dee196f900c778a91c334.camel@klomp.org>
Subject: Re: [PATCH] Handle several variants of Python 'imp', 'importlib'
 modules
From: Mark Wielaard <mark@klomp.org>
To: Thomas Schwinge <thomas@codesourcery.com>, libabigail@sourceware.org
Date: Tue, 04 Jan 2022 15:51:47 +0100
In-Reply-To: <20211221194117.2386192-1-thomas@codesourcery.com>
References: <87zgouvskb.fsf@euler.schwinge.homeip.net>
 <20211221194117.2386192-1-thomas@codesourcery.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Mailer: Evolution 3.28.5 (3.28.5-10.el7) 
Mime-Version: 1.0
X-Spam-Status: No, score=-3.9 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL,
 KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS,
 TXREP autolearn=no autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: libabigail@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Mailing list of the Libabigail project <libabigail.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/libabigail>,
 <mailto:libabigail-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/libabigail/>
List-Help: <mailto:libabigail-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/libabigail>,
 <mailto:libabigail-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Tue, 04 Jan 2022 14:51:52 -0000

Hi Thomas,

On Tue, 2021-12-21 at 20:41 +0100, Thomas Schwinge wrote:
> Fix-up for recent commit f0582fdbf1267f0f34bf3c3b6698b60026410146
> "Replace use of deprecated Python 'imp' module with 'importlib'", and
> commit cc1f38ffedb8d456d43fb52c369409037c5ca4a
> "Replace Python 'import importlib' with 'import
> importlib.machinery'",
> because... compatibility.
>=20
> Once more, I've asked The Internet what to do about that, and this
> commit is
> the result.  But beware: I'm still not much of a Python wizard.
>=20
> 	* tests/mockfedabipkgdiff.in: Handle several variants of Python
> 	'imp', 'importlib' modules.

This variant works for me on a CentOS 7 setup.

Thanks,

Mark