[Patch] Adding function added_variables() into class corpus_diff

[Patch] Adding function added_variables() into class corpus_diff

[Sinny Kumari]

[-- Attachment #1: Type: text/plain, Size: 301 bytes --]

Hi,

In order to access list of added variables obtained while
calculating abi diff between two libraries outside libabigail,
no public API was available. This patch (available in attachment)
adds added_variables() method to access same.

Thanks

-- 
     
     Sinny Kumari
(sinny at redhat dot com)

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Adding-function-added_variables-into-class-corpus_di.patch --]
[-- Type: text/x-patch; name=0001-Adding-function-added_variables-into-class-corpus_di.patch, Size: 1689 bytes --]

From ef12afec46a934a49c1e08e5567aac2e7219b9b2 Mon Sep 17 00:00:00 2001
From: Sinny Kumari <skumari@redhat.com>
Date: Mon, 15 Dec 2014 00:45:51 +0530
Subject: [PATCH 1/1] Adding function added_variables() into class corpus_diff

Function added_variables() is required in order to access list of
added variables obtained while calculating abi diff between two libraries
outside libabigail

	* include/abg-comparison.h (corpus_diff::added_variables):
	Declare new member function
	* src/abg-comparison.cc (corpus_diff::added_variables):
	Define new member function

Signed-off-by: Sinny Kumari <skumari@redhat.com>
---
 include/abg-comparison.h | 3 +++
 src/abg-comparison.cc    | 6 ++++++
 2 files changed, 9 insertions(+)

diff --git a/include/abg-comparison.h b/include/abg-comparison.h
index 4213a94..ec89cc6 100644
--- a/include/abg-comparison.h
+++ b/include/abg-comparison.h
@@ -2046,6 +2046,9 @@ public:
 
   const string_var_ptr_map&
   deleted_variables() const;
+  
+  const string_var_ptr_map&
+  added_variables() const;
 
   const string_changed_var_ptr_map&
   changed_variables();
diff --git a/src/abg-comparison.cc b/src/abg-comparison.cc
index 105a58f..c8c7d6e 100644
--- a/src/abg-comparison.cc
+++ b/src/abg-comparison.cc
@@ -10201,6 +10201,12 @@ const string_var_ptr_map&
 corpus_diff::deleted_variables() const
 {return priv_->deleted_vars_;}
 
+/// Getter for the added variables of the diff
+/// @return the map of added variable.
+const string_var_ptr_map&
+corpus_diff::added_variables() const
+{return priv_->added_vars_;}
+
 /// Getter for the variables which signature didn't change but which
 /// do have some indirect changes in some sub-types.
 ///
-- 
2.1.0

Re: [Patch] Adding function added_variables() into class corpus_diff

[Dodji Seketeli]

Hello,

Sinny Kumari <sinny@redhat.com> writes:

> 	* include/abg-comparison.h (corpus_diff::added_variables):
> 	Declare new member function
> 	* src/abg-comparison.cc (corpus_diff::added_variables):
> 	Define new member function

I have applied this to master.  I have just slightly edited the title of
the patch and I have added an vertical space ...

[...]

> +/// Getter for the added variables of the diff

... here.  This is just to comply with how the doc strings are laid out
elsewhere in the source code.

> +/// @return the map of added variable.
> +const string_var_ptr_map&
> +corpus_diff::added_variables() const
> +{return priv_->added_vars_;}
> +
>  /// Getter for the variables which signature didn't change but which
>  /// do have some indirect changes in some sub-types.
>  ///


Thanks for the patch!

Cheers,

-- 
		Dodji