From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gnu.wildebeest.org (gnu.wildebeest.org [45.83.234.184]) by sourceware.org (Postfix) with ESMTPS id E7C453858C2C for ; Tue, 21 Dec 2021 13:43:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E7C453858C2C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=klomp.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=klomp.org Received: from tarox.wildebeest.org (83-87-18-245.cable.dynamic.v4.ziggo.nl [83.87.18.245]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id A7066302FBA8; Tue, 21 Dec 2021 14:43:20 +0100 (CET) Received: by tarox.wildebeest.org (Postfix, from userid 1000) id 7B602413CC9A; Tue, 21 Dec 2021 14:43:19 +0100 (CET) Message-ID: <660b800832668cba9415c01d7cf5ab49438dba98.camel@klomp.org> Subject: Re: [PATCH] Replace use of deprecated Python 'imp' module with 'importlib' From: Mark Wielaard To: Dodji Seketeli , Thomas Schwinge Cc: libabigail@sourceware.org Date: Tue, 21 Dec 2021 14:43:19 +0100 In-Reply-To: <87fsqm84ps.fsf@seketeli.org> References: <20211217222631.2541972-1-thomas@codesourcery.com> <87fsqm84ps.fsf@seketeli.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.28.5 (3.28.5-10.el7) Mime-Version: 1.0 X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Dec 2021 13:43:24 -0000 Hi, On Tue, 2021-12-21 at 14:31 +0100, Dodji Seketeli wrote: > Thomas Schwinge a =C3=A9crit: >=20 > > In the test logs, I've found a number of: > >=20 > > [...]/tests/mockfedabipkgdiff:42: DeprecationWarning: the imp > > module is deprecated in favour of importlib; see the module's > > documentation for alternative uses > > import imp > >=20 > > I've asked The Internet what to do about that, and this commit is > > the result. > > But beware: I'm not a Python wizard. > >=20 > > * tests/mockfedabipkgdiff.in: Replace use of deprecated Python > > 'imp' module with 'importlib'. > >=20 > > CC: Chenxiong Qi > > Signed-off-by: Thomas Schwinge >=20 > Applied to master. Thanks! The buildbot is a little slow being busy with elfutil commits: https://builder.wildebeest.org/buildbot/#/pendingbuildrequests But this seems to have broken something on centos7 x86_64: https://builder.wildebeest.org/buildbot/#/changes/7273 File "/srv/buildbot/worker/libabigail-centos- x86_64/build/tests/mockfedabipkgdiff", line 73, in fedabipkgdiff_mod =3D importlib.machinery.SourceFileLoader('fedabipkgdiff', FEDABIPKGDIFF).load_module() AttributeError: 'module' object has no attribute 'machinery' Cheers, Mark