From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gnu.wildebeest.org (gnu.wildebeest.org [45.83.234.184]) by sourceware.org (Postfix) with ESMTPS id D90B73858404 for ; Mon, 18 Oct 2021 16:25:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D90B73858404 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=klomp.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=klomp.org Received: from tarox.wildebeest.org (83-87-18-245.cable.dynamic.v4.ziggo.nl [83.87.18.245]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id 6A860301B4A0; Mon, 18 Oct 2021 18:25:32 +0200 (CEST) Received: by tarox.wildebeest.org (Postfix, from userid 1000) id 1FBED425A440; Mon, 18 Oct 2021 18:25:32 +0200 (CEST) Message-ID: <68dda582d8a4fd0d58ed355df45e6ceecc18a36f.camel@klomp.org> Subject: Re: Patch for Incorrect Symbol DW_LANG_PL1 -> DW_LANG_PLI From: Mark Wielaard To: "Sochat, Vanessa" Cc: "libabigail@sourceware.org" Date: Mon, 18 Oct 2021 18:25:31 +0200 In-Reply-To: <3FA78256-D980-42E6-87EE-F2CE00957B63@llnl.gov> References: <3FA78256-D980-42E6-87EE-F2CE00957B63@llnl.gov> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.28.5 (3.28.5-10.el7) Mime-Version: 1.0 X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Oct 2021 16:25:35 -0000 Hi Vanessa, On Mon, 2021-10-18 at 15:27 +0000, Sochat, Vanessa wrote: > I tried the gamut of versions from elfutils, down to 0.163 in spack: >=20 > https://github.com/spack/spack/blob/30e8dd95b54bb60b0b696ec85fb7f9b71f5e7= 9dc/var/spack/repos/builtin/packages/elfutils/package.py#L25 > > And no luck. In that case I suspect somehow the build isn't using the right dwarf.h header. It might be the: depends_on('libdwarf') libabigail doesn't depend on libdwarf and libdwarf is not part of elfutils. It does provide a dwarf.h header though, that might simply not be compatible. elfutils-devel install it in /usr/include/dwarf.h while libdwarf-devel installs it in /usr/include/libdwarf/dwarf.h So in theory they shouldn't conflict, unless the compiler has /usr/include/libdwarf on the include path. > Notably, when I originally added libabigail I didn't see this error: > https://github.com/spack/spack/commit/ef9a607c4c3bd01d6bcf3141244fd29 > 41725e92f#diff- > a8ac1d28334e9664af1280644c56095a1ba1160e5cc8b9ceec6ef8ec85491653 so > my early conclusion was that something had changed about libabigail > between the previous (1.8x and 2.0) releases. I simply couldn't get > it working without this patch, regardless of the versions of elfutils > or dwarf that I pinned. Not saying the PL1/PLI confusion shouldn't be fixed (it is a really odd typo), but it is somewhat curious nobody else has reported this issue. Which is why I suspect that somehow your build is using the "wrong" dwarf.h. Because all elfutils/libdw versions of dwarf.h do have DW_LANG_PL1 defined. If you are picking up a non-elfutils/libdw dwarf.h maybe that explains some of the other build issues too? Cheers, Mark