public inbox for libabigail@sourceware.org
 help / color / mirror / Atom feed
From: Mark Wielaard <mark@klomp.org>
To: Dodji Seketeli <dodji@seketeli.org>
Cc: Ben Woodard <woodard@redhat.com>,
	Ben Woodard via Libabigail <libabigail@sourceware.org>
Subject: Re: libabigail 2.1 trunk testing where are we?
Date: Tue, 20 Sep 2022 17:05:13 +0200	[thread overview]
Message-ID: <6ab5b70c95e4c3169ac4ad678e5011baef52f05e.camel@klomp.org> (raw)
In-Reply-To: <87y1ue5t5i.fsf@seketeli.org>

Hi Dodji,

On Tue, 2022-09-20 at 10:47 +0200, Dodji Seketeli wrote:
> Okay, so I have just applied this to master.

Thanks!

> Mark, by the, way, just for my own education, would it have been ok to
> just use gelf_getshdr all the time, rather than using looking at the
> sh_entsize property of the section header that can be wrong sometimes?
> 
> I am guessing the reason why you chose to keep looking at the later has
> to do with potential performance concerns?

I am sure I fully understand your question.

Do you mean if we could have used
  gelf_fsize (elf, ELF_T_DYN, 1, EV_CURRENT)
all the time?

Yes, we could have simply done that. I didn't do that in the patch
because that would have changed the existing code more. But maybe I
should have done that and ignored the shdr completely to simplify
things.

Cheers,

Mark

  reply	other threads:[~2022-09-20 15:05 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-29 18:28 Ben Woodard
2022-07-29 20:57 ` Mark Wielaard
2022-07-29 22:48   ` Ben Woodard
2022-09-20  8:47   ` Dodji Seketeli
2022-09-20 15:05     ` Mark Wielaard [this message]
2022-09-25  7:06       ` Dodji Seketeli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6ab5b70c95e4c3169ac4ad678e5011baef52f05e.camel@klomp.org \
    --to=mark@klomp.org \
    --cc=dodji@seketeli.org \
    --cc=libabigail@sourceware.org \
    --cc=woodard@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).