From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by sourceware.org (Postfix) with ESMTPS id B17463854141 for ; Mon, 4 Jul 2022 16:02:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B17463854141 Received: from pps.filterd (m0246629.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 264D1ugh008060; Mon, 4 Jul 2022 16:02:40 GMT Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.appoci.oracle.com [138.1.114.2]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3h2dwakrbd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 04 Jul 2022 16:02:39 +0000 Received: from pps.filterd (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (8.16.1.2/8.16.1.2) with SMTP id 264Fj9hf039729; Mon, 4 Jul 2022 16:02:39 GMT Received: from nam04-dm6-obe.outbound.protection.outlook.com (mail-dm6nam04lp2043.outbound.protection.outlook.com [104.47.73.43]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com with ESMTP id 3h2cf1fbp7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 04 Jul 2022 16:02:39 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AKOb7XxXLRdwCHPaWp6RCGJt7oSQvcGGFl/N7LKqWtyQfhe6GGT+kWMALOzg/WUtU4SlUwa0enKVC4bv0lBXjaMo+Og7+zl8A9Uze789DUKUTBzW177vexSId2TW3q8e3Ghy1+9MOFnFshsvFQWVCaqg6luC0ZSgp0qQbJQHDScF7yghsBpe29VjgwjZFKJRLKV9u+vdVQorev6GDW+nFGp6ITIUE3INdZvXjRo6hy/KJ4R/3zcKdl2T6hueJe5l2Kqfi4PGImCrvi5iDCSXF2NeJ+1aQW/kxFrlM7CoEjx2+JM6sNgzK21ThN/H6oyuoYFu8J/QEgJSrqcwfOg7xA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=i7cHkHkMv6rfspeGs/sEEPcJpxhwjSZCBRzyIDM9N8g=; b=TSgmDVZ1shb01MXnBX1moFAf8pnHVT8wbCUnDDNuS7bhfcG6ucBCxM4MD1M6zq9ulr/tidGcRRkRQQxZH3sqiHOA41WltpqGP60sdq9HjWSegb1MuuXIl2Nd8LAYv48XTcgWmzguVJ3qQiepIPdmeNT5pMl47KB7wS8FIW5yYjP8nM2mHXmfFnhdPGtSpX+MOc+kF6THPEX3sx2wQAaiTBIzqbNDrb+oMa5FLmwgRU43Cv7Uc9GM8VO8jUdXPcI3GwOay5LJMAyqKRODpi9KEI7vq3lswf0bfXCcvtT5l2GI/ymhpDmd6xRoOF18sMlFYCHaGZkuqCXtH6d7aW+hpg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none Received: from MWHPR10MB1407.namprd10.prod.outlook.com (2603:10b6:300:23::20) by BN8PR10MB3460.namprd10.prod.outlook.com (2603:10b6:408:b4::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.15; Mon, 4 Jul 2022 16:02:36 +0000 Received: from MWHPR10MB1407.namprd10.prod.outlook.com ([fe80::40f0:f59d:aca7:92ea]) by MWHPR10MB1407.namprd10.prod.outlook.com ([fe80::40f0:f59d:aca7:92ea%3]) with mapi id 15.20.5395.021; Mon, 4 Jul 2022 16:02:36 +0000 From: "Guillermo E. Martinez" To: Dodji Seketeli Cc: "Guillermo E. Martinez via Libabigail" Subject: Re: [PATCH] Add regression tests for abipkgdiff using ctf info Date: Mon, 04 Jul 2022 11:01:24 -0500 Message-ID: <7401018.EvYhyI6sBW@sali> Organization: Oracle Corp In-Reply-To: <87edz1cpjb.fsf@seketeli.org> References: <20220623151642.1904752-1-guillermo.e.martinez@oracle.com> <21542305.EfDdHjke4D@sali> <87edz1cpjb.fsf@seketeli.org> Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" X-ClientProxiedBy: SN2PR01CA0039.prod.exchangelabs.com (2603:10b6:804:2::49) To MWHPR10MB1407.namprd10.prod.outlook.com (2603:10b6:300:23::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: dcbf4b86-8fd0-4742-b5d4-08da5dd69d0a X-MS-TrafficTypeDiagnostic: BN8PR10MB3460:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: WOZySqtFTH9H0x06mr9ye3/yKtH/Y4lcDm1btxoO4imOPKWMJNTKsRyxLIdlPtKN+UwlOan89ftrtvQkrVqn9yZ5gGPVv5TadaVuHG2QB2yrSRfQUpweW+a8yMsgYhxV06AFA7iIbUv6XpW7GzD99gel0OtI/Y+zYMy45U2rdBeLI3N+/AnmDK6+u3M1Ewo7ySNaDoFTP2O6EDyndpmAa/fobxPNxYyNSfZcLYY5dXzxSXe9dq3aM6xzWlJyfFLtm3BPfWz98uGFuJMDt/A+8vKchsZSOH+9bH2DfFGvdwejtBUgpFU5NFYkks2beAkhIk4SRQfo+ARkbd35PmZlx1gNctpiauBpHLNHZQP4HYzw9lNhrtAZzCETz8Bl07hhF0s8p6qwvSSrqQ1F5H5apV1ZSWNAhCerOhg/1DN59QBhukUCSNDMOdMIKiv07llFIdgTQ7BRohyIBliDyUR0l0E83yjwCVvpE0b++13xAFISWyKbxEGNvmkqQxmM+dnqtuLPN5oVals2F3h0OkuP17ZJvBdFXp0Y/vkithJeJJJ/hRDR+PUaD+h75JhqmXolzMuXNgpPotFF7jF0ay6N7bEDLNKc1OGxqrvAw7XQ629xAsryOjbC0Sk/zyplIELtFJRmJwnwS4oTXY32UFltltkZdug0rNxlZnlfUXbwpeL9AT45jVd79LUgsncvPOsHcUo0+bivxNxro/LelM1oh5zJWe03+hFms/Hb+4Dl9sruspYMfqzT5mZr+hxxiK6pqP73B00l8PhEGJIY+38k6mlbI+Pvzntz+fbEZp2v+d1SDISMY0l90j802lAg81yToZY7ereaaT3n+kZLzkHGQQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR10MB1407.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(7916004)(136003)(366004)(376002)(39860400002)(346002)(396003)(478600001)(5660300002)(66946007)(8936002)(6916009)(316002)(86362001)(66556008)(6486002)(66476007)(66574015)(4326008)(8676002)(83380400001)(186003)(9686003)(53546011)(52116002)(26005)(55236004)(6512007)(38350700002)(38100700002)(36916002)(6506007)(41300700001)(33716001)(6666004)(2906002)(39026012); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?c0KhMJMP/vIBQfisGeCGLKy0TWdDlw7D1wVjIFBajYYl7AOXTAhZBRf0md?= =?iso-8859-1?Q?r9U3Qz20+kpdM/4iuO1nQGLCOaSJLNVezMiScZSEf+3KqO2XHdFRbrd4HX?= =?iso-8859-1?Q?yQyztD4/56nsJpsMW6xXsC0CPOyOs2kCxYRiSLtRletIHxjnVy/j0w5lh0?= =?iso-8859-1?Q?9gFuMPcGxBjR+8gLAuQFpY/BXvuss6bTds0+CF5/ffF+E5TMfqsly/LObc?= =?iso-8859-1?Q?JJ7ufyo1bjgDWOggf0kh4jHz2TRimP/thW0CSoQfm6apVCTd0H1g1ixaGj?= =?iso-8859-1?Q?ZG1iWywAkPn7WRyMMK2hMJV1McfZa7oqmADWEb91Vfl4rsIZWAck/yk/TZ?= =?iso-8859-1?Q?wiqdiMkOOlNMWWS7OAUFNxVvwOg0K+Q2XMY/OzaLJIXX0bVdcegyQiiepF?= =?iso-8859-1?Q?ythfeYFIBFdM9XZTNmszhDJsLW98uV0FAOlrqS4Wjx3ezhvcYL4pfkGcbA?= =?iso-8859-1?Q?+KG1wpOOToVhsbl4SDUmB8L2w/bpI1EA6VjYYoqsX6xxgxFuenSJCIcVDL?= =?iso-8859-1?Q?2P4fY6fmieaXUepiCqKnt02sjamLn+lt6+nh76J0CmKfDp+hQzlcuVtenQ?= =?iso-8859-1?Q?F+z7umHWihmy3IdOBr+5wWX1mKJKudAsinF0wbaVSVmz1xY0IKty0zBepN?= =?iso-8859-1?Q?aem06bPq9RWpBxNAlnHHwTPxRzY4o00XMT08VvZiOmD6nWqYv8aCYmaHzr?= =?iso-8859-1?Q?6n5+4kxvpLwr/fP+hOoieU5yZKrkhV1ugnzL/iYDAmnmA3zDClGY7PSWmu?= =?iso-8859-1?Q?b+TQUFIN3bbBUIErFiBk+t3vV/Lg2Hp/jkShET4W9qkX5msYRe8yrsqADB?= =?iso-8859-1?Q?Z1uiWsE9h8q0BWk07+JQJXrXq9wAiGW8IcoeoYRRwNz78JgKGvpT1ZEJbK?= =?iso-8859-1?Q?Du0GydO/klwNXH+qt0omD7oS/RKWw8fK36vOhbp8IwZ7NCBTpOsAuf0AFu?= =?iso-8859-1?Q?LD+ZpVARc1mye9l8Q6xcuR3lTDj3Uhn3liwSpQZJBymWDyaKu+rJ0SnvcU?= =?iso-8859-1?Q?EBawVGbLDTScA4Osky53numfmiOTe2fiiJy2wkZ/sVrBZSCPNxlf0FGQ73?= =?iso-8859-1?Q?P1EK1LJUjT+yonOZ5WIxsRdCvImCQpyOz5RAK/7NU1kZ3SUtJyPPWdp7u5?= =?iso-8859-1?Q?E6M2t4ukdo2vw8IHCkMECr0H3pf4PpQr43C6s4HILC4DqoEKn8UVt2b4nk?= =?iso-8859-1?Q?2e4aZXUWgg3S/AbL0vMjHtVAjkG4oWoP2hzKvuczbG14GmPStoH+Mnd117?= =?iso-8859-1?Q?I+QBcaLMUCyHGh9rD1gloBKAmiF5BAOd0Bs3IAqDCQgzvwJyDJFasnl9i5?= =?iso-8859-1?Q?394oyskW2fnueVWYzJYHD1vzN7/klNjXpdF/APf1WvxvD6kJv2Oz+G6ORn?= =?iso-8859-1?Q?kjSdT9Lt8VvbOgKE9ppVXJOdZ4GdcUsh6yhnZOnO0u3nq+JdPxod0txPOK?= =?iso-8859-1?Q?0/O+RQp+oVRBQ6vy8WfpKX5bVTJCoWuN9ElQY40/gAAlxrSMbrwfoxc133?= =?iso-8859-1?Q?G5Q/oK/TrUUjkip1GGGH7UzDYYQ+2OYsRVc1BPpuj0Ai5pWfHvxtFz12WN?= =?iso-8859-1?Q?gcolqDhLwmY3zktY4uS0O+H1UJRkpMxTNesIlt9QO7xkFPMCE1fCDH64Rz?= =?iso-8859-1?Q?LKv4Dkw2kpjmIaMO4Y8klZImd9ys24exIOpxhciUgARqRPjrRmiKzM00tM?= =?iso-8859-1?Q?aeJmj5pkHHYvqJso4Ws=3D?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: dcbf4b86-8fd0-4742-b5d4-08da5dd69d0a X-MS-Exchange-CrossTenant-AuthSource: MWHPR10MB1407.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jul 2022 16:02:36.7174 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: HXujk7C9jTSjfT3rnW1XdEn9ypnNR/EMbw0foTevai3Xtg95wELTlwdXxbUiz0TDrSxDK+hYnCijlRqr9JnOfnzUXAy5XWBlNHAQ1KmgMOM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR10MB3460 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.517, 18.0.883 definitions=2022-07-04_16:2022-06-28, 2022-07-04 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 adultscore=0 phishscore=0 suspectscore=0 bulkscore=0 spamscore=0 mlxlogscore=999 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2204290000 definitions=main-2207040069 X-Proofpoint-ORIG-GUID: PPWuJh1jhuie9kD0TQlRq8XVGF8-3h6B X-Proofpoint-GUID: PPWuJh1jhuie9kD0TQlRq8XVGF8-3h6B X-Spam-Status: No, score=-6.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Jul 2022 16:02:49 -0000 On Monday, July 4, 2022 2:20:24 AM CDT Dodji Seketeli wrote: > Hello Guillermo, >=20 > "Guillermo E. Martinez" a =E9crit: >=20 > >> > * tests/test-diff-pkg-ctf.cc: Testsuite for abipkgdiff --ctf. > >>=20 > >> Why come up with a something else but test-diff-pkg.cc just to test RP= Ms > >> using abipkgdiff --ctf? > > Actually that was my first approach, but looking inside of the acts to = perform > > the abipkgdiff DWARFs test, the steps could be changed in the feature > > (new steps in `perform' member function applied to DWARFs not applicabl= e to CTF), >=20 > Sorry, I am not sure to understand this. What are the steps that would > exist for DWARF that would not in CTF, and that would have to be handled > at the testing level, rather than at the level of abipkgdiff/libabigail > itself? This is a honest question. I can't think of any such case > right now. Do you see any? hmm Ok, for instance CTF support debug info embedded in binary files by de= fault, so no need to use `set_debug_packages_path' (I know, I added isl-debuginfo-= 0.16 .. as unit test entry because nowadays eu-strip remove .ctf section by default= ) , for sure this option is handled in abipkgdiff/libabigail but DWARF and CFT = tests share `set_debug_packages_path' this will make sense just DWARF test in th= e future of course. > > so it was my motivation to split the tests. But of course these are my > > thoughts, and I will follow you advices because you have much more > > experience. So what do you think, worth split the tests for DWARF and C= TF? > >> I mean, can't we just use test-diff-pkg.cc and fill in entries made of > >> instances of struct InOutSpec with InOutSpec::prog_option filled in wi= th > >> a string prefixed by " --ctf " ? > >>=20 > >> Of course, those ctf-related entries would be guarded by #ifdef WITH_C= TF > >> or the like. > >>=20 > >>=20 > >> Wouldn't that work and be simpler? > > For the current implementation, absolutely.=20 >=20 > Then I'd rather keep the simpler way for now. Unless you think there is > an absolute need for the more complicated choice right now, of course. Ok, I will do so. Thanks for your advices!, guillermo