From: Guillermo Martinez <guillermo.e.martinez@oracle.com>
To: "Guillermo E. Martinez via Libabigail"
<libabigail@sourceware.org>,
Jose Marchesi <jose.marchesi@oracle.com>
Subject: Re: [PATCH v2] ctf-reader: Fix length in dynamic array definition
Date: Fri, 10 Dec 2021 03:00:31 +0000 [thread overview]
Message-ID: <8422400.0itGYqGBDL@sali> (raw)
In-Reply-To: <87y257qe7t.fsf@oracle.com>
Ping ...
On Monday, November 29, 2021 7:32:54 AM CST Jose E. Marchesi wrote:
>
> > Defining an array type with dynamic length, node `subrange'
> > in the abixml file doesn't write the accurate `length'
> > property `infinite', instead `1' is written:
> > <subrange length='1' .../>
> >
> > So, member function `array_type_def::subrange_type::is_infinite'
> > is set when `upper_bound' value is equal to `0'.
> >
> > * src/abg-ctf-reader.cc (process_ctf_array_type):
> > set subrange_type::is_infinite when `upper_bound' value
> > is equal to `0'.
> >
> > Signed-off-by: Guillermo E. Martinez <guillermo.e.martinez@oracle.com>
>
> LGTM
> > ---
next prev parent reply other threads:[~2021-12-10 3:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-26 23:17 [PATCH] " Guillermo E. Martinez
2021-11-27 18:03 ` Jose E. Marchesi
2021-11-28 1:57 ` Guillermo Martinez
2021-11-28 1:56 ` [PATCH v2] " Guillermo E. Martinez
2021-11-29 13:32 ` Jose E. Marchesi
2021-12-10 3:00 ` Guillermo Martinez [this message]
2021-12-14 11:20 ` Dodji Seketeli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8422400.0itGYqGBDL@sali \
--to=guillermo.e.martinez@oracle.com \
--cc=jose.marchesi@oracle.com \
--cc=libabigail@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).