From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [217.70.183.193]) by sourceware.org (Postfix) with ESMTPS id ADFF3386102D for ; Wed, 8 Jul 2020 15:30:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org ADFF3386102D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=seketeli.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=dodji@seketeli.org X-Originating-IP: 91.166.131.130 Received: from localhost (91-166-131-130.subs.proxad.net [91.166.131.130]) (Authenticated sender: dodj@seketeli.org) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id E7BF824001A; Wed, 8 Jul 2020 15:30:17 +0000 (UTC) Received: by localhost (Postfix, from userid 1001) id BECBC1A0F37; Wed, 8 Jul 2020 17:30:16 +0200 (CEST) From: Dodji Seketeli To: Giuliano Procida Cc: libabigail@sourceware.org Subject: Re: [PATCH 06/11] Support incomplete enums in core and diff code. Organization: Me, myself and I References: <20200610115940.26035-1-gprocida@google.com> <20200610115940.26035-7-gprocida@google.com> <874kqkuc7h.fsf@seketeli.org> <87y2nuqs3d.fsf@seketeli.org> X-Operating-System: Red Hat Enterprise Linux Server 7.8 X-URL: http://www.seketeli.net/~dodji Date: Wed, 08 Jul 2020 17:30:16 +0200 In-Reply-To: (Giuliano Procida's message of "Wed, 8 Jul 2020 11:39:56 +0100") Message-ID: <861rlmvxbr.fsf@seketeli.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3.6 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Jul 2020 15:30:24 -0000 Giuliano Procida a =C3=A9crit: [...] >> +/// If a decl is decl-only get its definition. Otherwise, just return = nil. >> +/// >> +/// @param d the decl to consider. >> +/// >> +/// @return either the definition of the decl, or nil. >> +decl_base_sptr >> +look_through_decl_only(const decl_base& d) >> +{ >> + decl_base_sptr decl; >> + if (d.get_is_declaration_only()) >> + decl =3D d.get_definition_of_declaration(); >> + >> + if (!decl) >> + return decl; >> + >> + while (decl->get_is_declaration_only() >> + && decl->get_definition_of_declaration()) >> + decl =3D decl->get_definition_of_declaration(); >> + >> + ABG_ASSERT(decl); > > The assert is still here (and redundant - to be honest, the compiler > may be able to work this out for itself). Pff, right. I removed it now, thanks. > I didn't spot anything else, so all good. Thanks. I've just applied the series to master then. Cheers, --=20 Dodji