From: Dodji Seketeli <dodji@seketeli.org>
To: Matthias Maennich <maennich@google.com>
Cc: libabigail@sourceware.org, kernel-team@android.com
Subject: Re: [PATCH] Fix / add include guards
Date: Wed, 01 Jan 2020 00:00:00 -0000 [thread overview]
Message-ID: <864kwg6i1e.fsf@seketeli.org> (raw)
In-Reply-To: <20200127074102.117374-1-maennich@google.com> (Matthias Maennich's message of "Mon, 27 Jan 2020 07:41:02 +0000")
Hello Matthias,
Matthias Maennich <maennich@google.com> a écrit:
> Fix the include guards of abg-dwarf-reader.h and abg-reporter-priv.h by
> moving them before any other includes where they actually belongs.
> Add missing include guards for abg-libxml-utils.h and abg-libzip-utils.h.
>
> * include/abg-dwarf-reader.h: Move include guard to the beginning.
> * include/abg-reporter-priv.h: Likewise.
> * include/abg-libxml-utils.h: Add include guard.
> * include/abg-libzip-utils.h: Likewise.
This is OK to commit to master.
Thanks!
--
Dodji
next prev parent reply other threads:[~2020-01-27 15:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-01 0:00 Matthias Maennich via libabigail
2020-01-01 0:00 ` Dodji Seketeli [this message]
2020-01-01 0:00 ` Matthias Maennich via libabigail
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=864kwg6i1e.fsf@seketeli.org \
--to=dodji@seketeli.org \
--cc=kernel-team@android.com \
--cc=libabigail@sourceware.org \
--cc=maennich@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).