From: Dodji Seketeli <dodji@seketeli.org>
To: Giuliano Procida <gprocida@google.com>
Cc: Matthias Maennich <maennich@google.com>,
libabigail@sourceware.org, kernel-team@android.com
Subject: Re: [PATCH v3] Fix the reporting of leaf change statistics.
Date: Wed, 01 Jan 2020 00:00:00 -0000 [thread overview]
Message-ID: <865zfhyetw.fsf@seketeli.org> (raw)
In-Reply-To: <CAGvU0H=eGe4k08HX=BtqtsdU4Fpq3io+4r=_Ss-OUMiVSUu6aw@mail.gmail.com> (Giuliano Procida's message of "Tue, 3 Mar 2020 16:48:13 +0000")
Hello,
Giuliano Procida <gprocida@google.com> a écrit:
[...]
>> >diff --git a/tests/data/Makefile.am b/tests/data/Makefile.am
>> >index 5031e6d3..07077608 100644
>> >--- a/tests/data/Makefile.am
>> >+++ b/tests/data/Makefile.am
>> >@@ -110,6 +110,11 @@ test-abidiff-exit/test-loc-without-locs-report.txt \
>> > test-abidiff-exit/test-no-stray-comma-report.txt \
>> > test-abidiff-exit/test-no-stray-comma-v0.o \
>> > test-abidiff-exit/test-no-stray-comma-v1.o \
>> >+test-abidiff-exit/test-leaf0-v0.cc \
>>
>> I do not think we need to 'distribute' the source files here. I mean, it
>> will not harm, but they are mostly there for reference and not needed
>> during `make distcheck`.
>
> I was following someone else's example. Agreed, they are not needed in
> the Makefile.
Matthias is right in saying that we don't *need* to distribute the
source files.
However, I tend to always distribute them when we have them around, so
that even people who only have access to the tarball (yes that can still
happen even in this day and age) can tinker around with the source code,
make changes and try out stuff.
I thought I'd just throw this point of view in.
Thanks!
--
Dodji
next prev parent reply other threads:[~2020-03-06 10:09 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-01 0:00 [PATCH] " Giuliano Procida via libabigail
2020-01-01 0:00 ` [PATCH v2] " Giuliano Procida via libabigail
2020-01-01 0:00 ` [PATCH v3] " Giuliano Procida via libabigail
2020-01-01 0:00 ` [PATCH v4] " Giuliano Procida via libabigail
2020-03-09 15:10 ` [PATCH v5] " Giuliano Procida
2020-03-09 15:12 ` Giuliano Procida
2020-03-10 16:47 ` Dodji Seketeli
2020-01-01 0:00 ` [PATCH v3] " Matthias Maennich via libabigail
2020-01-01 0:00 ` Giuliano Procida via libabigail
2020-01-01 0:00 ` Dodji Seketeli [this message]
2020-01-01 0:00 ` Giuliano Procida via libabigail
2020-01-01 0:00 ` [PATCH v2] " Matthias Maennich via libabigail
2020-01-01 0:00 ` Matthias Maennich via libabigail
2020-01-01 0:00 ` Dodji Seketeli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=865zfhyetw.fsf@seketeli.org \
--to=dodji@seketeli.org \
--cc=gprocida@google.com \
--cc=kernel-team@android.com \
--cc=libabigail@sourceware.org \
--cc=maennich@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).