From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net [217.70.183.197]) by sourceware.org (Postfix) with ESMTPS id A36C6398B85D for ; Tue, 9 Feb 2021 14:39:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org A36C6398B85D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=seketeli.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=dodji@seketeli.org X-Originating-IP: 88.120.130.27 Received: from localhost (unknown [88.120.130.27]) (Authenticated sender: dodj@seketeli.org) by relay5-d.mail.gandi.net (Postfix) with ESMTPSA id 2CEBD1C000B; Tue, 9 Feb 2021 14:39:07 +0000 (UTC) Received: by localhost (Postfix, from userid 1001) id 9853F1A0FC6; Tue, 9 Feb 2021 15:39:07 +0100 (CET) From: Dodji Seketeli To: Giuliano Procida Cc: libabigail@sourceware.org, kernel-team@android.com, maennich@google.com Subject: Re: [PATCH] abg-dwarf-reader: Fix typo in compare_dies_string_attribute_value Organization: Me, myself and I References: <20210208173146.391981-1-gprocida@google.com> X-Operating-System: Red Hat Enterprise Linux Server 7.8 X-URL: http://www.seketeli.net/~dodji Date: Tue, 09 Feb 2021 15:39:07 +0100 In-Reply-To: <20210208173146.391981-1-gprocida@google.com> (Giuliano Procida's message of "Mon, 8 Feb 2021 17:31:46 +0000") Message-ID: <868s7xgvas.fsf@seketeli.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-10.5 required=5.0 tests=BAYES_00, GIT_PATCH_0, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Feb 2021 14:39:12 -0000 Giuliano Procida a =C3=A9crit: > A recent commit to add DW_FORM_line_strp support had a small typo in > an assertion. This commit corrects that. > > * src/abg-dwarf-reader.cc > (compare_dies_string_attribute_value): Typo fix. > > Signed-off-by: Giuliano Procida > --- > src/abg-dwarf-reader.cc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/abg-dwarf-reader.cc b/src/abg-dwarf-reader.cc > index 810da2f2..9004ff13 100644 > --- a/src/abg-dwarf-reader.cc > +++ b/src/abg-dwarf-reader.cc > @@ -9446,7 +9446,7 @@ compare_dies_string_attribute_value(const Dwarf_Die= *l, const Dwarf_Die *r, > || r_attr.form =3D=3D DW_FORM_string > || r_attr.form =3D=3D DW_FORM_GNU_strp_alt > || form_is_DW_FORM_strx(r_attr.form) > - || form_is_DW_FORM_line_strp(l_attr.form)); > + || form_is_DW_FORM_line_strp(r_attr.form)); >=20=20 > if ((l_attr.form =3D=3D DW_FORM_strp > && r_attr.form =3D=3D DW_FORM_strp) Applied to master, thanks! Cheers, --=20 Dodji