From: Dodji Seketeli <dodji@seketeli.org>
To: Giuliano Procida <gprocida@google.com>
Cc: libabigail@sourceware.org, kernel-team@android.com
Subject: Re: [PATCH 1/2] Rename test-abidiff-exit/test-leaf[0-3] files.
Date: Tue, 07 Apr 2020 15:22:35 +0200 [thread overview]
Message-ID: <868sj7ph0k.fsf@seketeli.org> (raw)
In-Reply-To: <20200406084450.140975-1-gprocida@google.com> (Giuliano Procida's message of "Mon, 6 Apr 2020 09:44:49 +0100")
Giuliano Procida <gprocida@google.com> a écrit:
> The files tests/data/test-abidiff-exit/test-leaf[0-3]-* were
> introduced in a series of changes. Numbering rather than naming the
> tests turned out to be a bad choice: it caused confusion when
> dealing with merge conflicts due to reordering of commits.
>
> This patch renames the tests to give them more descriptive names,
> which is good practice anyway.
>
> * tests/data/Makefile.am: Rename test files.
> * tests/test-abidiff-exit.cc: Rename test files.
> * tests/data/test-abidiff-exit/test-leaf-fun-type-report.txt:
> Renamed from test-leaf2-report.txt.
> * tests/data/test-abidiff-exit/test-leaf-fun-type-v0.cc:
> Renamed from test-leaf2-v0.cc.
> * tests/data/test-abidiff-exit/test-leaf-fun-type-v0.o:
> Renamed from test-leaf2-v0.o.
> * tests/data/test-abidiff-exit/test-leaf-fun-type-v1.cc:
> Renamed from test-leaf2-v1.cc.
> * tests/data/test-abidiff-exit/test-leaf-fun-type-v1.o:
> Renamed from test-leaf2-v1.o.
> * tests/data/test-abidiff-exit/test-leaf-more-report.txt:
> Renamed from test-leaf1-report.txt.
> * tests/data/test-abidiff-exit/test-leaf-more-v0.cc: Renamed
> from test-leaf1-v0.cc.
> * tests/data/test-abidiff-exit/test-leaf-more-v0.o: Renamed
> from test-leaf1-v0.o.
> * tests/data/test-abidiff-exit/test-leaf-more-v1.cc: Renamed
> from test-leaf1-v1.cc.
> * tests/data/test-abidiff-exit/test-leaf-more-v1.o: Renamed
> from test-leaf1-v1.o.
> * tests/data/test-abidiff-exit/test-leaf-redundant-report.txt:
> Renamed from test-leaf3-report.txt.
> * tests/data/test-abidiff-exit/test-leaf-redundant-v0.c:
> Renamed from test-leaf3-v0.c.
> * tests/data/test-abidiff-exit/test-leaf-redundant-v0.o:
> Renamed from test-leaf3-v0.o.
> * tests/data/test-abidiff-exit/test-leaf-redundant-v1.c:
> Renamed from test-leaf3-v1.c.
> * tests/data/test-abidiff-exit/test-leaf-redundant-v1.o:
> Renamed from test-leaf3-v1.o.
> * tests/data/test-abidiff-exit/test-leaf-stats-report.txt:
> Renamed from test-leaf0-report.txt.
> * tests/data/test-abidiff-exit/test-leaf-stats-v0.cc: Renamed
> from test-leaf0-v0.cc.
> * tests/data/test-abidiff-exit/test-leaf-stats-v0.o: Renamed
> from test-leaf0-v0.o.
> * tests/data/test-abidiff-exit/test-leaf-stats-v1.cc: Renamed
> from test-leaf0-v1.cc.
> * tests/data/test-abidiff-exit/test-leaf-stats-v1.o: Renamed
> from test-leaf0-v1.o.
Applied to master.
Thanks!
--
Dodji
prev parent reply other threads:[~2020-04-07 13:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-06 8:44 Giuliano Procida
2020-04-06 8:44 ` [PATCH 2/2] test-abidiff-exit.cc: Drop redundant --redundant Giuliano Procida
2020-04-06 11:25 ` Matthias Maennich
2020-04-07 13:22 ` Dodji Seketeli
2020-04-06 11:24 ` [PATCH 1/2] Rename test-abidiff-exit/test-leaf[0-3] files Matthias Maennich
2020-04-07 13:22 ` Dodji Seketeli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=868sj7ph0k.fsf@seketeli.org \
--to=dodji@seketeli.org \
--cc=gprocida@google.com \
--cc=kernel-team@android.com \
--cc=libabigail@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).