From: Dodji Seketeli <dodji@seketeli.org>
To: Giuliano Procida <gprocida@google.com>
Cc: libabigail@sourceware.org
Subject: Re: abg-dwarf-reader.cc - trouble with GNU hash tables
Date: Fri, 20 Mar 2020 23:22:01 +0100 [thread overview]
Message-ID: <868sjusm46.fsf@seketeli.org> (raw)
In-Reply-To: <CAGvU0HkvUN8479GhSkpQEEnCEfSOnQV7MwCc-+uZoS6EQrjsmQ@mail.gmail.com> (Giuliano Procida via Libabigail's message of "Thu, 19 Mar 2020 16:42:21 +0000")
Hello Giuliano,
Giuliano Procida via Libabigail <libabigail@sourceware.org> a écrit:
> Looking up symbols in shared objects with .gnu.hash sections doesn't
> always work. There is something not right with the Bloom filter code.
Hopefully, the patch at
https://sourceware.org/git/?p=libabigail.git;a=commit;h=b1b0586dc208726bd5de5728caf1ead119413fce
should address that.
> Testing notes follow. Ideally we should create files targeting a
> diversity of architectures (word size, endianness, special ones like
> Alpha and S390).
>
> for y in {0..999}; do echo $(printf "int x%03d = $y;" $y); done > extern.c
> gcc -g -Wall -W -fPIC --shared -c extern.c -o extern.o
> ld -fPIC --shared --soname foo extern.o -o extern.so
> for y in {0..999}; do sym=$(printf "x%03d" $y); build/tools/abisym
> extern.so "$sym"; done | grep -c ^could
> --> should be 0
>
Thanks for the test. I ran it on ppc64 an amd64 at least.
We'll see what the builders over at
https://builder.wildebeest.org/buildbot report.
Cheers,
--
Dodji
prev parent reply other threads:[~2020-03-20 22:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-19 16:42 Giuliano Procida
2020-03-20 22:22 ` Dodji Seketeli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=868sjusm46.fsf@seketeli.org \
--to=dodji@seketeli.org \
--cc=gprocida@google.com \
--cc=libabigail@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).