From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 82805 invoked by alias); 27 Jan 2020 15:21:28 -0000 Mailing-List: contact libabigail-help@sourceware.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Id: List-Subscribe: Sender: libabigail-owner@sourceware.org Received: (qmail 82788 invoked by uid 89); 27 Jan 2020 15:21:28 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.100.3 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-6.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.1 spammy= X-Spam-Status: No, score=-6.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on sourceware.org X-Spam-Level: X-HELO: relay9-d.mail.gandi.net Received: from relay9-d.mail.gandi.net (HELO relay9-d.mail.gandi.net) (217.70.183.199) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 27 Jan 2020 15:21:26 +0000 X-Originating-IP: 91.166.131.130 Received: from localhost (91-166-131-130.subs.proxad.net [91.166.131.130]) (Authenticated sender: dodj@seketeli.org) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id C2B6DFF805; Mon, 27 Jan 2020 15:21:22 +0000 (UTC) Received: by localhost (Postfix, from userid 1001) id BE4141A0696; Mon, 27 Jan 2020 16:21:21 +0100 (CET) From: Dodji Seketeli To: Matthias Maennich Cc: libabigail@sourceware.org, kernel-team@android.com Subject: Re: [PATCH] dwarf-reader: handle binaries with missing symtab Organization: Me, myself and I References: <20200127073846.107009-1-maennich@google.com> X-Operating-System: Red Hat Enterprise Linux Server 7.7 X-URL: http://www.seketeli.net/~dodji Date: Wed, 01 Jan 2020 00:00:00 -0000 In-Reply-To: <20200127073846.107009-1-maennich@google.com> (Matthias Maennich's message of "Mon, 27 Jan 2020 07:38:46 +0000") Message-ID: <868slt53im.fsf@seketeli.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2020-q1/txt/msg00045.txt Hello Matthias, Matthias Maennich a =C3=A9crit: > A broken elf file might not have a valid symtab. As of now we would hit > an ABG_ASSERT and crash. Let's catch that case and bail out instead. > > * src/abg-dwarf-reader.cc (load_symbol_maps_from_symtab_section): > Handle elf file with missing symtab. > * tests/test-read-dwarf.cc (InOutSpec): add test case. > * tests/data/test-read-dwarf/test26-bogus-binary.elf: new test da= ta. This is OK to commit to master. Thanks! --=20 Dodji