From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6942 invoked by alias); 12 Dec 2016 19:27:22 -0000 Mailing-List: contact libabigail-help@sourceware.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Subscribe: Sender: libabigail-owner@sourceware.org Received: (qmail 6921 invoked by uid 89); 12 Dec 2016 19:27:21 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.99.2 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy= X-Spam-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on sourceware.org X-Spam-Level: X-HELO: ms.seketeli.net From: Dodji Seketeli To: Ondrej Oprala Cc: libabigail@sourceware.org Subject: Re: [PATCH] abipkgdiff should properly report missing files Organization: Me, myself and I References: <812c4d76-7ee5-3cd9-a657-f1f9f30e1df1@gmail.com> X-Operating-System: Red Hat Enterprise Linux Server 7.3 X-URL: http://www.seketeli.net/~dodji Date: Fri, 01 Jan 2016 00:00:00 -0000 In-Reply-To: <812c4d76-7ee5-3cd9-a657-f1f9f30e1df1@gmail.com> (Ondrej Oprala's message of "Mon, 12 Dec 2016 16:28:53 +0100") Message-ID: <86bmwh0wz7.fsf@seketeli.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SW-Source: 2016-q4/txt/msg00045.txt.bz2 Ondrej Oprala a =C3=A9crit: > Subject: [PATCH] Properly report missing files for abipkgdiff > > Currently, if abipkgdiff is given a path to a nonexistent file, > it propagates all the way until package classification > and ends up being reported as "PKG should be a valid package file", > which doesn't hint it's not there at all. > > * tools/abipkgdiff.cc: (class options): Add the "nonexistent_file= " flag > (parse_command_line): Check if the files given exist. > (main): Check the nonexistent_file flag. If any of the input > files don't exist, report it and exit. This is OK. But I'd like a regrestion test to be added for this. That is, please add a new field to the in_out_specs array in tests/test-diff-pkg.cc. The would contain paths to non-existing input RPMs as well as reference output reports which contain the what "abipkgdiff non-existing1.rpm non-existing2.rpm" would have emitted. OK to commit to master with that change. Thanks! Cheers, --=20 Dodji